All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar
  2026-11-16  8:40 [PATCH v1 0/2] Add R-Car Gen5 PCI host support Mykyta Poturai
@ 2026-11-16  8:40 ` Mykyta Poturai
  2026-11-17 16:34   ` Oleksandr Tyshchenko
  2026-11-16  8:40 ` [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host Mykyta Poturai
  2026-11-16  9:44 ` [PATCH v1 0/2] Add R-Car Gen5 PCI host support Oleksii Kurochko
  2 siblings, 1 reply; 6+ messages in thread
From: Mykyta Poturai @ 2026-11-16  8:40 UTC (permalink / raw)
  To: xen-devel@lists.xenproject.org
  Cc: Mykyta Poturai, Andrew Cooper, Anthony PERARD, Michal Orzel,
	Jan Beulich, Julien Grall, Roger Pau Monné,
	Stefano Stabellini, Bertrand Marquis, Volodymyr Babchuk

Gen5 mostly reuses the same DesignWare integration and register layout
as Gen4, so one driver covers both. Drop the generation number from the
file and symbol names.

Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 MAINTAINERS                                   |  2 +-
 xen/arch/arm/pci/Makefile                     |  2 +-
 .../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 32 +++++++++----------
 .../pci/{pci-host-rcar4.h => pci-host-rcar.h} |  6 ++--
 xen/drivers/passthrough/arm/ipmmu-vmsa.c      |  2 +-
 5 files changed, 22 insertions(+), 22 deletions(-)
 rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (88%)
 rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)

diff --git a/MAINTAINERS b/MAINTAINERS
index b804434d52..68b47adf81 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -504,7 +504,7 @@ T:	git https://xenbits.xenproject.org/git-http/qemu-xen.git
 RCAR PCI
 M:	Mykyta Poturai <mykyta_poturai@epam.com>
 S:	Supported
-F:	xen/arch/arm/pci/pci-host-rcar4.c
+F:	xen/arch/arm/pci/pci-host-rcar.c
 
 REMUS
 S:	Orphan
diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile
index ca6135e282..431a91c46d 100644
--- a/xen/arch/arm/pci/Makefile
+++ b/xen/arch/arm/pci/Makefile
@@ -5,4 +5,4 @@ obj-y += pci-host-common.o
 obj-y += ecam.o
 obj-y += pci-host-zynqmp.o
 obj-y += pci-designware.o
-obj-y += pci-host-rcar4.o
+obj-y += pci-host-rcar.o
diff --git a/xen/arch/arm/pci/pci-host-rcar4.c b/xen/arch/arm/pci/pci-host-rcar.c
similarity index 88%
rename from xen/arch/arm/pci/pci-host-rcar4.c
rename to xen/arch/arm/pci/pci-host-rcar.c
index e1e8eb0ee1..5f184d5ebc 100644
--- a/xen/arch/arm/pci/pci-host-rcar4.c
+++ b/xen/arch/arm/pci/pci-host-rcar.c
@@ -13,9 +13,9 @@
 #include <asm/pci.h>
 
 #include "pci-designware.h"
-#include "pci-host-rcar4.h"
+#include "pci-host-rcar.h"
 
-#define RCAR4_DWC_VERSION       0x520A
+#define RCAR_DWC_VERSION     0x520A
 
 /* PCIE BDF-OSID assignment */
 #define CNVID(n)             (0x700 + ((n) * 4))
@@ -51,20 +51,20 @@ struct rcar4_pcie_priv {
  *   "config": child's configuration space
  *   "atu"   : iATU registers for DWC version 4.80 or later
  */
-static int __init rcar4_cfg_reg_index(struct dt_device_node *np)
+static int __init rcar_cfg_reg_index(struct dt_device_node *np)
 {
     return dt_property_match_string(np, "reg-names", "dbi");
 }
 
-static int __init rcar4_child_cfg_reg_index(struct dt_device_node *np)
+static int __init rcar_child_cfg_reg_index(struct dt_device_node *np)
 {
     return dt_property_match_string(np, "reg-names", "config");
 }
 
 /* ECAM ops */
-static const struct pci_ecam_ops rcar4_pcie_ops = {
+static const struct pci_ecam_ops rcar_pcie_ops = {
     .bus_shift  = 20,
-    .cfg_reg_index = rcar4_cfg_reg_index,
+    .cfg_reg_index = rcar_cfg_reg_index,
     .pci_ops    = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
@@ -74,9 +74,9 @@ static const struct pci_ecam_ops rcar4_pcie_ops = {
     }
 };
 
-static const struct pci_ecam_ops rcar4_pcie_child_ops = {
+static const struct pci_ecam_ops rcar_pcie_child_ops = {
     .bus_shift  = 20,
-    .cfg_reg_index = rcar4_child_cfg_reg_index,
+    .cfg_reg_index = rcar_child_cfg_reg_index,
     .pci_ops    = {
         .map_bus                = dw_pcie_child_map_bus,
         .read                   = dw_pcie_child_config_read,
@@ -86,7 +86,7 @@ static const struct pci_ecam_ops rcar4_pcie_child_ops = {
     }
 };
 
-static const struct dt_device_match __initconstrel rcar4_pcie_dt_match[] = {
+static const struct dt_device_match __initconstrel rcar_pcie_dt_match[] = {
     { .compatible = "renesas,r8a779f0-pcie" },
     { .compatible = "renesas,r8a779g0-pcie" },
     {},
@@ -179,8 +179,8 @@ void rcar4_pcie_bdf_msk_set(struct pci_host_bridge *bridge, unsigned int reg_id,
     rcar4_pcie_writel_app(priv, CNVIDMSK(reg_id), val);
 }
 
-static int __init pci_host_rcar4_probe(struct dt_device_node *dev,
-                                       const void *data)
+static int __init pci_host_rcar_probe(struct dt_device_node *dev,
+                                      const void *data)
 {
     struct pci_host_bridge *bridge;
     paddr_t app_phys_addr;
@@ -191,8 +191,8 @@ static int __init pci_host_rcar4_probe(struct dt_device_node *dev,
     if ( !priv )
         return -ENOMEM;
 
-    bridge = dw_pcie_host_probe(dev, data, &rcar4_pcie_ops,
-                                &rcar4_pcie_child_ops);
+    bridge = dw_pcie_host_probe(dev, data, &rcar_pcie_ops,
+                                &rcar_pcie_child_ops);
 
     app_idx = dt_property_match_string(dev, "reg-names", "app");
     if ( app_idx < 0 )
@@ -219,7 +219,7 @@ static int __init pci_host_rcar4_probe(struct dt_device_node *dev,
            app_phys_addr + app_size - 1);
 
     dw_pcie_set_priv(bridge, priv);
-    dw_pcie_set_version(bridge, RCAR4_DWC_VERSION);
+    dw_pcie_set_version(bridge, RCAR_DWC_VERSION);
 
     return 0;
 err:
@@ -228,8 +228,8 @@ err:
 }
 
 DT_DEVICE_START(pci_gen, "PCI HOST R-CAR GEN4", DEVICE_PCI_HOSTBRIDGE)
-.dt_match = rcar4_pcie_dt_match,
-.init = pci_host_rcar4_probe,
+.dt_match = rcar_pcie_dt_match,
+.init = pci_host_rcar_probe,
 DT_DEVICE_END
 
 /*
diff --git a/xen/arch/arm/pci/pci-host-rcar4.h b/xen/arch/arm/pci/pci-host-rcar.h
similarity index 88%
rename from xen/arch/arm/pci/pci-host-rcar4.h
rename to xen/arch/arm/pci/pci-host-rcar.h
index 31ef9d2d40..ffd49e3c1c 100644
--- a/xen/arch/arm/pci/pci-host-rcar4.h
+++ b/xen/arch/arm/pci/pci-host-rcar.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef __PCI_HOST_RCAR4_H__
-#define __PCI_HOST_RCAR4_H__
+#ifndef __PCI_HOST_RCAR_H__
+#define __PCI_HOST_RCAR_H__
 
 #include <asm/pci.h>
 
@@ -17,4 +17,4 @@ void rcar4_pcie_osid_reg_free(struct pci_host_bridge *bridge,
 int rcar4_pcie_osid_regs_init(struct pci_host_bridge *bridge);
 #endif
 
-#endif /* __PCI_HOST_RCAR4_H__ */
+#endif /* __PCI_HOST_RCAR_H__ */
diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 0648f9b407..bfb9df238a 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -51,7 +51,7 @@
 #include <asm/device.h>
 #include <asm/io.h>
 #include <asm/iommu_fwspec.h>
-#include "../arch/arm/pci/pci-host-rcar4.h"
+#include "../arch/arm/pci/pci-host-rcar.h"
 
 #define dev_name(dev) dt_node_full_name(dev_to_dt(dev))
 
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v1 0/2] Add R-Car Gen5 PCI host support
@ 2026-11-16  8:40 Mykyta Poturai
  2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Mykyta Poturai @ 2026-11-16  8:40 UTC (permalink / raw)
  To: xen-devel@lists.xenproject.org
  Cc: Mykyta Poturai, Andrew Cooper, Anthony PERARD, Michal Orzel,
	Jan Beulich, Julien Grall, Roger Pau Monné,
	Stefano Stabellini, Bertrand Marquis, Volodymyr Babchuk

Add R-Car Gen5 PCI host support to the existing Gen4 driver. Gen5 uses
the same DesignWare integration and register layout, so one driver
covers both.

Drop the generation number from the driver file and static symbols. Keep
the rcar4_ prefix on the exported OSID helpers, as the BDF-to-OSID
registers only exist on Gen4.

Add the "renesas,rcar-gen5-pcie6" compatible and skip the "app" register
range on Gen5, as the hardware does not have it.

Mykyta Poturai (2):
  pci/rcar: Rename PCI host rcar4 to rcar
  pci/rcar: Add support for Gen5 PCI host

 MAINTAINERS                                   |  2 +-
 xen/arch/arm/pci/Makefile                     |  2 +-
 .../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 49 ++++++++++++-------
 .../pci/{pci-host-rcar4.h => pci-host-rcar.h} |  6 +--
 xen/drivers/passthrough/arm/ipmmu-vmsa.c      |  2 +-
 5 files changed, 36 insertions(+), 25 deletions(-)
 rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (81%)
 rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)

-- 
2.56.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host
  2026-11-16  8:40 [PATCH v1 0/2] Add R-Car Gen5 PCI host support Mykyta Poturai
  2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
@ 2026-11-16  8:40 ` Mykyta Poturai
  2026-11-16 12:04   ` Oleksandr Tyshchenko
  2026-11-16  9:44 ` [PATCH v1 0/2] Add R-Car Gen5 PCI host support Oleksii Kurochko
  2 siblings, 1 reply; 6+ messages in thread
From: Mykyta Poturai @ 2026-11-16  8:40 UTC (permalink / raw)
  To: xen-devel@lists.xenproject.org
  Cc: Mykyta Poturai, Stefano Stabellini, Julien Grall,
	Bertrand Marquis, Michal Orzel, Volodymyr Babchuk

Add support for Renesas R-Car Gen5 PCI host controller. This includes
updating the device tree match table to recognize the new compatible
string "renesas,rcar-gen5-pcie6" and ensuring that the OSID registers
are only initialized when they are supported by the hardware.

Gen5 hosts do not expose the "app" register range, so only look it up
on Gen4.

Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/pci/pci-host-rcar.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/pci/pci-host-rcar.c b/xen/arch/arm/pci/pci-host-rcar.c
index 5f184d5ebc..87b3ccbc1c 100644
--- a/xen/arch/arm/pci/pci-host-rcar.c
+++ b/xen/arch/arm/pci/pci-host-rcar.c
@@ -17,6 +17,9 @@
 
 #define RCAR_DWC_VERSION     0x520A
 
+#define RCAR_GEN4    4
+#define RCAR_GEN5    5
+
 /* PCIE BDF-OSID assignment */
 #define CNVID(n)             (0x700 + ((n) * 4))
 #define CNVID_CNV_EN         (1U << 31)
@@ -87,8 +90,9 @@ static const struct pci_ecam_ops rcar_pcie_child_ops = {
 };
 
 static const struct dt_device_match __initconstrel rcar_pcie_dt_match[] = {
-    { .compatible = "renesas,r8a779f0-pcie" },
-    { .compatible = "renesas,r8a779g0-pcie" },
+    { .compatible = "renesas,r8a779f0-pcie", .data = (void *)RCAR_GEN4 },
+    { .compatible = "renesas,r8a779g0-pcie", .data = (void *)RCAR_GEN4 },
+    { .compatible = "renesas,rcar-gen5-pcie6", .data = (void *)RCAR_GEN5 },
     {},
 };
 
@@ -182,6 +186,7 @@ void rcar4_pcie_bdf_msk_set(struct pci_host_bridge *bridge, unsigned int reg_id,
 static int __init pci_host_rcar_probe(struct dt_device_node *dev,
                                       const void *data)
 {
+    const struct dt_device_match *match;
     struct pci_host_bridge *bridge;
     paddr_t app_phys_addr;
     paddr_t app_size;
@@ -194,6 +199,11 @@ static int __init pci_host_rcar_probe(struct dt_device_node *dev,
     bridge = dw_pcie_host_probe(dev, data, &rcar_pcie_ops,
                                 &rcar_pcie_child_ops);
 
+    match = dt_match_node(rcar_pcie_dt_match, dev);
+    ASSERT(match);
+    if ( match->data != (void *)RCAR_GEN4 )
+        goto skip_app;
+
     app_idx = dt_property_match_string(dev, "reg-names", "app");
     if ( app_idx < 0 )
     {
@@ -218,6 +228,7 @@ static int __init pci_host_rcar_probe(struct dt_device_node *dev,
     printk("APP at [mem 0x%" PRIpaddr "-0x%" PRIpaddr "]\n", app_phys_addr,
            app_phys_addr + app_size - 1);
 
+skip_app:
     dw_pcie_set_priv(bridge, priv);
     dw_pcie_set_version(bridge, RCAR_DWC_VERSION);
 
@@ -227,7 +238,7 @@ err:
     return ret;
 }
 
-DT_DEVICE_START(pci_gen, "PCI HOST R-CAR GEN4", DEVICE_PCI_HOSTBRIDGE)
+DT_DEVICE_START(pci_gen, "PCI HOST R-CAR GEN4/GEN5", DEVICE_PCI_HOSTBRIDGE)
 .dt_match = rcar_pcie_dt_match,
 .init = pci_host_rcar_probe,
 DT_DEVICE_END
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 0/2] Add R-Car Gen5 PCI host support
  2026-11-16  8:40 [PATCH v1 0/2] Add R-Car Gen5 PCI host support Mykyta Poturai
  2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
  2026-11-16  8:40 ` [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host Mykyta Poturai
@ 2026-11-16  9:44 ` Oleksii Kurochko
  2 siblings, 0 replies; 6+ messages in thread
From: Oleksii Kurochko @ 2026-11-16  9:44 UTC (permalink / raw)
  To: Mykyta Poturai, xen-devel@lists.xenproject.org
  Cc: Andrew Cooper, Anthony PERARD, Michal Orzel, Jan Beulich,
	Julien Grall, Roger Pau Monné, Stefano Stabellini,
	Bertrand Marquis, Volodymyr Babchuk

Hello Mykyta,

On 11/16/26 9:40 AM, Mykyta Poturai wrote:
> Add R-Car Gen5 PCI host support to the existing Gen4 driver. Gen5 uses
> the same DesignWare integration and register layout, so one driver
> covers both.
> 
> Drop the generation number from the driver file and static symbols. Keep
> the rcar4_ prefix on the exported OSID helpers, as the BDF-to-OSID
> registers only exist on Gen4.
> 
> Add the "renesas,rcar-gen5-pcie6" compatible and skip the "app" register
> range on Gen5, as the hardware does not have it.
> 
> Mykyta Poturai (2):
>    pci/rcar: Rename PCI host rcar4 to rcar
>    pci/rcar: Add support for Gen5 PCI host
> 
>   MAINTAINERS                                   |  2 +-
>   xen/arch/arm/pci/Makefile                     |  2 +-
>   .../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 49 ++++++++++++-------
>   .../pci/{pci-host-rcar4.h => pci-host-rcar.h} |  6 +--
>   xen/drivers/passthrough/arm/ipmmu-vmsa.c      |  2 +-
>   5 files changed, 36 insertions(+), 25 deletions(-)
>   rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (81%)
>   rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)
> 

Could you also please add item in CHANGELOG.md if v2 will be needed?

Thanks in advance.

~ Oleksii


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host
  2026-11-16  8:40 ` [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host Mykyta Poturai
@ 2026-11-16 12:04   ` Oleksandr Tyshchenko
  0 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Tyshchenko @ 2026-11-16 12:04 UTC (permalink / raw)
  To: Mykyta Poturai, xen-devel@lists.xenproject.org
  Cc: Stefano Stabellini, Julien Grall, Bertrand Marquis, Michal Orzel,
	Volodymyr Babchuk



16.11.2026 10:40, Mykyta Poturai пишет:


Hello Mykyta

> Add support for Renesas R-Car Gen5 PCI host controller. This includes
> updating the device tree match table to recognize the new compatible
> string "renesas,rcar-gen5-pcie6" and ensuring that the OSID registers
> are only initialized when they are supported by the hardware.


NIT: It is not entirely precise, the code only skips the app range 
lookup and ioremap on Gen5. Nothing guards OSID initialisation. That is 
harmless, because only the IPMMU driver uses it and Gen5 uses SMMUv3.


> 
> Gen5 hosts do not expose the "app" register range, so only look it up
> on Gen4.
> 
> Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
> ---
>   xen/arch/arm/pci/pci-host-rcar.c | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/pci/pci-host-rcar.c b/xen/arch/arm/pci/pci-host-rcar.c
> index 5f184d5ebc..87b3ccbc1c 100644
> --- a/xen/arch/arm/pci/pci-host-rcar.c
> +++ b/xen/arch/arm/pci/pci-host-rcar.c
> @@ -17,6 +17,9 @@
>   
>   #define RCAR_DWC_VERSION     0x520A
>   
> +#define RCAR_GEN4    4
> +#define RCAR_GEN5    5
> +
>   /* PCIE BDF-OSID assignment */
>   #define CNVID(n)             (0x700 + ((n) * 4))
>   #define CNVID_CNV_EN         (1U << 31)
> @@ -87,8 +90,9 @@ static const struct pci_ecam_ops rcar_pcie_child_ops = {
>   };
>   
>   static const struct dt_device_match __initconstrel rcar_pcie_dt_match[] = {
> -    { .compatible = "renesas,r8a779f0-pcie" },
> -    { .compatible = "renesas,r8a779g0-pcie" },
> +    { .compatible = "renesas,r8a779f0-pcie", .data = (void *)RCAR_GEN4 },
> +    { .compatible = "renesas,r8a779g0-pcie", .data = (void *)RCAR_GEN4 },
> +    { .compatible = "renesas,rcar-gen5-pcie6", .data = (void *)RCAR_GEN5 },
>       {},
>   };
>   
> @@ -182,6 +186,7 @@ void rcar4_pcie_bdf_msk_set(struct pci_host_bridge *bridge, unsigned int reg_id,
>   static int __init pci_host_rcar_probe(struct dt_device_node *dev,
>                                         const void *data)
>   {
> +    const struct dt_device_match *match;
>       struct pci_host_bridge *bridge;
>       paddr_t app_phys_addr;
>       paddr_t app_size;
> @@ -194,6 +199,11 @@ static int __init pci_host_rcar_probe(struct dt_device_node *dev,
>       bridge = dw_pcie_host_probe(dev, data, &rcar_pcie_ops,
>                                   &rcar_pcie_child_ops);

Remark: The result of dw_pcie_host_probe() is not checked. On failure it 
returns an ERR_PTR ...


>   
> +    match = dt_match_node(rcar_pcie_dt_match, dev);
> +    ASSERT(match);

NIT: To be honest, I am not entirely sure why this assert is here. I 
assume it was copied from existing code. As far as I understand, 
dt_match_node() cannot fail here, because the device was already matched 
to reach the probe...

> +    if ( match->data != (void *)RCAR_GEN4 )
> +        goto skip_app;
> +
>       app_idx = dt_property_match_string(dev, "reg-names", "app");
>       if ( app_idx < 0 )
>       {
> @@ -218,6 +228,7 @@ static int __init pci_host_rcar_probe(struct dt_device_node *dev,
>       printk("APP at [mem 0x%" PRIpaddr "-0x%" PRIpaddr "]\n", app_phys_addr,
>              app_phys_addr + app_size - 1);
>   
> +skip_app:
>       dw_pcie_set_priv(bridge, priv);

  ... which dw_pcie_set_priv() then dereferences. This is pre-existing, 
so maybe better to fix it in prereq commit.

As for the current commit:
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>


>       dw_pcie_set_version(bridge, RCAR_DWC_VERSION);
>   
> @@ -227,7 +238,7 @@ err:
>       return ret;
>   }
>   
> -DT_DEVICE_START(pci_gen, "PCI HOST R-CAR GEN4", DEVICE_PCI_HOSTBRIDGE)
> +DT_DEVICE_START(pci_gen, "PCI HOST R-CAR GEN4/GEN5", DEVICE_PCI_HOSTBRIDGE)
>   .dt_match = rcar_pcie_dt_match,
>   .init = pci_host_rcar_probe,
>   DT_DEVICE_END



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar
  2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
@ 2026-11-17 16:34   ` Oleksandr Tyshchenko
  0 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Tyshchenko @ 2026-11-17 16:34 UTC (permalink / raw)
  To: Mykyta Poturai, xen-devel@lists.xenproject.org
  Cc: Andrew Cooper, Anthony PERARD, Michal Orzel, Jan Beulich,
	Julien Grall, Roger Pau Monné, Stefano Stabellini,
	Bertrand Marquis, Volodymyr Babchuk



16.11.2026 10:40, Mykyta Poturai пишет:

Hello Mykyta

> Gen5 mostly reuses the same DesignWare integration and register layout
> as Gen4, so one driver covers both. Drop the generation number from the
> file and symbol names.

NIT: But rcar4_pcie_osid_*, rcar4_pcie_bdf_msk_set, struct 
rcar4_pcie_priv, etc keep the generation number. Yes, the reason (the 
registers exist only on Gen4) is mentioned in cover letter, but this 
will not be committed to git history. I would add a sentence in the 
patch description.


> 
> Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
> ---
>   MAINTAINERS                                   |  2 +-
>   xen/arch/arm/pci/Makefile                     |  2 +-
>   .../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 32 +++++++++----------
>   .../pci/{pci-host-rcar4.h => pci-host-rcar.h} |  6 ++--
>   xen/drivers/passthrough/arm/ipmmu-vmsa.c      |  2 +-
>   5 files changed, 22 insertions(+), 22 deletions(-)
>   rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (88%)
>   rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b804434d52..68b47adf81 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -504,7 +504,7 @@ T:	git https://xenbits.xenproject.org/git-http/qemu-xen.git
>   RCAR PCI
>   M:	Mykyta Poturai <mykyta_poturai@epam.com>
>   S:	Supported
> -F:	xen/arch/arm/pci/pci-host-rcar4.c
> +F:	xen/arch/arm/pci/pci-host-rcar.c

Remark: pci-host-rcar.h is not covered by the RCAR PCI entry. Yes, this 
is pre-existing and not caused by the rename, I thought the line was 
edited anyway, so it would be a cheap addition.

I did not find any issues with current patch.

Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

>   
...

[snip]


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-17 16:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  8:40 [PATCH v1 0/2] Add R-Car Gen5 PCI host support Mykyta Poturai
2026-11-16  8:40 ` [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar Mykyta Poturai
2026-11-17 16:34   ` Oleksandr Tyshchenko
2026-11-16  8:40 ` [PATCH v1 2/2] pci/rcar: Add support for Gen5 PCI host Mykyta Poturai
2026-11-16 12:04   ` Oleksandr Tyshchenko
2026-11-16  9:44 ` [PATCH v1 0/2] Add R-Car Gen5 PCI host support Oleksii Kurochko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.