All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [kvm-ppc-devel] [PATCH 2 of 7] Ensure 4kB page alignment for
Date: Mon, 28 Jan 2008 03:16:25 +0000	[thread overview]
Message-ID: <57f4e5bd23e0da3c493e.1201490185@thinkpad> (raw)
In-Reply-To: <patchbomb.1201490183@thinkpad>

# HG changeset patch
# User Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
# Date 1201488336 21600
# Node ID 57f4e5bd23e0da3c493e769e3e2b738e1495f7ef
# Parent  4b35e985aaf2021d956b09bd690c72ea5cadb007
Ensure 4kB page alignment for embedded powerpc when using kvm

Powerpc needs 4kB aligned pages when using qemu together with kvm. Qemu already had a similar issue when CONFIG_USER_ONLY was set so this patch adds just one more condition to the existing ifdef.

Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>

diff --git a/qemu/target-ppc/cpu.h b/qemu/target-ppc/cpu.h
--- a/qemu/target-ppc/cpu.h
+++ b/qemu/target-ppc/cpu.h
@@ -50,9 +50,10 @@ typedef uint32_t ppc_gpr_t;
 /* Specific definitions for PowerPC embedded */
 /* BookE have 36 bits physical address space */
 #define TARGET_PHYS_ADDR_BITS 64
-#if defined(CONFIG_USER_ONLY)
+#if defined(CONFIG_USER_ONLY) || defined(USE_KVM)
 /* It looks like a lot of Linux programs assume page size
  * is 4kB long. This is evil, but we have to deal with it...
+ * Also kvm for embedded powerpc needs (atm) 4kB aligned pages
  */
 #define TARGET_PAGE_BITS 12
 #else /* defined(CONFIG_USER_ONLY) */

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH 2 of 7] Ensure 4kB page alignment for embedded powerpc when	using kvm
Date: Sun, 27 Jan 2008 21:16:25 -0600	[thread overview]
Message-ID: <57f4e5bd23e0da3c493e.1201490185@thinkpad> (raw)
In-Reply-To: <patchbomb.1201490183@thinkpad>

# HG changeset patch
# User Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
# Date 1201488336 21600
# Node ID 57f4e5bd23e0da3c493e769e3e2b738e1495f7ef
# Parent  4b35e985aaf2021d956b09bd690c72ea5cadb007
Ensure 4kB page alignment for embedded powerpc when using kvm

Powerpc needs 4kB aligned pages when using qemu together with kvm. Qemu already had a similar issue when CONFIG_USER_ONLY was set so this patch adds just one more condition to the existing ifdef.

Signed-off-by: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/qemu/target-ppc/cpu.h b/qemu/target-ppc/cpu.h
--- a/qemu/target-ppc/cpu.h
+++ b/qemu/target-ppc/cpu.h
@@ -50,9 +50,10 @@ typedef uint32_t ppc_gpr_t;
 /* Specific definitions for PowerPC embedded */
 /* BookE have 36 bits physical address space */
 #define TARGET_PHYS_ADDR_BITS 64
-#if defined(CONFIG_USER_ONLY)
+#if defined(CONFIG_USER_ONLY) || defined(USE_KVM)
 /* It looks like a lot of Linux programs assume page size
  * is 4kB long. This is evil, but we have to deal with it...
+ * Also kvm for embedded powerpc needs (atm) 4kB aligned pages
  */
 #define TARGET_PAGE_BITS 12
 #else /* defined(CONFIG_USER_ONLY) */

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-28  3:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28  3:16 [kvm-ppc-devel] [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement Jerone Young
2008-01-28  3:16 ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 1 of 7] Enhnace kvm-userspace configure Jerone Young
2008-01-28  3:16   ` [PATCH 1 of 7] Enhnace kvm-userspace configure script for powerpc Jerone Young
2008-01-28  3:16 ` Jerone Young [this message]
2008-01-28  3:16   ` [PATCH 2 of 7] Ensure 4kB page alignment for embedded powerpc when using kvm Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 3 of 7] Chnage so that Powerpc & IA64 do not Jerone Young
2008-01-28  3:16   ` [PATCH 3 of 7] Chnage so that Powerpc & IA64 do not have KVM_EXTRA_PAGES set Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 4 of 7] Add vcpu to arguments of powerpc Jerone Young
2008-01-28  3:16   ` [PATCH 4 of 7] Add vcpu to arguments of powerpc libkvm callbacks Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 5 of 7] Add qemu powerpc build support Jerone Young
2008-01-28  3:16   ` Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 6 of 7] Add powerpc KVM support to qemu Jerone Young
2008-01-28  3:16   ` Jerone Young
2008-01-28  3:16 ` [kvm-ppc-devel] [PATCH 7 of 7] Add Powerpc 440 board model "bamboo" Jerone Young
2008-01-28  3:16   ` [PATCH 7 of 7] Add Powerpc 440 board model "bamboo" to take advantage of Powerpc KVM Jerone Young
2008-01-28  3:46 ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Anthony Liguori
2008-01-28  3:46   ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Anthony Liguori
     [not found]   ` <479D5032.6050807-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-28 16:01     ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Jerone Young
2008-01-28 16:01       ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Jerone Young
2008-01-28 16:17       ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Anthony Liguori
2008-01-28 16:17         ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Anthony Liguori
     [not found]         ` <479E0029.3090906-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-28 16:20           ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Jerone Young
2008-01-28 16:20             ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Jerone Young
2008-01-28 16:48           ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Hollis Blanchard
2008-01-28 16:48             ` [kvm-ppc-devel] [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Hollis Blanchard
2008-01-28 11:03 ` [kvm-ppc-devel] [kvm-devel] [PATCH 0 of 7] PowerPC Embedded KVM Avi Kivity
2008-01-28 11:03   ` [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57f4e5bd23e0da3c493e.1201490185@thinkpad \
    --to=jyoung5@us.ibm.com \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.