From: vaishali.thakkar@oracle.com (Vaishali Thakkar)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results
Date: Tue, 18 Oct 2016 22:23:10 +0530 [thread overview]
Message-ID: <58065376.5020406@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610181833560.2950@hadrien>
On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote:
> I get the following in patch mode that I don't get in context mode:
Hi,
Are you getting same number of devm cases in your report for the context
and patch mode? [except this case]
> diff -u -p a/drivers/power/supply/tps65090-charger.c
> b/drivers/power/supply/tps\
> 65090-charger.c
> --- a/drivers/power/supply/tps65090-charger.c
> +++ b/drivers/power/supply/tps65090-charger.c
> @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct
>
> if (irq != -ENXIO) {
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> - tps65090_charger_isr, 0, "tps65090-charger", cdata);
> + tps65090_charger_isr, IRQF_ONESHOT,
> + "tps65090-charger", cdata);
> if (ret) {
> dev_err(cdata->dev,
> "Unable to register irq %d err %d\n", irq,
>
>
> julia
>
--
Vaishali
WARNING: multiple messages have this Message-ID (diff)
From: Vaishali Thakkar <vaishali.thakkar@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
lars@metafoo.de
Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results
Date: Tue, 18 Oct 2016 22:23:10 +0530 [thread overview]
Message-ID: <58065376.5020406@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610181833560.2950@hadrien>
On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote:
> I get the following in patch mode that I don't get in context mode:
Hi,
Are you getting same number of devm cases in your report for the context
and patch mode? [except this case]
> diff -u -p a/drivers/power/supply/tps65090-charger.c
> b/drivers/power/supply/tps\
> 65090-charger.c
> --- a/drivers/power/supply/tps65090-charger.c
> +++ b/drivers/power/supply/tps65090-charger.c
> @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct
>
> if (irq != -ENXIO) {
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> - tps65090_charger_isr, 0, "tps65090-charger", cdata);
> + tps65090_charger_isr, IRQF_ONESHOT,
> + "tps65090-charger", cdata);
> if (ret) {
> dev_err(cdata->dev,
> "Unable to register irq %d err %d\n", irq,
>
>
> julia
>
--
Vaishali
next prev parent reply other threads:[~2016-10-18 16:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 17:06 [Cocci] [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results Vaishali Thakkar
2016-10-16 17:06 ` Vaishali Thakkar
2016-10-16 17:07 ` [Cocci] [PATCH v2 3/3] Coccinelle: misc: Add support for devm variant in all modes Vaishali Thakkar
2016-10-16 17:07 ` Vaishali Thakkar
2016-10-18 17:01 ` [Cocci] " Vaishali Thakkar
2016-10-18 17:01 ` Vaishali Thakkar
2016-10-18 17:05 ` [Cocci] " Vaishali Thakkar
2016-10-18 17:05 ` Vaishali Thakkar
2016-10-18 17:10 ` [Cocci] " Julia Lawall
2016-10-18 17:10 ` Julia Lawall
2016-10-18 17:35 ` [Cocci] " Vaishali Thakkar
2016-10-18 17:35 ` Vaishali Thakkar
2016-10-16 17:09 ` [Cocci] [PATCH v2 1/3] Coccinelle: misc: Improve the matching of rules Vaishali Thakkar
2016-10-16 17:09 ` Vaishali Thakkar
2016-11-01 20:30 ` [Cocci] " SF Markus Elfring
2016-11-01 20:36 ` Julia Lawall
2016-11-01 20:43 ` SF Markus Elfring
2016-11-01 20:50 ` Julia Lawall
2016-11-01 21:02 ` SF Markus Elfring
[not found] ` <alpine.DEB.2.10.1611012206200.6300@hadrien>
2016-11-01 21:27 ` [Cocci] " SF Markus Elfring
2016-10-16 17:10 ` [Cocci] [PATCH v2 2/3] Coccinelle: misc: Improve the result given by context mode Vaishali Thakkar
2016-10-16 17:10 ` Vaishali Thakkar
2016-10-18 16:34 ` [Cocci] [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results Julia Lawall
2016-10-18 16:34 ` Julia Lawall
2016-10-18 16:53 ` Vaishali Thakkar [this message]
2016-10-18 16:53 ` Vaishali Thakkar
2016-10-18 17:01 ` [Cocci] " Julia Lawall
2016-10-18 17:01 ` Julia Lawall
2016-10-18 17:11 ` [Cocci] " Vaishali Thakkar
2016-10-18 17:11 ` Vaishali Thakkar
2016-10-18 18:05 ` [Cocci] " Julia Lawall
2016-10-18 18:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58065376.5020406@oracle.com \
--to=vaishali.thakkar@oracle.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.