* [PATCH] drm/amdgpu: fix a vm_flush fence leak
@ 2016-10-23 18:31 Grazvydas Ignotas
[not found] ` <1477247507-11378-3-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Grazvydas Ignotas @ 2016-10-23 18:31 UTC (permalink / raw)
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Looks like .last_flush reference is left at teardown.
Leak reported by CONFIG_SLUB_DEBUG.
Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index ded57dd..d6c2839 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)
fence_put(adev->vm_manager.ids[i].first);
amdgpu_sync_free(&adev->vm_manager.ids[i].active);
fence_put(id->flushed_updates);
+ fence_put(id->last_flush);
}
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: fix a vm_flush fence leak
[not found] ` <1477247507-11378-3-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-10-24 2:32 ` zhoucm1
2016-10-24 9:07 ` Christian König
0 siblings, 1 reply; 4+ messages in thread
From: zhoucm1 @ 2016-10-24 2:32 UTC (permalink / raw)
To: Grazvydas Ignotas, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
> Looks like .last_flush reference is left at teardown.
> Leak reported by CONFIG_SLUB_DEBUG.
>
> Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index ded57dd..d6c2839 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)
> fence_put(adev->vm_manager.ids[i].first);
> amdgpu_sync_free(&adev->vm_manager.ids[i].active);
> fence_put(id->flushed_updates);
> + fence_put(id->last_flush);
> }
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: fix a vm_flush fence leak
2016-10-24 2:32 ` zhoucm1
@ 2016-10-24 9:07 ` Christian König
2016-10-24 16:11 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2016-10-24 9:07 UTC (permalink / raw)
To: zhoucm1, Grazvydas Ignotas, dri-devel, amd-gfx
Am 24.10.2016 um 04:32 schrieb zhoucm1:
>
>
> On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
>> Looks like .last_flush reference is left at teardown.
>> Leak reported by CONFIG_SLUB_DEBUG.
>>
>> Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
>> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index ded57dd..d6c2839 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct
>> amdgpu_device *adev)
>> fence_put(adev->vm_manager.ids[i].first);
>> amdgpu_sync_free(&adev->vm_manager.ids[i].active);
>> fence_put(id->flushed_updates);
>> + fence_put(id->last_flush);
>> }
>> }
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: fix a vm_flush fence leak
2016-10-24 9:07 ` Christian König
@ 2016-10-24 16:11 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2016-10-24 16:11 UTC (permalink / raw)
To: Christian König; +Cc: amd-gfx list, Maling list - DRI developers
On Mon, Oct 24, 2016 at 5:07 AM, Christian König
<deathsimple@vodafone.de> wrote:
> Am 24.10.2016 um 04:32 schrieb zhoucm1:
>>
>>
>>
>> On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
>>>
>>> Looks like .last_flush reference is left at teardown.
>>> Leak reported by CONFIG_SLUB_DEBUG.
>>>
>>> Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
>>> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
>>
>> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>.
>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index ded57dd..d6c2839 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device
>>> *adev)
>>> fence_put(adev->vm_manager.ids[i].first);
>>> amdgpu_sync_free(&adev->vm_manager.ids[i].active);
>>> fence_put(id->flushed_updates);
>>> + fence_put(id->last_flush);
>>> }
>>> }
Applied. Thanks!
Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-24 16:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-23 18:31 [PATCH] drm/amdgpu: fix a vm_flush fence leak Grazvydas Ignotas
[not found] ` <1477247507-11378-3-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-24 2:32 ` zhoucm1
2016-10-24 9:07 ` Christian König
2016-10-24 16:11 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.