All of lore.kernel.org
 help / color / mirror / Atom feed
From: xinhui <xinhui.pan@linux.vnet.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"xen-devel-request@lists.xenproject.org"
	<xen-devel-request@lists.xenproject.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "kernellwp@gmail.com" <kernellwp@gmail.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"paulus@samba.org" <paulus@samba.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check
Date: Mon, 24 Oct 2016 10:44:45 +0800	[thread overview]
Message-ID: <580D759D.4000304@linux.vnet.ibm.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com>



On 2016年10月21日 19:27, David Laight wrote:
> From: Pan Xinhui
>> Sent: 20 October 2016 22:28
>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8
>> preempted" into struct kvm_steal_time. This field tells if one vcpu is
>> running or not.
>>
>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is
>> preempted. Other values means the vcpu has been preempted.
>>
>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>> ---
>>   Documentation/virtual/kvm/msr.txt | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt
>> index 2a71c8f..3376f13 100644
>> --- a/Documentation/virtual/kvm/msr.txt
>> +++ b/Documentation/virtual/kvm/msr.txt
>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03
>>   		__u64 steal;
>>   		__u32 version;
>>   		__u32 flags;
>> -		__u32 pad[12];
>> +		__u8  preempted;
>> +		__u32 pad[11];
>>   	}
>
> I think I'd be explicit about the 3 pad bytes you've left.
>
yes,I  will do it in next version.

thanks

> 	David
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: xinhui <xinhui.pan@linux.vnet.ibm.com>
To: David Laight <David.Laight@ACULAB.COM>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"xen-devel-request@lists.xenproject.org"
	<xen-devel-request@lists.xenproject.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "kernellwp@gmail.com" <kernellwp@gmail.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"paulus@samba.org" <paulus@samba.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>
Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check
Date: Mon, 24 Oct 2016 10:44:45 +0800	[thread overview]
Message-ID: <580D759D.4000304@linux.vnet.ibm.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com>



On 2016年10月21日 19:27, David Laight wrote:
> From: Pan Xinhui
>> Sent: 20 October 2016 22:28
>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8
>> preempted" into struct kvm_steal_time. This field tells if one vcpu is
>> running or not.
>>
>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is
>> preempted. Other values means the vcpu has been preempted.
>>
>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>> ---
>>   Documentation/virtual/kvm/msr.txt | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt
>> index 2a71c8f..3376f13 100644
>> --- a/Documentation/virtual/kvm/msr.txt
>> +++ b/Documentation/virtual/kvm/msr.txt
>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03
>>   		__u64 steal;
>>   		__u32 version;
>>   		__u32 flags;
>> -		__u32 pad[12];
>> +		__u8  preempted;
>> +		__u32 pad[11];
>>   	}
>
> I think I'd be explicit about the 3 pad bytes you've left.
>
yes,I  will do it in next version.

thanks

> 	David
>

  parent reply	other threads:[~2016-10-24  2:44 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 21:27 [PATCH v5 0/9] implement vcpu preempted check Pan Xinhui
2016-10-20 21:27 ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 1/9] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-10-20 21:27   ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 2/9] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-10-20 21:27   ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 3/9] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui
2016-10-20 21:27   ` [PATCH v5 3/9] kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner Pan Xinhui
2016-10-20 21:27   ` [PATCH v5 3/9] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 4/9] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-10-20 21:27   ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 5/9] x86, paravirt: Add interface to support kvm/xen " Pan Xinhui
2016-10-20 21:27   ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 6/9] x86, kvm: support " Pan Xinhui
2016-10-24  8:08   ` xinhui
2016-10-24  8:08   ` xinhui
2016-10-20 21:27 ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 7/9] x86, xen: " Pan Xinhui
2016-10-21  5:08   ` Juergen Gross
2016-10-21  5:08   ` Juergen Gross
2016-10-20 21:27 ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 8/9] s390/spinlock: Provide vcpu_is_preempted Pan Xinhui
2016-10-20 21:27 ` Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check Pan Xinhui
2016-10-20 21:27 ` Pan Xinhui
2016-10-21  1:23   ` Boqun Feng
2016-10-21  1:23   ` Boqun Feng
2016-10-21  1:42     ` Pan Xinhui
2016-10-21  1:42       ` Pan Xinhui
2016-10-21 11:27   ` David Laight
2016-10-21 11:27     ` David Laight
2016-10-21 18:39     ` rkrcmar
2016-10-21 18:39       ` rkrcmar
2016-10-24  2:46       ` xinhui
2016-10-24  2:46         ` xinhui
2016-10-24 14:42       ` Paolo Bonzini
2016-10-24 14:42         ` Paolo Bonzini
2016-10-24 15:05         ` rkrcmar
2016-10-24 15:05           ` rkrcmar
2016-10-24 15:05         ` rkrcmar
2016-10-21 18:39     ` rkrcmar
2016-10-24  2:44     ` xinhui [this message]
2016-10-24  2:44       ` xinhui
2016-10-21 11:27   ` David Laight
2016-10-24  8:12   ` xinhui
2016-10-24  8:12   ` xinhui
2016-10-21  5:40 ` [PATCH v5 0/9] implement " Peter Zijlstra
2016-10-21  5:40 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=580D759D.4000304@linux.vnet.ibm.com \
    --to=xinhui.pan@linux.vnet.ibm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=boqun.feng@gmail.com \
    --cc=jgross@suse.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=xen-devel-request@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.