All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Robert Richter <rric@kernel.org>,
	linux-ide@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
	Auger Eric <eric.auger@redhat.com>,
	Robert Richter <robert.richter@cavium.com>,
	dan.j.williamps@intel.com, Tejun Heo <tj@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ahci: use pci_alloc_irq_vectors
Date: Mon, 24 Oct 2016 11:57:46 -0700	[thread overview]
Message-ID: <580E59AA.60107@gmail.com> (raw)
In-Reply-To: <20161022141123.GA25500@lst.de>

Hi Christoph,

I can answer these...

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?

Yes.  This is a ThunderX SoC with on-chip AHCI that use MSI-X

>
> If so can you try the patch below?

I applied it to v4.9-rc1 (really commit 
6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make 
it work.



>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>


WARNING: multiple messages have this Message-ID (diff)
From: ddaney.cavm@gmail.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci: use pci_alloc_irq_vectors
Date: Mon, 24 Oct 2016 11:57:46 -0700	[thread overview]
Message-ID: <580E59AA.60107@gmail.com> (raw)
In-Reply-To: <20161022141123.GA25500@lst.de>

Hi Christoph,

I can answer these...

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?

Yes.  This is a ThunderX SoC with on-chip AHCI that use MSI-X

>
> If so can you try the patch below?

I applied it to v4.9-rc1 (really commit 
6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make 
it work.



>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

  reply	other threads:[~2016-10-24 18:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 15:21 (unknown), Christoph Hellwig
2016-09-05 15:21 ` [PATCH] ahci: use pci_alloc_irq_vectors Christoph Hellwig
2016-09-06 16:39   ` Tejun Heo
2016-10-20 15:47     ` Robert Richter
2016-10-20 15:47       ` Robert Richter
2016-10-21 12:59       ` Christoph Hellwig
2016-10-21 12:59         ` Christoph Hellwig
2016-10-21 14:01         ` Robert Richter
2016-10-21 14:01           ` Robert Richter
2016-10-22 14:11           ` Christoph Hellwig
2016-10-22 14:11             ` Christoph Hellwig
2016-10-24 18:57             ` David Daney [this message]
2016-10-24 18:57               ` David Daney
2016-10-24 19:21               ` Christoph Hellwig
2016-10-24 19:21                 ` Christoph Hellwig
2016-10-24 20:29             ` David Daney
2016-10-24 20:29               ` David Daney
2016-10-25  9:25             ` Robert Richter
2016-10-25  9:25               ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=580E59AA.60107@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=dan.j.williamps@intel.com \
    --cc=eric.auger@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=robert.richter@cavium.com \
    --cc=rric@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.