From: Arnd Bergmann <arnd@arndb.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
oliver@schinagl.nl,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: MTD EEPROM support and driver integration
Date: Sat, 06 Jul 2013 11:18 +0200 [thread overview]
Message-ID: <5811519.oHVuMujf0I@wuerfel> (raw)
In-Reply-To: <20130706082804.GZ2959@lukather>
On Saturday 06 July 2013 10:28:04 Maxime Ripard wrote:
> > a) like interrupts, regs, dmas, clocks, pinctrl, reset, pwm: fixed property names
> >
> > regmap = <&at25 0xstart 0xlen>;
> > regmap-names = "mac-address";
> >
> > b) like gpio, regulator: variable property names
> >
> > mac-storage = <&at25 0xstart 0xlen>;
> >
> > It's unfortunate that we already have examples of both. They are largely
> > equivalent, but the tendency is towards the first.
>
> I don't have a strong feeling for one against another, so whatever works
> best. Both solutions will be a huge improvement anyway
>
> Just out of curiosity, is there any advantages besides having a fixed
> property name to the first solution?
I think it's mostly for consistency: trying to get most subsystems to
do it the same way to make it easier for people to write dts files.
A lesser point is that it simplifies the driver code if you don't
have to pass a name.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: MTD EEPROM support and driver integration
Date: Sat, 06 Jul 2013 11:18 +0200 [thread overview]
Message-ID: <5811519.oHVuMujf0I@wuerfel> (raw)
In-Reply-To: <20130706082804.GZ2959@lukather>
On Saturday 06 July 2013 10:28:04 Maxime Ripard wrote:
> > a) like interrupts, regs, dmas, clocks, pinctrl, reset, pwm: fixed property names
> >
> > regmap = <&at25 0xstart 0xlen>;
> > regmap-names = "mac-address";
> >
> > b) like gpio, regulator: variable property names
> >
> > mac-storage = <&at25 0xstart 0xlen>;
> >
> > It's unfortunate that we already have examples of both. They are largely
> > equivalent, but the tendency is towards the first.
>
> I don't have a strong feeling for one against another, so whatever works
> best. Both solutions will be a huge improvement anyway
>
> Just out of curiosity, is there any advantages besides having a fixed
> property name to the first solution?
I think it's mostly for consistency: trying to get most subsystems to
do it the same way to make it easier for people to write dts files.
A lesser point is that it simplifies the driver code if you don't
have to pass a name.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, oliver@schinagl.nl,
linux-mtd@lists.infradead.org
Subject: Re: MTD EEPROM support and driver integration
Date: Sat, 06 Jul 2013 11:18 +0200 [thread overview]
Message-ID: <5811519.oHVuMujf0I@wuerfel> (raw)
In-Reply-To: <20130706082804.GZ2959@lukather>
On Saturday 06 July 2013 10:28:04 Maxime Ripard wrote:
> > a) like interrupts, regs, dmas, clocks, pinctrl, reset, pwm: fixed property names
> >
> > regmap = <&at25 0xstart 0xlen>;
> > regmap-names = "mac-address";
> >
> > b) like gpio, regulator: variable property names
> >
> > mac-storage = <&at25 0xstart 0xlen>;
> >
> > It's unfortunate that we already have examples of both. They are largely
> > equivalent, but the tendency is towards the first.
>
> I don't have a strong feeling for one against another, so whatever works
> best. Both solutions will be a huge improvement anyway
>
> Just out of curiosity, is there any advantages besides having a fixed
> property name to the first solution?
I think it's mostly for consistency: trying to get most subsystems to
do it the same way to make it easier for people to write dts files.
A lesser point is that it simplifies the driver code if you don't
have to pass a name.
Arnd
next prev parent reply other threads:[~2013-07-06 9:18 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 20:11 MTD EEPROM support and driver integration Maxime Ripard
2013-07-05 20:11 ` Maxime Ripard
2013-07-05 20:11 ` Maxime Ripard
2013-07-05 21:02 ` Arnd Bergmann
2013-07-05 21:02 ` Arnd Bergmann
2013-07-05 21:02 ` Arnd Bergmann
2013-07-05 22:23 ` Maxime Ripard
2013-07-05 22:23 ` Maxime Ripard
2013-07-05 22:23 ` Maxime Ripard
2013-07-05 22:33 ` Arnd Bergmann
2013-07-05 22:33 ` Arnd Bergmann
2013-07-05 22:33 ` Arnd Bergmann
2013-07-06 8:28 ` Maxime Ripard
2013-07-06 8:28 ` Maxime Ripard
2013-07-06 8:28 ` Maxime Ripard
2013-07-06 9:18 ` Arnd Bergmann [this message]
2013-07-06 9:18 ` Arnd Bergmann
2013-07-06 9:18 ` Arnd Bergmann
2013-07-06 11:43 ` Maxime Ripard
2013-07-06 11:43 ` Maxime Ripard
2013-07-06 11:43 ` Maxime Ripard
2013-07-06 12:01 ` Maxime Ripard
2013-07-06 12:01 ` Maxime Ripard
2013-07-06 12:01 ` Maxime Ripard
2013-07-06 19:06 ` Arnd Bergmann
2013-07-06 19:06 ` Arnd Bergmann
2013-07-06 19:06 ` Arnd Bergmann
2013-07-06 19:06 ` Arnd Bergmann
2013-07-06 19:55 ` Jean Delvare
2013-07-06 19:55 ` Jean Delvare
2013-07-06 19:55 ` Jean Delvare
2013-07-06 19:55 ` Jean Delvare
2013-07-07 7:15 ` Maxime Ripard
2013-07-07 7:15 ` Maxime Ripard
2013-07-07 7:15 ` Maxime Ripard
2013-07-07 7:15 ` Maxime Ripard
2013-07-08 8:36 ` Mark Brown
2013-07-08 8:36 ` Mark Brown
2013-07-08 8:36 ` Mark Brown
2013-07-08 8:36 ` Mark Brown
[not found] ` <20130708083614.GP27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-08 21:04 ` Maxime Ripard
2013-07-08 21:04 ` Maxime Ripard
2013-07-08 21:04 ` Maxime Ripard
2013-07-08 21:04 ` Maxime Ripard
2013-07-08 8:34 ` Mark Brown
2013-07-08 8:34 ` Mark Brown
2013-07-08 8:34 ` Mark Brown
2013-07-08 8:34 ` Mark Brown
[not found] ` <20130708083426.GO27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-08 20:25 ` Maxime Ripard
2013-07-08 20:25 ` Maxime Ripard
2013-07-08 20:25 ` Maxime Ripard
2013-07-08 20:25 ` Maxime Ripard
2013-07-09 14:55 ` Mark Brown
2013-07-09 14:55 ` Mark Brown
2013-07-09 14:55 ` Mark Brown
2013-07-09 14:55 ` Mark Brown
[not found] ` <20130709145510.GZ27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-11 17:05 ` Maxime Ripard
2013-07-11 17:05 ` Maxime Ripard
2013-07-11 17:05 ` Maxime Ripard
2013-07-11 17:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5811519.oHVuMujf0I@wuerfel \
--to=arnd@arndb.de \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=oliver@schinagl.nl \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.