From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Pantelis Antoniou
<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
Pantelis Antoniou
<panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable
Date: Thu, 27 Oct 2016 09:36:53 -0700 [thread overview]
Message-ID: <58122D25.5030809@gmail.com> (raw)
In-Reply-To: <CAL_JsqKX4nahQ4o1FtPLfqqbYM2-pm9QbsobaaRzo8z7arJEjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/27/16 05:03, Rob Herring wrote:
> On Tue, Oct 25, 2016 at 4:02 PM, Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 10/25/16 13:58, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>>> From: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
>>>
>>> drivers/of/resolve.c is a bit difficult to read. Clean it up so
>>> that review of future overlay related patches will be easier.
>>
>> < snip >
>>
>> Hi Pantelis,
>>
>> Can you test this patch series on some real hardware?
>
> Did you run unit tests?
Yes.
But I will be much happier after Pantelis runs tests on real
hardware (which he agrees to do in another reply).
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable
Date: Thu, 27 Oct 2016 09:36:53 -0700 [thread overview]
Message-ID: <58122D25.5030809@gmail.com> (raw)
In-Reply-To: <CAL_JsqKX4nahQ4o1FtPLfqqbYM2-pm9QbsobaaRzo8z7arJEjQ@mail.gmail.com>
On 10/27/16 05:03, Rob Herring wrote:
> On Tue, Oct 25, 2016 at 4:02 PM, Frank Rowand <frowand.list@gmail.com> wrote:
>> On 10/25/16 13:58, frowand.list@gmail.com wrote:
>>> From: Frank Rowand <frank.rowand@am.sony.com>
>>>
>>> drivers/of/resolve.c is a bit difficult to read. Clean it up so
>>> that review of future overlay related patches will be easier.
>>
>> < snip >
>>
>> Hi Pantelis,
>>
>> Can you test this patch series on some real hardware?
>
> Did you run unit tests?
Yes.
But I will be much happier after Pantelis runs tests on real
hardware (which he agrees to do in another reply).
next prev parent reply other threads:[~2016-10-27 16:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 20:58 [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2016-10-25 20:58 ` frowand.list
2016-10-25 20:58 ` [RFC PATCH 01/13] of: Remove comments that state the obvious frowand.list
[not found] ` <1477429146-27039-2-git-send-email-frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-25 21:29 ` Joe Perches
2016-10-25 21:29 ` Joe Perches
2016-10-27 12:18 ` Rob Herring
[not found] ` <CAL_JsqL1aPq3rJLngvpQav-4-AKBd+u=+GX5NNpP9Kbc4zehpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-27 16:02 ` Frank Rowand
2016-10-27 16:02 ` Frank Rowand
2016-10-25 20:58 ` [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter frowand.list
2016-10-27 12:21 ` Rob Herring
2016-10-27 13:51 ` Pantelis Antoniou
2016-10-27 16:09 ` Frank Rowand
2016-10-27 16:04 ` Frank Rowand
2016-10-25 20:58 ` [RFC PATCH 03/13] of: Remove braces around single line blocks frowand.list
2016-10-25 20:58 ` [RFC PATCH 05/13] of: Rename functions to more accurately reflect what they do frowand.list
2016-10-25 20:58 ` [RFC PATCH 06/13] of: Remove prefix "__of_" and prefix "__" from local function names frowand.list
2016-10-27 12:47 ` Rob Herring
[not found] ` <CAL_JsqL9KWw7Mkz8nwZWDot+3OPBC2AesYuvu3dEofiB7BGeGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-27 16:35 ` Frank Rowand
2016-10-27 16:35 ` Frank Rowand
[not found] ` <58122CC0.3090700-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-27 16:58 ` Rob Herring
2016-10-27 16:58 ` Rob Herring
2016-10-27 18:25 ` Frank Rowand
2016-10-27 20:20 ` Rob Herring
2016-10-25 20:59 ` [RFC PATCH 09/13] of: Remove redundant size check frowand.list
2016-10-25 20:59 ` [RFC PATCH 10/13] of: Update comments to reflect changes and increase clarity frowand.list
2016-10-25 20:59 ` [RFC PATCH 11/13] of: Add back an error message, restructured frowand.list
2016-10-25 20:59 ` [RFC PATCH 12/13] of: Move setting of pointer to beside test for non-null frowand.list
[not found] ` <1477429146-27039-1-git-send-email-frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-25 20:58 ` [RFC PATCH 04/13] of: Convert comparisons to zero or NULL to simplify logical expressions frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2016-10-25 20:58 ` frowand.list
2016-10-25 20:59 ` [RFC PATCH 07/13] of: Rename variables to better reflect purpose or follow convention frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2016-10-25 20:59 ` frowand.list
2016-10-25 20:59 ` [RFC PATCH 08/13] of: Update structure of code, remove BUG_ON() frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2016-10-25 20:59 ` frowand.list
2016-10-25 20:59 ` [RFC PATCH 13/13] of: Remove unused variable overlay_symbols frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2016-10-25 20:59 ` frowand.list
2016-10-27 14:41 ` Pantelis Antoniou
2016-10-27 16:27 ` Frank Rowand
[not found] ` <58122AF9.3040709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-27 16:53 ` Frank Rowand
2016-10-27 16:53 ` Frank Rowand
[not found] ` <58123122.8020908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-27 16:57 ` Frank Rowand
2016-10-27 16:57 ` Frank Rowand
2016-10-25 21:02 ` [RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable Frank Rowand
2016-10-25 21:02 ` Frank Rowand
2016-10-27 12:03 ` Rob Herring
[not found] ` <CAL_JsqKX4nahQ4o1FtPLfqqbYM2-pm9QbsobaaRzo8z7arJEjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-27 16:36 ` Frank Rowand [this message]
2016-10-27 16:36 ` Frank Rowand
2016-10-27 13:46 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58122D25.5030809@gmail.com \
--to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.