From: zhong jiang <zhongjiang@huawei.com>
To: nyc@holomorphy.com, n-horiguchi@ah.jp.nec.com,
mike.kravetz@oracle.com, rientjes@google.com,
hillf.zj@alibaba-inc.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH] hugetlbfs: fix the hugetlbfs can not be mounted
Date: Sat, 29 Oct 2016 15:38:15 +0800 [thread overview]
Message-ID: <581451E7.1040004@huawei.com> (raw)
In-Reply-To: <1477721311-54522-1-git-send-email-zhongjiang@huawei.com>
On 2016/10/29 14:08, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> Since 'commit 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly non-modular")'
> bring in the mainline. mount hugetlbfs will result in the following issue.
>
> mount: unknown filesystme type 'hugetlbfs'
>
> because previous patch remove the module_alias_fs, when we mount the fs type,
> the caller get_fs_type can not find the filesystem.
>
> The patch just recover the module_alias_fs to identify the hugetlbfs.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/hugetlbfs/inode.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 4fb7b10..b63e7de 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -35,6 +35,7 @@
> #include <linux/security.h>
> #include <linux/magic.h>
> #include <linux/migrate.h>
> +#include <linux/module.h>
> #include <linux/uio.h>
>
> #include <asm/uaccess.h>
> @@ -1209,6 +1210,7 @@ static struct dentry *hugetlbfs_mount(struct file_system_type *fs_type,
> .mount = hugetlbfs_mount,
> .kill_sb = kill_litter_super,
> };
> +MODULE_ALIAS_FS("hugetlbfs");
>
> static struct vfsmount *hugetlbfs_vfsmount[HUGE_MAX_HSTATE];
>
please ignore the patch, It have been fixed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: <nyc@holomorphy.com>, <n-horiguchi@ah.jp.nec.com>,
<mike.kravetz@oracle.com>, <rientjes@google.com>,
<hillf.zj@alibaba-inc.com>, <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH] hugetlbfs: fix the hugetlbfs can not be mounted
Date: Sat, 29 Oct 2016 15:38:15 +0800 [thread overview]
Message-ID: <581451E7.1040004@huawei.com> (raw)
In-Reply-To: <1477721311-54522-1-git-send-email-zhongjiang@huawei.com>
On 2016/10/29 14:08, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> Since 'commit 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly non-modular")'
> bring in the mainline. mount hugetlbfs will result in the following issue.
>
> mount: unknown filesystme type 'hugetlbfs'
>
> because previous patch remove the module_alias_fs, when we mount the fs type,
> the caller get_fs_type can not find the filesystem.
>
> The patch just recover the module_alias_fs to identify the hugetlbfs.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/hugetlbfs/inode.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 4fb7b10..b63e7de 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -35,6 +35,7 @@
> #include <linux/security.h>
> #include <linux/magic.h>
> #include <linux/migrate.h>
> +#include <linux/module.h>
> #include <linux/uio.h>
>
> #include <asm/uaccess.h>
> @@ -1209,6 +1210,7 @@ static struct dentry *hugetlbfs_mount(struct file_system_type *fs_type,
> .mount = hugetlbfs_mount,
> .kill_sb = kill_litter_super,
> };
> +MODULE_ALIAS_FS("hugetlbfs");
>
> static struct vfsmount *hugetlbfs_vfsmount[HUGE_MAX_HSTATE];
>
please ignore the patch, It have been fixed.
next prev parent reply other threads:[~2016-10-29 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 6:08 [RFC PATCH] hugetlbfs: fix the hugetlbfs can not be mounted zhongjiang
2016-10-29 6:08 ` zhongjiang
2016-10-29 7:38 ` zhong jiang [this message]
2016-10-29 7:38 ` zhong jiang
2016-11-03 19:17 ` Andrew Morton
2016-11-03 19:17 ` Andrew Morton
2016-11-03 20:54 ` Paul Gortmaker
2016-11-03 20:54 ` Paul Gortmaker
2016-11-04 2:22 ` zhong jiang
2016-11-04 2:22 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581451E7.1040004@huawei.com \
--to=zhongjiang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nyc@holomorphy.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.