From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, zefir.kurtisi@neratec.com,
scampbel@codeaurora.org, alokc@codeaurora.org,
shankerd@codeaurora.org, andrew@lunn.ch
Subject: Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames
Date: Mon, 31 Oct 2016 16:14:26 -0500 [thread overview]
Message-ID: <5817B432.7070304@codeaurora.org> (raw)
In-Reply-To: <39bda1bc-255b-64d0-3e7a-d3a6f00786c3@gmail.com>
Florian Fainelli wrote:
>>pause asym_pause enable tx? enable rx?
>>----- ---------- ---------- ----------
>> 0 0 No No
>> 0 1 Yes No
>> 1 0 Yes Yes
>> 1 1 No Yes
>>
>>The last two seem backwards. The internal driver enables RX and TX if
>>pause and asym_pause is enabled.
Is this chart correct? I see drivers handle this differently.
nb8800_pause_config() has this:
priv->pause_rx = phydev->pause;
priv->pause_tx = phydev->pause ^ phydev->asym_pause;
But bcm_sf2_sw_adjust_link() does this:
if (phydev->pause) {
if (phydev->asym_pause)
reg |= TX_PAUSE_EN;
reg |= RX_PAUSE_EN;
}
Which one is correct?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-10-31 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 22:05 [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames Timur Tabi
2016-10-27 22:12 ` Florian Fainelli
2016-10-27 22:24 ` Timur Tabi
2016-10-27 22:39 ` Florian Fainelli
2016-10-28 20:06 ` Timur Tabi
2016-10-28 21:03 ` Florian Fainelli
2016-10-31 17:23 ` Timur Tabi
2016-10-31 17:55 ` Florian Fainelli
2016-10-31 21:14 ` Timur Tabi [this message]
2016-10-31 17:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5817B432.7070304@codeaurora.org \
--to=timur@codeaurora.org \
--cc=alokc@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=scampbel@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.