From: Chen Feng <puck.chen@hisilicon.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org, mhocko@suse.com,
vbabka@suse.cz, hannes@cmpxchg.org,
kirill.shutemov@linux.intel.com, mgorman@techsingularity.net,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, oliver.fu@hisilicon.com,
suzhuangluan@hisilicon.com, qijiwen@hisilicon.com,
xuyiping@hisilicon.com, puck.chen@foxmail.com
Subject: Re: [PATCH] mm: cma: improve utilization of cma pages
Date: Thu, 3 Nov 2016 18:40:28 +0800 [thread overview]
Message-ID: <581B141C.4080707@hisilicon.com> (raw)
In-Reply-To: <201611031703.8WVh4Fcm%fengguang.wu@intel.com>
Sorry for this. Only test on arm64.
Should be this:
+#if IS_ENABLED(CONFIG_CMA)
+ if (gfp_flags & __GFP_MOVABLE)
+ return MIGRATE_CMA;
+#endif
On 2016/11/3 17:54, kbuild test robot wrote:
> Hi Chen,
>
> [auto build test ERROR on mmotm/master]
> [also build test ERROR on v4.9-rc3 next-20161028]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Chen-Feng/mm-cma-improve-utilization-of-cma-pages/20161103-173624
> base: git://git.cmpxchg.org/linux-mmotm.git master
> config: x86_64-randconfig-x011-201644 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/slab.h:14:0,
> from include/linux/crypto.h:24,
> from arch/x86/kernel/asm-offsets.c:8:
> include/linux/gfp.h: In function 'gfpflags_to_migratetype':
>>> include/linux/gfp.h:274:10: error: 'MIGRATE_CMA' undeclared (first use in this function)
> return MIGRATE_CMA;
> ^~~~~~~~~~~
> include/linux/gfp.h:274:10: note: each undeclared identifier is reported only once for each function it appears in
> make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [sub-make] Error 2
>
> vim +/MIGRATE_CMA +274 include/linux/gfp.h
>
> 268 {
> 269 VM_WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK);
> 270 BUILD_BUG_ON((1UL << GFP_MOVABLE_SHIFT) != ___GFP_MOVABLE);
> 271 BUILD_BUG_ON((___GFP_MOVABLE >> GFP_MOVABLE_SHIFT) != MIGRATE_MOVABLE);
> 272
> 273 if (IS_ENABLED(CONFIG_CMA) && gfp_flags & __GFP_MOVABLE)
> > 274 return MIGRATE_CMA;
> 275
> 276 if (unlikely(page_group_by_mobility_disabled))
> 277 return MIGRATE_UNMOVABLE;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Chen Feng <puck.chen@hisilicon.com>
To: kbuild test robot <lkp@intel.com>
Cc: <kbuild-all@01.org>, <akpm@linux-foundation.org>,
<mhocko@suse.com>, <vbabka@suse.cz>, <hannes@cmpxchg.org>,
<kirill.shutemov@linux.intel.com>, <mgorman@techsingularity.net>,
<iamjoonsoo.kim@lge.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <oliver.fu@hisilicon.com>,
<suzhuangluan@hisilicon.com>, <qijiwen@hisilicon.com>,
<xuyiping@hisilicon.com>, <puck.chen@foxmail.com>
Subject: Re: [PATCH] mm: cma: improve utilization of cma pages
Date: Thu, 3 Nov 2016 18:40:28 +0800 [thread overview]
Message-ID: <581B141C.4080707@hisilicon.com> (raw)
In-Reply-To: <201611031703.8WVh4Fcm%fengguang.wu@intel.com>
Sorry for this. Only test on arm64.
Should be this:
+#if IS_ENABLED(CONFIG_CMA)
+ if (gfp_flags & __GFP_MOVABLE)
+ return MIGRATE_CMA;
+#endif
On 2016/11/3 17:54, kbuild test robot wrote:
> Hi Chen,
>
> [auto build test ERROR on mmotm/master]
> [also build test ERROR on v4.9-rc3 next-20161028]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Chen-Feng/mm-cma-improve-utilization-of-cma-pages/20161103-173624
> base: git://git.cmpxchg.org/linux-mmotm.git master
> config: x86_64-randconfig-x011-201644 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/slab.h:14:0,
> from include/linux/crypto.h:24,
> from arch/x86/kernel/asm-offsets.c:8:
> include/linux/gfp.h: In function 'gfpflags_to_migratetype':
>>> include/linux/gfp.h:274:10: error: 'MIGRATE_CMA' undeclared (first use in this function)
> return MIGRATE_CMA;
> ^~~~~~~~~~~
> include/linux/gfp.h:274:10: note: each undeclared identifier is reported only once for each function it appears in
> make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [sub-make] Error 2
>
> vim +/MIGRATE_CMA +274 include/linux/gfp.h
>
> 268 {
> 269 VM_WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK);
> 270 BUILD_BUG_ON((1UL << GFP_MOVABLE_SHIFT) != ___GFP_MOVABLE);
> 271 BUILD_BUG_ON((___GFP_MOVABLE >> GFP_MOVABLE_SHIFT) != MIGRATE_MOVABLE);
> 272
> 273 if (IS_ENABLED(CONFIG_CMA) && gfp_flags & __GFP_MOVABLE)
> > 274 return MIGRATE_CMA;
> 275
> 276 if (unlikely(page_group_by_mobility_disabled))
> 277 return MIGRATE_UNMOVABLE;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next prev parent reply other threads:[~2016-11-03 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 8:58 [PATCH] mm: cma: improve utilization of cma pages Chen Feng
2016-11-03 8:58 ` Chen Feng
2016-11-03 9:54 ` kbuild test robot
2016-11-03 9:54 ` kbuild test robot
2016-11-03 10:40 ` Chen Feng [this message]
2016-11-03 10:40 ` Chen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581B141C.4080707@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kbuild-all@01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=oliver.fu@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=qijiwen@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=vbabka@suse.cz \
--cc=xuyiping@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.