[PATCH] of: base: Export symbol of __of_find_all_nodes()

[PATCH] of: base: Export symbol of __of_find_all_nodes()

[Laxman Dewangan]

The function __of_find_all_nodes() is used in the public header
linux/of.h and if any driver developed using this API then
it reports error as unknown symbol if compiled as module.

Export this APIs using EXPORT_SYMBOL() so that it can be used
from driver compiled as module.

Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index d687e6d..89c2083 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -269,6 +269,7 @@ struct device_node *__of_find_all_nodes(struct device_node *prev)
 	}
 	return np;
 }
+EXPORT_SYMBOL(__of_find_all_nodes);
 
 /**
  * of_find_all_nodes - Get next node in global list
-- 
2.1.4


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: Export symbol of __of_find_all_nodes()

[Rob Herring]

On Fri, Oct 28, 2016 at 6:28 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> The function __of_find_all_nodes() is used in the public header
> linux/of.h and if any driver developed using this API then
> it reports error as unknown symbol if compiled as module.
>
> Export this APIs using EXPORT_SYMBOL() so that it can be used
> from driver compiled as module.

What driver needs this? This isn't really a function I'd expect drivers to use.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: Export symbol of __of_find_all_nodes()

[Laxman Dewangan]

On Thursday 03 November 2016 09:09 AM, Rob Herring wrote:
> On Fri, Oct 28, 2016 at 6:28 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>> The function __of_find_all_nodes() is used in the public header
>> linux/of.h and if any driver developed using this API then
>> it reports error as unknown symbol if compiled as module.
>>
>> Export this APIs using EXPORT_SYMBOL() so that it can be used
>> from driver compiled as module.
> What driver needs this? This isn't really a function I'd expect drivers to use.
>

I am using the for loop for each node using the macro 
for_each_of_allnodes_from() which is define as

#define for_each_of_allnodes_from(from, dn) \
         for (dn = __of_find_all_nodes(from); dn; dn = 
__of_find_all_nodes(dn))

and this is using the above APIs.


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: Export symbol of __of_find_all_nodes()

[Rob Herring]

On Thu, Nov 3, 2016 at 12:24 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>
> On Thursday 03 November 2016 09:09 AM, Rob Herring wrote:
>>
>> On Fri, Oct 28, 2016 at 6:28 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> wrote:
>>>
>>> The function __of_find_all_nodes() is used in the public header
>>> linux/of.h and if any driver developed using this API then
>>> it reports error as unknown symbol if compiled as module.
>>>
>>> Export this APIs using EXPORT_SYMBOL() so that it can be used
>>> from driver compiled as module.
>>
>> What driver needs this? This isn't really a function I'd expect drivers to
>> use.
>>
>
> I am using the for loop for each node using the macro
> for_each_of_allnodes_from() which is define as
>
> #define for_each_of_allnodes_from(from, dn) \
>         for (dn = __of_find_all_nodes(from); dn; dn =
> __of_find_all_nodes(dn))
>
> and this is using the above APIs.

And then what driver is using this define?

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: Export symbol of __of_find_all_nodes()

[Laxman Dewangan]

On Thursday 03 November 2016 07:46 PM, Rob Herring wrote:
> On Thu, Nov 3, 2016 at 12:24 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>> On Thursday 03 November 2016 09:09 AM, Rob Herring wrote:
>>> On Fri, Oct 28, 2016 at 6:28 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>> wrote:
>>>> The function __of_find_all_nodes() is used in the public header
>>>> linux/of.h and if any driver developed using this API then
>>>> it reports error as unknown symbol if compiled as module.
>>>>
>>>> Export this APIs using EXPORT_SYMBOL() so that it can be used
>>>> from driver compiled as module.
>>> What driver needs this? This isn't really a function I'd expect drivers to
>>> use.
>>>
>> I am using the for loop for each node using the macro
>> for_each_of_allnodes_from() which is define as
>>
>> #define for_each_of_allnodes_from(from, dn) \
>>          for (dn = __of_find_all_nodes(from); dn; dn =
>> __of_find_all_nodes(dn))
>>
>> and this is using the above APIs.
> And then what driver is using this define?
We are developing the utils/testcase on OF interface echo system. In one 
of the testcase, we want to limit the node and property name length to 
32 (max) as per ePAPR specs. This is needed to reuse the DT in multi-OS 
environment and so want to maintain ePAPR compliance here.

We are using the above macro for iterating over each node.



-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: base: Export symbol of __of_find_all_nodes()

[Laxman Dewangan]

On Friday 04 November 2016 11:02 AM, Laxman Dewangan wrote:
>
> On Thursday 03 November 2016 07:46 PM, Rob Herring wrote:
>> On Thu, Nov 3, 2016 at 12:24 AM, Laxman Dewangan 
>> <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>>> On Thursday 03 November 2016 09:09 AM, Rob Herring wrote:
>>>> On Fri, Oct 28, 2016 at 6:28 AM, Laxman Dewangan 
>>>> <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>>> wrote:
>>>>> The function __of_find_all_nodes() is used in the public header
>>>>> linux/of.h and if any driver developed using this API then
>>>>> it reports error as unknown symbol if compiled as module.
>>>>>
>>>>> Export this APIs using EXPORT_SYMBOL() so that it can be used
>>>>> from driver compiled as module.
>>>> What driver needs this? This isn't really a function I'd expect 
>>>> drivers to
>>>> use.
>>>>
>>> I am using the for loop for each node using the macro
>>> for_each_of_allnodes_from() which is define as
>>>
>>> #define for_each_of_allnodes_from(from, dn) \
>>>          for (dn = __of_find_all_nodes(from); dn; dn =
>>> __of_find_all_nodes(dn))
>>>
>>> and this is using the above APIs.
>> And then what driver is using this define?
> We are developing the utils/testcase on OF interface echo system. In 
> one of the testcase, we want to limit the node and property name 
> length to 32 (max) as per ePAPR specs. This is needed to reuse the DT 
> in multi-OS environment and so want to maintain ePAPR compliance here.
>
> We are using the above macro for iterating over each node.
>
>
Hi Rob,
Any comment or suggestion?

Thanks,
Laxman



-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html