* [Qemu-trivial] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
@ 2016-11-07 3:48 ` Changlong Xie
0 siblings, 0 replies; 6+ messages in thread
From: Changlong Xie @ 2016-11-07 3:48 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival
Cc: Wen Congyang, zhanghailiang
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
docs/block-replication.txt | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/docs/block-replication.txt b/docs/block-replication.txt
index 6bde673..6b9c77b 100644
--- a/docs/block-replication.txt
+++ b/docs/block-replication.txt
@@ -152,9 +152,22 @@ Primary:
children.0.driver=raw
Run qmp command in primary qemu:
- { 'execute': 'human-monitor-command',
+ { 'execute': 'blockdev-add',
'arguments': {
- 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
+ 'driver': 'replication',
+ 'node-name': 'nbd_client1',
+ 'mode': 'primary',
+ 'file': {
+ 'driver': 'nbd',
+ 'export': 'colo1',
+ 'server': {
+ 'type': 'inet',
+ 'data': {
+ 'host': 'xxxx',
+ 'port': 'xxxx'
+ }
+ }
+ }
}
}
{ 'execute': 'x-blockdev-change',
@@ -223,12 +236,11 @@ Primary:
'child': 'children.1'
}
}
- { 'execute': 'human-monitor-command',
+ { 'execute': 'x-blockdev-del',
'arguments': {
- 'command-line': 'drive_del xxxx'
+ 'node-name': 'nbd_client1'
}
}
- Note: there is no qmp command to remove the blockdev now
Secondary:
The primary host is down, so we should do the following thing:
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
@ 2016-11-07 3:48 ` Changlong Xie
0 siblings, 0 replies; 6+ messages in thread
From: Changlong Xie @ 2016-11-07 3:48 UTC (permalink / raw)
To: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival
Cc: Wen Congyang, zhanghailiang
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
docs/block-replication.txt | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/docs/block-replication.txt b/docs/block-replication.txt
index 6bde673..6b9c77b 100644
--- a/docs/block-replication.txt
+++ b/docs/block-replication.txt
@@ -152,9 +152,22 @@ Primary:
children.0.driver=raw
Run qmp command in primary qemu:
- { 'execute': 'human-monitor-command',
+ { 'execute': 'blockdev-add',
'arguments': {
- 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
+ 'driver': 'replication',
+ 'node-name': 'nbd_client1',
+ 'mode': 'primary',
+ 'file': {
+ 'driver': 'nbd',
+ 'export': 'colo1',
+ 'server': {
+ 'type': 'inet',
+ 'data': {
+ 'host': 'xxxx',
+ 'port': 'xxxx'
+ }
+ }
+ }
}
}
{ 'execute': 'x-blockdev-change',
@@ -223,12 +236,11 @@ Primary:
'child': 'children.1'
}
}
- { 'execute': 'human-monitor-command',
+ { 'execute': 'x-blockdev-del',
'arguments': {
- 'command-line': 'drive_del xxxx'
+ 'node-name': 'nbd_client1'
}
}
- Note: there is no qmp command to remove the blockdev now
Secondary:
The primary host is down, so we should do the following thing:
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
2016-11-07 3:48 ` [Qemu-devel] " Changlong Xie
@ 2016-11-07 7:50 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2016-11-07 7:50 UTC (permalink / raw)
To: Changlong Xie
Cc: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival,
zhanghailiang
Changlong Xie <xiecl.fnst@cn.fujitsu.com> writes:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> docs/block-replication.txt | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
> index 6bde673..6b9c77b 100644
> --- a/docs/block-replication.txt
> +++ b/docs/block-replication.txt
> @@ -152,9 +152,22 @@ Primary:
> children.0.driver=raw
>
> Run qmp command in primary qemu:
> - { 'execute': 'human-monitor-command',
> + { 'execute': 'blockdev-add',
> 'arguments': {
> - 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
> + 'driver': 'replication',
> + 'node-name': 'nbd_client1',
> + 'mode': 'primary',
> + 'file': {
> + 'driver': 'nbd',
> + 'export': 'colo1',
> + 'server': {
> + 'type': 'inet',
> + 'data': {
> + 'host': 'xxxx',
> + 'port': 'xxxx'
> + }
> + }
> + }
> }
> }
> { 'execute': 'x-blockdev-change',
> @@ -223,12 +236,11 @@ Primary:
> 'child': 'children.1'
> }
> }
> - { 'execute': 'human-monitor-command',
> + { 'execute': 'x-blockdev-del',
> 'arguments': {
> - 'command-line': 'drive_del xxxx'
> + 'node-name': 'nbd_client1'
> }
> }
> - Note: there is no qmp command to remove the blockdev now
>
> Secondary:
> The primary host is down, so we should do the following thing:
This is premature: both blockdev-add and x-blockdev-del still aren't
ready for production. Getting close, though.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
@ 2016-11-07 7:50 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2016-11-07 7:50 UTC (permalink / raw)
To: Changlong Xie
Cc: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival,
zhanghailiang
Changlong Xie <xiecl.fnst@cn.fujitsu.com> writes:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> docs/block-replication.txt | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
> index 6bde673..6b9c77b 100644
> --- a/docs/block-replication.txt
> +++ b/docs/block-replication.txt
> @@ -152,9 +152,22 @@ Primary:
> children.0.driver=raw
>
> Run qmp command in primary qemu:
> - { 'execute': 'human-monitor-command',
> + { 'execute': 'blockdev-add',
> 'arguments': {
> - 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
> + 'driver': 'replication',
> + 'node-name': 'nbd_client1',
> + 'mode': 'primary',
> + 'file': {
> + 'driver': 'nbd',
> + 'export': 'colo1',
> + 'server': {
> + 'type': 'inet',
> + 'data': {
> + 'host': 'xxxx',
> + 'port': 'xxxx'
> + }
> + }
> + }
> }
> }
> { 'execute': 'x-blockdev-change',
> @@ -223,12 +236,11 @@ Primary:
> 'child': 'children.1'
> }
> }
> - { 'execute': 'human-monitor-command',
> + { 'execute': 'x-blockdev-del',
> 'arguments': {
> - 'command-line': 'drive_del xxxx'
> + 'node-name': 'nbd_client1'
> }
> }
> - Note: there is no qmp command to remove the blockdev now
>
> Secondary:
> The primary host is down, so we should do the following thing:
This is premature: both blockdev-add and x-blockdev-del still aren't
ready for production. Getting close, though.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
2016-11-07 7:50 ` Markus Armbruster
@ 2016-11-07 8:07 ` Changlong Xie
-1 siblings, 0 replies; 6+ messages in thread
From: Changlong Xie @ 2016-11-07 8:07 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival,
zhanghailiang
On 11/07/2016 03:50 PM, Markus Armbruster wrote:
> Changlong Xie <xiecl.fnst@cn.fujitsu.com> writes:
>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>> docs/block-replication.txt | 22 +++++++++++++++++-----
>> 1 file changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
>> index 6bde673..6b9c77b 100644
>> --- a/docs/block-replication.txt
>> +++ b/docs/block-replication.txt
>> @@ -152,9 +152,22 @@ Primary:
>> children.0.driver=raw
>>
>> Run qmp command in primary qemu:
>> - { 'execute': 'human-monitor-command',
>> + { 'execute': 'blockdev-add',
>> 'arguments': {
>> - 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
>> + 'driver': 'replication',
>> + 'node-name': 'nbd_client1',
>> + 'mode': 'primary',
>> + 'file': {
>> + 'driver': 'nbd',
>> + 'export': 'colo1',
>> + 'server': {
>> + 'type': 'inet',
>> + 'data': {
>> + 'host': 'xxxx',
>> + 'port': 'xxxx'
>> + }
>> + }
>> + }
>> }
>> }
>> { 'execute': 'x-blockdev-change',
>> @@ -223,12 +236,11 @@ Primary:
>> 'child': 'children.1'
>> }
>> }
>> - { 'execute': 'human-monitor-command',
>> + { 'execute': 'x-blockdev-del',
>> 'arguments': {
>> - 'command-line': 'drive_del xxxx'
>> + 'node-name': 'nbd_client1'
>> }
>> }
>> - Note: there is no qmp command to remove the blockdev now
>>
>> Secondary:
>> The primary host is down, so we should do the following thing:
>
> This is premature: both blockdev-add and x-blockdev-del still aren't
> ready for production. Getting close, though.
Sound nice : ), so let this patch pending here.
Thanks
-Xie
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands
@ 2016-11-07 8:07 ` Changlong Xie
0 siblings, 0 replies; 6+ messages in thread
From: Changlong Xie @ 2016-11-07 8:07 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu devel, qemu block, Stefan Hajnoczi, Eric Blake, qemu trival,
zhanghailiang
On 11/07/2016 03:50 PM, Markus Armbruster wrote:
> Changlong Xie <xiecl.fnst@cn.fujitsu.com> writes:
>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>> docs/block-replication.txt | 22 +++++++++++++++++-----
>> 1 file changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
>> index 6bde673..6b9c77b 100644
>> --- a/docs/block-replication.txt
>> +++ b/docs/block-replication.txt
>> @@ -152,9 +152,22 @@ Primary:
>> children.0.driver=raw
>>
>> Run qmp command in primary qemu:
>> - { 'execute': 'human-monitor-command',
>> + { 'execute': 'blockdev-add',
>> 'arguments': {
>> - 'command-line': 'drive_add -n buddy driver=replication,mode=primary,file.driver=nbd,file.host=xxxx,file.port=xxxx,file.export=colo1,node-name=nbd_client1'
>> + 'driver': 'replication',
>> + 'node-name': 'nbd_client1',
>> + 'mode': 'primary',
>> + 'file': {
>> + 'driver': 'nbd',
>> + 'export': 'colo1',
>> + 'server': {
>> + 'type': 'inet',
>> + 'data': {
>> + 'host': 'xxxx',
>> + 'port': 'xxxx'
>> + }
>> + }
>> + }
>> }
>> }
>> { 'execute': 'x-blockdev-change',
>> @@ -223,12 +236,11 @@ Primary:
>> 'child': 'children.1'
>> }
>> }
>> - { 'execute': 'human-monitor-command',
>> + { 'execute': 'x-blockdev-del',
>> 'arguments': {
>> - 'command-line': 'drive_del xxxx'
>> + 'node-name': 'nbd_client1'
>> }
>> }
>> - Note: there is no qmp command to remove the blockdev now
>>
>> Secondary:
>> The primary host is down, so we should do the following thing:
>
> This is premature: both blockdev-add and x-blockdev-del still aren't
> ready for production. Getting close, though.
Sound nice : ), so let this patch pending here.
Thanks
-Xie
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-07 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 3:48 [Qemu-trivial] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands Changlong Xie
2016-11-07 3:48 ` [Qemu-devel] " Changlong Xie
2016-11-07 7:50 ` [Qemu-trivial] " Markus Armbruster
2016-11-07 7:50 ` Markus Armbruster
2016-11-07 8:07 ` [Qemu-trivial] " Changlong Xie
2016-11-07 8:07 ` Changlong Xie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.