* [PATCH] doc: add known issue on QAT PMD into release notes
@ 2016-11-10 16:46 Fiona Trahe
2016-11-10 16:52 ` Mcnamara, John
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fiona Trahe @ 2016-11-10 16:46 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, fiona.trahe, john.griffin
Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
doc/guides/rel_notes/release_16_11.rst | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 365b5a3..5f925b5 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -213,7 +213,18 @@ Known Issues
Therefore, in order to use L3fwd-power, vector mode should be disabled
from the config file.
-
+* **Digest address must be supplied for crypto auth operation on QAT PMD.**
+
+ The cryptodev API specifies that if the rte_crypto_sym_op.digest.data field,
+ and by inference the digest.phys_addr field which points to the same location,
+ is not set for an auth operation the driver is to understand that the digest
+ result is located immediately following the region over which the digest is
+ computed. The QAT PMD doesn't correctly handle this case and reads and writes
+ to an incorrect location.
+
+ Callers can workaround this by always supplying the digest virtual and
+ physical address fields in the rte_crypto_sym_op for an auth operation.
+
API Changes
-----------
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] doc: add known issue on QAT PMD into release notes
2016-11-10 16:46 [PATCH] doc: add known issue on QAT PMD into release notes Fiona Trahe
@ 2016-11-10 16:52 ` Mcnamara, John
2016-11-10 17:22 ` Trahe, Fiona
2016-11-10 17:27 ` [PATCH v2] " Fiona Trahe
2 siblings, 0 replies; 6+ messages in thread
From: Mcnamara, John @ 2016-11-10 16:52 UTC (permalink / raw)
To: Trahe, Fiona, dev@dpdk.org
Cc: De Lara Guarch, Pablo, Trahe, Fiona, Griffin, John
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Thursday, November 10, 2016 4:47 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release
> notes
>
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] doc: add known issue on QAT PMD into release notes
2016-11-10 16:46 [PATCH] doc: add known issue on QAT PMD into release notes Fiona Trahe
2016-11-10 16:52 ` Mcnamara, John
@ 2016-11-10 17:22 ` Trahe, Fiona
2016-11-10 17:27 ` [PATCH v2] " Fiona Trahe
2 siblings, 0 replies; 6+ messages in thread
From: Trahe, Fiona @ 2016-11-10 17:22 UTC (permalink / raw)
To: dev@dpdk.org; +Cc: De Lara Guarch, Pablo, Griffin, John, Trahe, Fiona
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, November 10, 2016 4:47 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Subject: [PATCH] doc: add known issue on QAT PMD into release notes
>
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Self-nack
Checkpatch white space errors - will send an update shortly
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] doc: add known issue on QAT PMD into release notes
2016-11-10 16:46 [PATCH] doc: add known issue on QAT PMD into release notes Fiona Trahe
2016-11-10 16:52 ` Mcnamara, John
2016-11-10 17:22 ` Trahe, Fiona
@ 2016-11-10 17:27 ` Fiona Trahe
2016-11-10 18:13 ` John Griffin
2 siblings, 1 reply; 6+ messages in thread
From: Fiona Trahe @ 2016-11-10 17:27 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, fiona.trahe, john.griffin
Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
v2
- fixed trailing whitespace checkpatch errors
doc/guides/rel_notes/release_16_11.rst | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 365b5a3..5f925b5 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -213,7 +213,18 @@ Known Issues
Therefore, in order to use L3fwd-power, vector mode should be disabled
from the config file.
-
+* **Digest address must be supplied for crypto auth operation on QAT PMD.**
+
+ The cryptodev API specifies that if the rte_crypto_sym_op.digest.data field,
+ and by inference the digest.phys_addr field which points to the same location,
+ is not set for an auth operation the driver is to understand that the digest
+ result is located immediately following the region over which the digest is
+ computed. The QAT PMD doesn't correctly handle this case and reads and writes
+ to an incorrect location.
+
+ Callers can workaround this by always supplying the digest virtual and
+ physical address fields in the rte_crypto_sym_op for an auth operation.
+
API Changes
-----------
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] doc: add known issue on QAT PMD into release notes
2016-11-10 17:27 ` [PATCH v2] " Fiona Trahe
@ 2016-11-10 18:13 ` John Griffin
2016-11-12 21:37 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: John Griffin @ 2016-11-10 18:13 UTC (permalink / raw)
To: Fiona Trahe, dev; +Cc: pablo.de.lara.guarch
On 10/11/16 17:27, Fiona Trahe wrote:
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
> v2
> - fixed trailing whitespace checkpatch errors
>
Acked-by: John Griffin <john.griffin@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] doc: add known issue on QAT PMD into release notes
2016-11-10 18:13 ` John Griffin
@ 2016-11-12 21:37 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-11-12 21:37 UTC (permalink / raw)
To: John Griffin; +Cc: dev, Fiona Trahe, pablo.de.lara.guarch
> > Issue is with the digest appended feature on QAT PMD.
> > A workaround is also documented.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> Acked-by: John Griffin <john.griffin@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-12 21:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 16:46 [PATCH] doc: add known issue on QAT PMD into release notes Fiona Trahe
2016-11-10 16:52 ` Mcnamara, John
2016-11-10 17:22 ` Trahe, Fiona
2016-11-10 17:27 ` [PATCH v2] " Fiona Trahe
2016-11-10 18:13 ` John Griffin
2016-11-12 21:37 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.