All of lore.kernel.org
 help / color / mirror / Atom feed
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/3] phy: meson8b-usb2: request a shared reset line
Date: Tue, 15 Nov 2016 18:24:46 +0530	[thread overview]
Message-ID: <582B0596.4060903@ti.com> (raw)
In-Reply-To: <20161112131305.26088-3-martin.blumenstingl@googlemail.com>



On Saturday 12 November 2016 06:43 PM, Martin Blumenstingl wrote:
> Both PHYs are sharing one reset line. With recent improvements to the
> reset framework we can now also use reset_control_reset with shared
> resets.
> This allows us to drop some workarounds where the reset was only
> specified for one PHY but not the other, to make sure that the reset it
> only executed once (as the reset framework was not able to use
> reset_control_reset with shared reset lines).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

merged $patch to -next.

Thanks
Kishon
> ---
>  drivers/phy/phy-meson8b-usb2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
> index 73bf632..f1ee96a 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -237,8 +237,7 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
>  	if (IS_ERR(priv->clk_usb))
>  		return PTR_ERR(priv->clk_usb);
>  
> -	priv->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
> -								NULL);
> +	priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
>  	if (PTR_ERR(priv->reset) == -EPROBE_DEFER)
>  		return PTR_ERR(priv->reset);
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: Martin Blumenstingl
	<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 2/3] phy: meson8b-usb2: request a shared reset line
Date: Tue, 15 Nov 2016 18:24:46 +0530	[thread overview]
Message-ID: <582B0596.4060903@ti.com> (raw)
In-Reply-To: <20161112131305.26088-3-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>



On Saturday 12 November 2016 06:43 PM, Martin Blumenstingl wrote:
> Both PHYs are sharing one reset line. With recent improvements to the
> reset framework we can now also use reset_control_reset with shared
> resets.
> This allows us to drop some workarounds where the reset was only
> specified for one PHY but not the other, to make sure that the reset it
> only executed once (as the reset framework was not able to use
> reset_control_reset with shared reset lines).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>

merged $patch to -next.

Thanks
Kishon
> ---
>  drivers/phy/phy-meson8b-usb2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
> index 73bf632..f1ee96a 100644
> --- a/drivers/phy/phy-meson8b-usb2.c
> +++ b/drivers/phy/phy-meson8b-usb2.c
> @@ -237,8 +237,7 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
>  	if (IS_ERR(priv->clk_usb))
>  		return PTR_ERR(priv->clk_usb);
>  
> -	priv->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
> -								NULL);
> +	priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
>  	if (PTR_ERR(priv->reset) == -EPROBE_DEFER)
>  		return PTR_ERR(priv->reset);
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-11-15 12:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-01 15:21 [PATCH 0/3] enable reset_control_reset for shared reset lines Martin Blumenstingl
2016-10-01 15:21 ` Martin Blumenstingl
2016-10-01 15:21 ` [PATCH 1/3] reset: allow using reset_control_reset with shared reset Martin Blumenstingl
2016-10-01 15:21   ` Martin Blumenstingl
2016-10-04  8:36   ` Philipp Zabel
2016-10-04  8:36     ` Philipp Zabel
2016-10-01 15:21 ` [PATCH 2/3] phy: meson8b-usb2: request a shared reset line Martin Blumenstingl
2016-10-01 15:21   ` Martin Blumenstingl
2016-10-01 15:21 ` [PATCH 3/3] ARM64: dts: meson-gxbb: add the USB reset also to the second USB PHY Martin Blumenstingl
2016-10-01 15:21   ` Martin Blumenstingl
2016-11-12 13:13 ` [PATCH 0/3] enable reset_control_reset for shared reset lines Martin Blumenstingl
2016-11-12 13:13   ` Martin Blumenstingl
2016-11-12 13:13   ` [PATCH 1/3] reset: allow using reset_control_reset with shared reset Martin Blumenstingl
2016-11-12 13:13     ` Martin Blumenstingl
2016-11-15 12:48     ` Philipp Zabel
2016-11-15 12:48       ` Philipp Zabel
2016-11-12 13:13   ` [PATCH 2/3] phy: meson8b-usb2: request a shared reset line Martin Blumenstingl
2016-11-12 13:13     ` Martin Blumenstingl
2016-11-15 12:54     ` Kishon Vijay Abraham I [this message]
2016-11-15 12:54       ` Kishon Vijay Abraham I
2016-11-12 13:13   ` [PATCH 3/3] ARM64: dts: meson-gxbb: add the USB reset also to the second USB PHY Martin Blumenstingl
2016-11-12 13:13     ` Martin Blumenstingl
2016-11-16 21:35     ` Kevin Hilman
2016-11-16 21:35       ` Kevin Hilman
2016-11-18 22:35       ` Martin Blumenstingl
2016-11-18 22:35         ` Martin Blumenstingl
2016-11-21 20:15         ` Kevin Hilman
2016-11-21 20:15           ` Kevin Hilman
2016-11-22 22:05           ` Martin Blumenstingl
2016-11-22 22:05             ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=582B0596.4060903@ti.com \
    --to=kishon@ti.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.