* Re: [Powertop] segmentation fault when shutting
@ 2014-05-08 22:22 Martin Ziegler
0 siblings, 0 replies; 6+ messages in thread
From: Martin Ziegler @ 2014-05-08 22:22 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
The bisection resulted in
commit 5f5976f8b42e4e4717f2d573cf43cb87ccd88fa2
Author: Dan Kalowsky <daniel.kalowsky(a)intel.com>
Date: Tue Apr 29 15:55:31 2014 -0700
Adding a clean_shutdown function
Function is designed to be a on stop place to clean up
the entire application at shutdown time.
as the first bad commit.
Regards
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Powertop] segmentation fault when shutting
@ 2014-05-09 10:06 Sergey Senozhatsky
0 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2014-05-09 10:06 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On (05/09/14 00:22), Martin Ziegler wrote:
> The bisection resulted in
>
> commit 5f5976f8b42e4e4717f2d573cf43cb87ccd88fa2
> Author: Dan Kalowsky <daniel.kalowsky(a)intel.com>
> Date: Tue Apr 29 15:55:31 2014 -0700
>
> Adding a clean_shutdown function
>
> Function is designed to be a on stop place to clean up
> the entire application at shutdown time.
>
> as the first bad commit.
>
thanks, Martin.
yes... well
a) clean_shutdown() calls close_display() which iterates tab_windows[tab_names[i]]
and deletes every tab_window. the problem is that prior to
close_display() main executes clear_tuning(), which [surprise surprise]
does `delete tune_window' since commit eb08d4480969c8e48347c7621bd96dc248ee2138
("Remove another memory leak") , whilst tab_windows[tab_names[i]] still holds
a pointer which we just secretly free()-d. so this is double free().
and it has no other option (and will never have) than to crash.
this obviously has not been tested before push.
b) there is no point in free()-ing memory which will be free()-d anyway,
because we exit() the program.
-ss
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Powertop] segmentation fault when shutting
@ 2014-05-12 23:22 Alexandra Yates
0 siblings, 0 replies; 6+ messages in thread
From: Alexandra Yates @ 2014-05-12 23:22 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
> On (05/09/14 00:22), Martin Ziegler wrote:
>> The bisection resulted in
>>
>> commit 5f5976f8b42e4e4717f2d573cf43cb87ccd88fa2
>> Author: Dan Kalowsky <daniel.kalowsky(a)intel.com>
>> Date: Tue Apr 29 15:55:31 2014 -0700
>>
>> Adding a clean_shutdown function
>>
>> Function is designed to be a on stop place to clean up
>> the entire application at shutdown time.
>>
>> as the first bad commit.
>>
>
> thanks, Martin.
>
> yes... well
>
> a) clean_shutdown() calls close_display() which iterates
> tab_windows[tab_names[i]]
> and deletes every tab_window. the problem is that prior to
> close_display() main executes clear_tuning(), which [surprise surprise]
> does `delete tune_window' since commit
> eb08d4480969c8e48347c7621bd96dc248ee2138
> ("Remove another memory leak") , whilst tab_windows[tab_names[i]] still
> holds
> a pointer which we just secretly free()-d. so this is double free().
> and it has no other option (and will never have) than to crash.
>
> this obviously has not been tested before push.
>
>
> b) there is no point in free()-ing memory which will be free()-d anyway,
> because we exit() the program.
>
> -ss
>
Martin, thank you for reporting and bisecting the culprit.
Sergey, thank you for poking the issues.
Dan, please fix the patches and resend them. They will be included after
release 2.6 is completed.
I reverted Dan Kalowsky's patches.
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Powertop] segmentation fault when shutting
@ 2014-05-14 19:26 Kalowsky, Daniel
0 siblings, 0 replies; 6+ messages in thread
From: Kalowsky, Daniel @ 2014-05-14 19:26 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
Not all patches are at fault here so reverting the entire series seems short sighted. Even the patch in question isn't causing issues on all platforms.
-----Original Message-----
From: Alexandra Yates [mailto:alexandra.yates(a)linux.intel.com]
Sent: Monday, May 12, 2014 4:23 PM
To: powertop(a)lists.01.org
Cc: Kalowsky, Daniel
Subject: Re: [Powertop] segmentation fault when shutting
> On (05/09/14 00:22), Martin Ziegler wrote:
>> The bisection resulted in
>>
>> commit 5f5976f8b42e4e4717f2d573cf43cb87ccd88fa2
>> Author: Dan Kalowsky <daniel.kalowsky(a)intel.com>
>> Date: Tue Apr 29 15:55:31 2014 -0700
>>
>> Adding a clean_shutdown function
>>
>> Function is designed to be a on stop place to clean up
>> the entire application at shutdown time.
>>
>> as the first bad commit.
>>
>
> thanks, Martin.
>
> yes... well
>
> a) clean_shutdown() calls close_display() which iterates
> tab_windows[tab_names[i]] and deletes every tab_window. the problem is
> that prior to
> close_display() main executes clear_tuning(), which [surprise
> surprise] does `delete tune_window' since commit
> eb08d4480969c8e48347c7621bd96dc248ee2138
> ("Remove another memory leak") , whilst tab_windows[tab_names[i]]
> still holds a pointer which we just secretly free()-d. so this is
> double free().
> and it has no other option (and will never have) than to crash.
>
> this obviously has not been tested before push.
>
>
> b) there is no point in free()-ing memory which will be free()-d
> anyway, because we exit() the program.
>
> -ss
>
Martin, thank you for reporting and bisecting the culprit.
Sergey, thank you for poking the issues.
Dan, please fix the patches and resend them. They will be included after release 2.6 is completed.
I reverted Dan Kalowsky's patches.
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Powertop] segmentation fault when shutting
@ 2014-05-14 20:04 Alexandra Yates
0 siblings, 0 replies; 6+ messages in thread
From: Alexandra Yates @ 2014-05-14 20:04 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2179 bytes --]
> Not all patches are at fault here so reverting the entire series seems
> short sighted. Even the patch in question isn't causing issues on all
> platforms.
>
>
> -----Original Message-----
> From: Alexandra Yates [mailto:alexandra.yates(a)linux.intel.com]
> Sent: Monday, May 12, 2014 4:23 PM
> To: powertop(a)lists.01.org
> Cc: Kalowsky, Daniel
> Subject: Re: [Powertop] segmentation fault when shutting
>
>> On (05/09/14 00:22), Martin Ziegler wrote:
>>> The bisection resulted in
>>>
>>> commit 5f5976f8b42e4e4717f2d573cf43cb87ccd88fa2
>>> Author: Dan Kalowsky <daniel.kalowsky(a)intel.com>
>>> Date: Tue Apr 29 15:55:31 2014 -0700
>>>
>>> Adding a clean_shutdown function
>>>
>>> Function is designed to be a on stop place to clean up
>>> the entire application at shutdown time.
>>>
>>> as the first bad commit.
>>>
>>
>> thanks, Martin.
>>
>> yes... well
>>
>> a) clean_shutdown() calls close_display() which iterates
>> tab_windows[tab_names[i]] and deletes every tab_window. the problem is
>> that prior to
>> close_display() main executes clear_tuning(), which [surprise
>> surprise] does `delete tune_window' since commit
>> eb08d4480969c8e48347c7621bd96dc248ee2138
>> ("Remove another memory leak") , whilst tab_windows[tab_names[i]]
>> still holds a pointer which we just secretly free()-d. so this is
>> double free().
>> and it has no other option (and will never have) than to crash.
>>
>> this obviously has not been tested before push.
>>
>>
>> b) there is no point in free()-ing memory which will be free()-d
>> anyway, because we exit() the program.
>>
>> -ss
>>
>
> Martin, thank you for reporting and bisecting the culprit.
>
> Sergey, thank you for poking the issues.
>
> Dan, please fix the patches and resend them. They will be included after
> release 2.6 is completed.
>
> I reverted Dan Kalowsky's patches.
>
> Thank you,
> Alexandra.
>
Hi Dan,
I'm aware of that. However, I made an executive decision in favor of
PowerTOP2.6 release. Your patches will go in and will be included in the
next release after properly fixed and tested.
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Powertop] segmentation fault when shutting
@ 2014-05-14 20:16 Arjan van de Ven
0 siblings, 0 replies; 6+ messages in thread
From: Arjan van de Ven @ 2014-05-14 20:16 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
On 5/14/2014 12:26 PM, Kalowsky, Daniel wrote:
> Not all patches are at fault here so reverting the entire series seems short sighted. Even the patch in question isn't causing issues on all platforms.
reverting is I think the right thing.
Lets revert, and then let these patches go through the normal mailing list review cycle
and then they can easily go back in ;-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-14 20:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 23:22 [Powertop] segmentation fault when shutting Alexandra Yates
-- strict thread matches above, loose matches on Subject: below --
2014-05-14 20:16 Arjan van de Ven
2014-05-14 20:04 Alexandra Yates
2014-05-14 19:26 Kalowsky, Daniel
2014-05-09 10:06 Sergey Senozhatsky
2014-05-08 22:22 Martin Ziegler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.