All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Chris Morgan <macroalpha82@gmail.com>, Jimmy Hon <honyuenkwun@gmail.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH V2 3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
Date: Thu, 31 Oct 2024 13:14:22 +0100	[thread overview]
Message-ID: <5831051.DvuYhMxLoT@diego> (raw)
In-Reply-To: <CALWfF7LNN2dAtr00nLyk8rgE-K1vtSXkjhCFMbkVSzxhhSDvWQ@mail.gmail.com>

Am Donnerstag, 31. Oktober 2024, 01:49:07 CET schrieb Jimmy Hon:
> On Wed, Oct 30, 2024 at 2:25 PM Chris Morgan <macroalpha82@gmail.com> wrote:
> >
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Enable the HDMI0 port for the Indiedroid Nova. The schematics available
> > show the hdmim0_rx_hpdin is connected, so this pinctrl is enabled in
> > contrast with the other rk3588 boards.
> 
> Which pin in the schematic [1] (page 24) does it refer to? It's not
> obvious how to match it up.
> The schematic looks the same as the Rock 5B schematic [2] (page 31)
> and the Rock 5B dts uses the default pinctrl [3]
> 
> Note: The vendor kernel DTS doesn't modify the pinctrl either. [4]
> 
> If you try using the default pinctrl (not overriding), does HDMI not work?

I stumbled over the same issue recently for our Theobroma boards too.

From the Indiedroid schematics, you can see that the hdmim0_rx_hpdin
pin is gpio4_b6, which in their board is connected to the hdmi0_tx_on_h
functionality, which controls the output functionality between hdmi2.0-tmds
and hdmi2.1-frl modes.

The hdmi-driver currently only does hdmi2.0 but normally, on most boards
I've seen so far, this pin has a default pull to set hdmi2.0 anyway, so other
boards don't need that.

So for one, please check if the nova can run without it, but if a pin
setting is needed, please define a new per-board one, labeling it correctly
for this hdmi0_tx_on_h functionality and do not re-use the hdmi-rx
pin-setting.


Heiko




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Chris Morgan <macroalpha82@gmail.com>, Jimmy Hon <honyuenkwun@gmail.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH V2 3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
Date: Thu, 31 Oct 2024 13:14:22 +0100	[thread overview]
Message-ID: <5831051.DvuYhMxLoT@diego> (raw)
In-Reply-To: <CALWfF7LNN2dAtr00nLyk8rgE-K1vtSXkjhCFMbkVSzxhhSDvWQ@mail.gmail.com>

Am Donnerstag, 31. Oktober 2024, 01:49:07 CET schrieb Jimmy Hon:
> On Wed, Oct 30, 2024 at 2:25 PM Chris Morgan <macroalpha82@gmail.com> wrote:
> >
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Enable the HDMI0 port for the Indiedroid Nova. The schematics available
> > show the hdmim0_rx_hpdin is connected, so this pinctrl is enabled in
> > contrast with the other rk3588 boards.
> 
> Which pin in the schematic [1] (page 24) does it refer to? It's not
> obvious how to match it up.
> The schematic looks the same as the Rock 5B schematic [2] (page 31)
> and the Rock 5B dts uses the default pinctrl [3]
> 
> Note: The vendor kernel DTS doesn't modify the pinctrl either. [4]
> 
> If you try using the default pinctrl (not overriding), does HDMI not work?

I stumbled over the same issue recently for our Theobroma boards too.

From the Indiedroid schematics, you can see that the hdmim0_rx_hpdin
pin is gpio4_b6, which in their board is connected to the hdmi0_tx_on_h
functionality, which controls the output functionality between hdmi2.0-tmds
and hdmi2.1-frl modes.

The hdmi-driver currently only does hdmi2.0 but normally, on most boards
I've seen so far, this pin has a default pull to set hdmi2.0 anyway, so other
boards don't need that.

So for one, please check if the nova can run without it, but if a pin
setting is needed, please define a new per-board one, labeling it correctly
for this hdmi0_tx_on_h functionality and do not re-use the hdmi-rx
pin-setting.


Heiko




  reply	other threads:[~2024-10-31 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 19:22 [PATCH V2 0/3] Indiedroid Nova Audio/HDMI Updates Chris Morgan
2024-10-30 19:22 ` Chris Morgan
2024-10-30 19:22 ` [PATCH V2 1/3] arm64: dts: rockchip: correct analog audio name on Indiedroid Nova Chris Morgan
2024-10-30 19:22   ` Chris Morgan
2024-10-30 19:22 ` [PATCH V2 2/3] arm64: dts: rockchip: Enable GPU " Chris Morgan
2024-10-30 19:22   ` Chris Morgan
2024-10-30 19:22 ` [PATCH V2 3/3] arm64: dts: rockchip: Enable HDMI0 " Chris Morgan
2024-10-30 19:22   ` Chris Morgan
2024-10-31  0:49   ` Jimmy Hon
2024-10-31  0:49     ` Jimmy Hon
2024-10-31 12:14     ` Heiko Stübner [this message]
2024-10-31 12:14       ` Heiko Stübner
2024-10-31 14:59       ` Chris Morgan
2024-10-31 14:59         ` Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5831051.DvuYhMxLoT@diego \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=honyuenkwun@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.