All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Florian Vaussard <florian.vaussard@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits
Date: Tue, 29 Nov 2016 11:10:59 -0600	[thread overview]
Message-ID: <583DB6A3.8070305@ti.com> (raw)
In-Reply-To: <1480438754-14794-1-git-send-email-florian.vaussard@heig-vd.ch>

Florian

On 11/29/2016 10:59 AM, Florian Vaussard wrote:
> Hello,
>
> This series fixes similar misues of the regmap_update_bits() API found
> inside the drv2665.c and drv2667.c drivers. More details can be found
> in the message of each patch.
>
> Theses changes are not tested as I do not have the required hardware,
> but the calls to regmap_update_bits() are clearly wrong in the current
> code and the fix seems obvious. Any tests are warmly welcome.
>
> Best regards,
> Florian
>
> Florian Vaussard (2):
>   Input: drv2665: Fix misuse of regmap_update_bits
>   Input: drv2667: Fix misuse of regmap_update_bits

Thanks for the patches what about the drv260x.c?

Dan

>  drivers/input/misc/drv2665.c | 5 +++--
>  drivers/input/misc/drv2667.c | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
>


-- 
------------------
Dan Murphy


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Florian Vaussard <florian.vaussard@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits
Date: Tue, 29 Nov 2016 11:10:59 -0600	[thread overview]
Message-ID: <583DB6A3.8070305@ti.com> (raw)
In-Reply-To: <1480438754-14794-1-git-send-email-florian.vaussard@heig-vd.ch>

Florian

On 11/29/2016 10:59 AM, Florian Vaussard wrote:
> Hello,
>
> This series fixes similar misues of the regmap_update_bits() API found
> inside the drv2665.c and drv2667.c drivers. More details can be found
> in the message of each patch.
>
> Theses changes are not tested as I do not have the required hardware,
> but the calls to regmap_update_bits() are clearly wrong in the current
> code and the fix seems obvious. Any tests are warmly welcome.
>
> Best regards,
> Florian
>
> Florian Vaussard (2):
>   Input: drv2665: Fix misuse of regmap_update_bits
>   Input: drv2667: Fix misuse of regmap_update_bits

Thanks for the patches what about the drv260x.c?

Dan

>  drivers/input/misc/drv2665.c | 5 +++--
>  drivers/input/misc/drv2667.c | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
>


-- 
------------------
Dan Murphy

  parent reply	other threads:[~2016-11-29 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 16:59 [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits Florian Vaussard
2016-11-29 16:59 ` [PATCH 1/2] Input: drv2665: " Florian Vaussard
2016-11-30  1:39   ` Dmitry Torokhov
2016-11-29 16:59 ` [PATCH 2/2] Input: drv2667: " Florian Vaussard
2016-11-30  1:39   ` Dmitry Torokhov
2016-11-29 17:10 ` Dan Murphy [this message]
2016-11-29 17:10   ` [PATCH 0/2] Input: drv266x: " Dan Murphy
2016-11-29 17:24   ` Florian Vaussard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=583DB6A3.8070305@ti.com \
    --to=dmurphy@ti.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=florian.vaussard@gmail.com \
    --cc=florian.vaussard@heig-vd.ch \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.