From: "majun (Euler7)" <majun258@huawei.com>
To: linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
linux-acpi@vger.kernel.org, robert.moore@intel.com,
lenb@kernel.org, lv.zheng@intel.com, rafael.j.wysocki@intel.com,
devel@acpica.org, mark.rutland@arm.com, robh+dt@kernel.org,
jason@lakedaemon.net
Cc: majun258@huawei.com, dingtianhong@huawei.com, guohanjun@huawei.com
Subject: Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi
Date: Thu, 1 Dec 2016 15:43:55 +0800 [thread overview]
Message-ID: <583FD4BB.6060807@huawei.com> (raw)
In-Reply-To: <1480578107-12512-1-git-send-email-majun258@huawei.com>
sorry, ignore this one..
在 2016/12/1 15:41, Majun 写道:
> From: MaJun <majun258@huawei.com>
>
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
>
> Signed-off-by: MaJun <majun258@huawei.com>
> ---
> drivers/acpi/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 56241eb..9918326 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
>
> res->flags = acpi_dev_irq_flags(triggering, polarity, shareable);
> irq = acpi_register_gsi(NULL, gsi, triggering, polarity);
> - if (irq >= 0) {
> + if (irq > 0) {
> res->start = irq;
> res->end = irq;
> } else {
>
WARNING: multiple messages have this Message-ID (diff)
From: "majun (Euler7)" <majun258@huawei.com>
To: <linux-kernel@vger.kernel.org>, <marc.zyngier@arm.com>,
<linux-acpi@vger.kernel.org>, <robert.moore@intel.com>,
<lenb@kernel.org>, <lv.zheng@intel.com>,
<rafael.j.wysocki@intel.com>, <devel@acpica.org>,
<mark.rutland@arm.com>, <robh+dt@kernel.org>,
<jason@lakedaemon.net>
Cc: <majun258@huawei.com>, <dingtianhong@huawei.com>, <guohanjun@huawei.com>
Subject: Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi
Date: Thu, 1 Dec 2016 15:43:55 +0800 [thread overview]
Message-ID: <583FD4BB.6060807@huawei.com> (raw)
In-Reply-To: <1480578107-12512-1-git-send-email-majun258@huawei.com>
sorry, ignore this one..
在 2016/12/1 15:41, Majun 写道:
> From: MaJun <majun258@huawei.com>
>
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
>
> Signed-off-by: MaJun <majun258@huawei.com>
> ---
> drivers/acpi/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 56241eb..9918326 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
>
> res->flags = acpi_dev_irq_flags(triggering, polarity, shareable);
> irq = acpi_register_gsi(NULL, gsi, triggering, polarity);
> - if (irq >= 0) {
> + if (irq > 0) {
> res->start = irq;
> res->end = irq;
> } else {
>
next prev parent reply other threads:[~2016-12-01 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 7:41 [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi Majun
2016-12-01 7:41 ` Majun
2016-12-01 7:43 ` majun (Euler7) [this message]
2016-12-01 7:43 ` majun (Euler7)
-- strict thread matches above, loose matches on Subject: below --
2016-10-12 1:20 MaJun
2016-10-12 1:20 ` MaJun
2016-10-12 2:05 ` Hanjun Guo
2016-10-12 2:05 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583FD4BB.6060807@huawei.com \
--to=majun258@huawei.com \
--cc=devel@acpica.org \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jason@lakedaemon.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.