All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xunlei Pang <xpang@redhat.com>
To: Baoquan He <bhe@redhat.com>, Xunlei Pang <xlpang@redhat.com>
Cc: Robert LeBlanc <robert@leblancnet.us>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
Date: Fri, 23 Dec 2016 16:37:33 +0800	[thread overview]
Message-ID: <585CE24D.80208@redhat.com> (raw)
In-Reply-To: <20161222032234.GB25035@x1>

On 12/22/2016 at 11:22 AM, Baoquan He wrote:
> On 12/15/16 at 11:30am, Xunlei Pang wrote:
>> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
>> with more detailed explanation.
>>
>> Cc: Robert LeBlanc <robert@leblancnet.us>
>> Cc: Baoquan He <bhe@redhat.com>
>> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
>> ---
>>  arch/x86/kernel/setup.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index 9c337b0..79ee507 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
>>  	/* 0 means: find the address automatically */
>>  	if (crash_base <= 0) {
>>  		/*
>> -		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
>> +		 * Set CRASH_ADDR_LOW_MAX upper bound for crash range
>> +		 * as old kexec-tools loads bzImage below that, unless
>> +		 * "size,high" or "size@offset"(nonzero offset, see the
>> +		 * else leg below) is specified.
> Yes, this is a good catch. It might be better to add comment only about
> this if branch. If you want to say more about the upper bounds, better

OK, how about the following change?
        /*
         * Set CRASH_ADDR_LOW_MAX upper bound for crash memory.
         * as old kexec-tools loads bzImage below that, unless
         * "crashkernel=size[KMG],high" is specified.
         */

> discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.

Yes, this is independent of Robert's documentation patch.

>
> Also please CC to x86 maintainers, or akpm. They can help merge this.

OK, thanks!

Regards,
Xunlei

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Xunlei Pang <xpang@redhat.com>
To: Baoquan He <bhe@redhat.com>, Xunlei Pang <xlpang@redhat.com>
Cc: Robert LeBlanc <robert@leblancnet.us>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/crash: Update the stale comment in reserve_crashkernel()
Date: Fri, 23 Dec 2016 16:37:33 +0800	[thread overview]
Message-ID: <585CE24D.80208@redhat.com> (raw)
In-Reply-To: <20161222032234.GB25035@x1>

On 12/22/2016 at 11:22 AM, Baoquan He wrote:
> On 12/15/16 at 11:30am, Xunlei Pang wrote:
>> CRASH_KERNEL_ADDR_MAX was missing for a long time, update it
>> with more detailed explanation.
>>
>> Cc: Robert LeBlanc <robert@leblancnet.us>
>> Cc: Baoquan He <bhe@redhat.com>
>> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
>> ---
>>  arch/x86/kernel/setup.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index 9c337b0..79ee507 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -575,7 +575,10 @@ static void __init reserve_crashkernel(void)
>>  	/* 0 means: find the address automatically */
>>  	if (crash_base <= 0) {
>>  		/*
>> -		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
>> +		 * Set CRASH_ADDR_LOW_MAX upper bound for crash range
>> +		 * as old kexec-tools loads bzImage below that, unless
>> +		 * "size,high" or "size@offset"(nonzero offset, see the
>> +		 * else leg below) is specified.
> Yes, this is a good catch. It might be better to add comment only about
> this if branch. If you want to say more about the upper bounds, better

OK, how about the following change?
        /*
         * Set CRASH_ADDR_LOW_MAX upper bound for crash memory.
         * as old kexec-tools loads bzImage below that, unless
         * "crashkernel=size[KMG],high" is specified.
         */

> discuss with Robert LeBlanc to see if it can be detailed in kdump.txt.

Yes, this is independent of Robert's documentation patch.

>
> Also please CC to x86 maintainers, or akpm. They can help merge this.

OK, thanks!

Regards,
Xunlei

  reply	other threads:[~2016-12-23  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15  3:30 [PATCH] x86/crash: Update the stale comment in reserve_crashkernel() Xunlei Pang
2016-12-15  3:30 ` Xunlei Pang
2016-12-22  3:22 ` Baoquan He
2016-12-22  3:22   ` Baoquan He
2016-12-23  8:37   ` Xunlei Pang [this message]
2016-12-23  8:37     ` Xunlei Pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=585CE24D.80208@redhat.com \
    --to=xpang@redhat.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert@leblancnet.us \
    --cc=xlpang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.