All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keyon Jie <yang.jie@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	dmaengine <dmaengine@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] ASoC: Intel: select DW_DMAC_CORE since it's mandatory
Date: Tue, 3 Jan 2017 10:00:06 +0800	[thread overview]
Message-ID: <586B05A6.2000506@linux.intel.com> (raw)
In-Reply-To: <20170102152017.13938-2-andriy.shevchenko@linux.intel.com>


On 2017年01月02日 23:20, Andy Shevchenko wrote:
> Select DW_DMAC_CORE like the rest of glue drivers do, e.g.
> drivers/dma/dw/Kconfig.
>
> While here group selectors under SND_SOC_INTEL_HASWELL and
> SND_SOC_INTEL_BAYTRAIL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Keyon Jie <yang.jie@linux.intel.com>

thanks,
~Keyon

> ---
>   sound/soc/intel/Kconfig | 26 ++++++++------------------
>   1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index fd5d1e091038..3da3b28b70e1 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -33,11 +33,9 @@ config SND_SOC_INTEL_SST
>   	select SND_SOC_INTEL_SST_MATCH if ACPI
>   	depends on (X86 || COMPILE_TEST)
>
> -# firmware stuff depends DW_DMAC_CORE; since there is no depends-on from
> -# the reverse selection, each machine driver needs to select
> -# SND_SOC_INTEL_SST_FIRMWARE carefully depending on DW_DMAC_CORE
>   config SND_SOC_INTEL_SST_FIRMWARE
>   	tristate
> +	select DW_DMAC_CORE
>
>   config SND_SOC_INTEL_SST_ACPI
>   	tristate
> @@ -47,16 +45,17 @@ config SND_SOC_INTEL_SST_MATCH
>
>   config SND_SOC_INTEL_HASWELL
>   	tristate
> +	select SND_SOC_INTEL_SST
>   	select SND_SOC_INTEL_SST_FIRMWARE
>
>   config SND_SOC_INTEL_BAYTRAIL
>   	tristate
> +	select SND_SOC_INTEL_SST
> +	select SND_SOC_INTEL_SST_FIRMWARE
>
>   config SND_SOC_INTEL_HASWELL_MACH
>   	tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
>   	depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM
> -	depends on DW_DMAC_CORE
> -	select SND_SOC_INTEL_SST
>   	select SND_SOC_INTEL_HASWELL
>   	select SND_SOC_RT5640
>   	help
> @@ -99,9 +98,7 @@ config SND_SOC_INTEL_BXT_RT298_MACH
>   config SND_SOC_INTEL_BYT_RT5640_MACH
>   	tristate "ASoC Audio driver for Intel Baytrail with RT5640 codec"
>   	depends on X86_INTEL_LPSS && I2C
> -	depends on DW_DMAC_CORE && (SND_SST_IPC_ACPI = n)
> -	select SND_SOC_INTEL_SST
> -	select SND_SOC_INTEL_SST_FIRMWARE
> +	depends on SND_SST_IPC_ACPI = n
>   	select SND_SOC_INTEL_BAYTRAIL
>   	select SND_SOC_RT5640
>   	help
> @@ -112,9 +109,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH
>   config SND_SOC_INTEL_BYT_MAX98090_MACH
>   	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
>   	depends on X86_INTEL_LPSS && I2C
> -	depends on DW_DMAC_CORE && (SND_SST_IPC_ACPI = n)
> -	select SND_SOC_INTEL_SST
> -	select SND_SOC_INTEL_SST_FIRMWARE
> +	depends on SND_SST_IPC_ACPI = n
>   	select SND_SOC_INTEL_BAYTRAIL
>   	select SND_SOC_MAX98090
>   	help
> @@ -123,9 +118,7 @@ config SND_SOC_INTEL_BYT_MAX98090_MACH
>
>   config SND_SOC_INTEL_BDW_RT5677_MACH
>   	tristate "ASoC Audio driver for Intel Broadwell with RT5677 codec"
> -	depends on X86_INTEL_LPSS && GPIOLIB && I2C && DW_DMAC
> -	depends on DW_DMAC_CORE=y
> -	select SND_SOC_INTEL_SST
> +	depends on X86_INTEL_LPSS && GPIOLIB && I2C
>   	select SND_SOC_INTEL_HASWELL
>   	select SND_SOC_RT5677
>   	help
> @@ -134,10 +127,7 @@ config SND_SOC_INTEL_BDW_RT5677_MACH
>
>   config SND_SOC_INTEL_BROADWELL_MACH
>   	tristate "ASoC Audio DSP support for Intel Broadwell Wildcatpoint"
> -	depends on X86_INTEL_LPSS && I2C && DW_DMAC && \
> -		   I2C_DESIGNWARE_PLATFORM
> -	depends on DW_DMAC_CORE
> -	select SND_SOC_INTEL_SST
> +	depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM
>   	select SND_SOC_INTEL_HASWELL
>   	select SND_SOC_RT286
>   	help
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2017-01-03  1:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 15:20 [PATCH v3 0/4] ASoC: Intel: clean up Kconfig Andy Shevchenko
2017-01-02 15:20 ` [PATCH v3 1/4] ASoC: Intel: select DW_DMAC_CORE since it's mandatory Andy Shevchenko
2017-01-03  2:00   ` Keyon Jie [this message]
2017-01-02 15:20 ` [PATCH v3 2/4] ASoC: Intel: remove redundant select SND_SOC_INTEL_SST Andy Shevchenko
2017-01-17 18:45   ` Applied "ASoC: Intel: remove redundant select SND_SOC_INTEL_SST" to the asoc tree Mark Brown
2017-01-02 15:20 ` [PATCH v3 3/4] ASoC: Intel: remove ignored dependencies Andy Shevchenko
2017-01-17 18:45   ` Applied "ASoC: Intel: remove ignored dependencies" to the asoc tree Mark Brown
2017-01-02 15:20 ` [PATCH v3 4/4] ASoC: Intel: rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM Andy Shevchenko
2017-01-02 16:05   ` Pierre-Louis Bossart
2017-01-03  3:38     ` Vinod Koul
2017-01-03 14:18       ` Pierre-Louis Bossart
2017-01-04 10:44         ` Andy Shevchenko
2017-01-04 16:58           ` Pierre-Louis Bossart
2017-01-05  3:53             ` Vinod Koul
2017-01-05  8:41               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=586B05A6.2000506@linux.intel.com \
    --to=yang.jie@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.