All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: shawnguo@kernel.org, robh@kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
	krzk+dt@kernel.org, conor+dt@kernel.org, festevam@gmail.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, frank.li@nxp.com,
	aisheng.dong@nxp.com, daniel.baluta@gmail.com,
	laurentiu.mihalcea@nxp.com, shengjiu.wang@nxp.com,
	iuliana.prodan@nxp.com, a.fatoum@pengutronix.de,
	mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Peng Fan <peng.fan@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v5 2/5] arm64: dts: imx8mp: Add mu2 root clock
Date: Mon, 17 Mar 2025 16:30:46 +0100	[thread overview]
Message-ID: <5873285.DvuYhMxLoT@steina-w> (raw)
In-Reply-To: <20250317133306.2003909-3-daniel.baluta@nxp.com>

Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta:
> Enable MU2 node and add mu2 root clock.
> MU2 is used to communicate with DSP core.
> 
> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 3b725fe442d0..5b443fbeded8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1253,7 +1253,7 @@ mu2: mailbox@30e60000 {
>  				reg = <0x30e60000 0x10000>;
>  				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>  				#mbox-cells = <2>;
> -				status = "disabled";

There is no need to enable MU2 if the DSP is disabled by default, no?

Best regards
Alexander

> +				clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_MU2_ROOT>;
>  			};
>  
>  			i2c5: i2c@30ad0000 {
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



  reply	other threads:[~2025-03-17 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 13:33 [PATCH v5 0/5] Configure imx8mp dsp node for rproc usage Daniel Baluta
2025-03-17 13:33 ` [PATCH v5 1/5] arm64: dts: imx8mp: Use resets property Daniel Baluta
2025-03-17 13:33 ` [PATCH v5 2/5] arm64: dts: imx8mp: Add mu2 root clock Daniel Baluta
2025-03-17 15:30   ` Alexander Stein [this message]
2025-03-17 15:58     ` Daniel Baluta
2025-03-17 13:33 ` [PATCH v5 3/5] arm64: dts: imx8mp: Configure dsp node for rproc usage Daniel Baluta
2025-03-17 13:33 ` [PATCH v5 4/5] arm64: dts: imx8mp: Add DSP clocks Daniel Baluta
2025-03-17 13:33 ` [PATCH v5 5/5] arm64: dts: Add dsp rproc related mem regions Daniel Baluta
2025-03-17 20:37 ` [PATCH v5 0/5] Configure imx8mp dsp node for rproc usage Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5873285.DvuYhMxLoT@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=iuliana.prodan@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=laurentiu.mihalcea@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.