* [PATCH v2 2/3] arm64: dts: exynos5433: add HDMI node
2017-01-09 10:40 ` [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node Andrzej Hajda
@ 2017-01-09 10:40 ` Andrzej Hajda
[not found] ` <1483958437-6572-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-09 10:40 ` [PATCH v2 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Andrzej Hajda @ 2017-01-09 10:40 UTC (permalink / raw)
To: linux-samsung-soc, Krzysztof Kozlowski
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas,
devicetree, Andi Shyti, Chanwoo Choi
HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
v2:
- replaced magic numbers with macros,
- removed power domains
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 5552f77..f82d26e 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -837,6 +837,35 @@
iommu-names = "m0", "m1";
};
+ hdmi: hdmi@13970000 {
+ compatible = "samsung,exynos5433-hdmi";
+ reg = <0x13970000 0x70000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cmu_disp CLK_PCLK_HDMI>,
+ <&cmu_disp CLK_PCLK_HDMIPHY>,
+ <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>,
+ <&cmu_disp CLK_PHYCLK_HDMI_PIXEL>,
+ <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>,
+ <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>,
+ <&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>,
+ <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>,
+ <&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>;
+ clock-names = "hdmi_pclk", "hdmi_i_pclk",
+ "i_tmds_clk", "i_pixel_clk",
+ "tmds_clko", "tmds_clko_user",
+ "pixel_clko", "pixel_clko_user",
+ "oscclk", "i_spdif_clk";
+ phy = <&hdmiphy>;
+ ddc = <&hsi2c_11>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,sysreg-phandle = <&syscon_disp>;
+ status = "disabled";
+ };
+
+ hdmiphy: hdmiphy@13af0000 {
+ reg = <0x13af0000 0x80>;
+ };
+
syscon_disp: syscon@13b80000 {
compatible = "syscon";
reg = <0x13b80000 0x1010>;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path
2017-01-09 10:40 ` [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node Andrzej Hajda
2017-01-09 10:40 ` [PATCH v2 2/3] arm64: dts: exynos5433: add HDMI node Andrzej Hajda
@ 2017-01-09 10:40 ` Andrzej Hajda
[not found] ` <1483958437-6572-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-10 2:32 ` hoegeun kwon
[not found] ` <1483958437-6572-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-10 2:31 ` hoegeun kwon
3 siblings, 2 replies; 10+ messages in thread
From: Andrzej Hajda @ 2017-01-09 10:40 UTC (permalink / raw)
To: linux-samsung-soc, Krzysztof Kozlowski
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas,
devicetree, Andi Shyti, Chanwoo Choi
TV path consist of following interconnected components:
- DECON_TV - display controller,
- HDMI - video signal converter RGB / HDMI,
- MHL - video signal converter HDMI / MHL,
- DDC - i2c slave device for EDID reading (on hsi2c_11 bus).
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
v2:
- replaced magic numbers with macros,
- removed assigned-clock properties from sii8620 -
PMU clock is already confgured in PMU node
---
.../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 669bb1f..ca90e6a 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -281,6 +281,22 @@
};
};
+&decon_tv {
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ tv_to_hdmi: endpoint {
+ remote-endpoint = <&hdmi_to_tv>;
+ };
+ };
+ };
+};
+
&dsi {
status = "okay";
vddcore-supply = <&ldo6_reg>;
@@ -304,6 +320,33 @@
};
};
+&hdmi {
+ hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ vdd-supply = <&ldo6_reg>;
+ vdd_osc-supply = <&ldo7_reg>;
+ vdd_pll-supply = <&ldo6_reg>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ hdmi_to_tv: endpoint {
+ remote-endpoint = <&tv_to_hdmi>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ hdmi_to_mhl: endpoint {
+ remote-endpoint = <&mhl_to_hdmi>;
+ };
+ };
+ };
+};
+
&hsi2c_0 {
status = "okay";
clock-frequency = <2500000>;
@@ -692,6 +735,28 @@
};
};
+&hsi2c_7 {
+ status = "okay";
+
+ sii8620@39 {
+ reg = <0x39>;
+ compatible = "sil,sii8620";
+ cvcc10-supply = <&ldo36_reg>;
+ iovcc18-supply = <&ldo34_reg>;
+ interrupt-parent = <&gpf0>;
+ interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
+ reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>;
+ clocks = <&pmu_system_controller 0>;
+ clock-names = "xtal";
+
+ port {
+ mhl_to_hdmi: endpoint {
+ remote-endpoint = <&hdmi_to_mhl>;
+ };
+ };
+ };
+};
+
&hsi2c_8 {
status = "okay";
@@ -735,6 +800,10 @@
};
};
+&hsi2c_11 {
+ status = "okay";
+};
+
&i2s0 {
status = "okay";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread[parent not found: <1483958437-6572-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v2 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path
[not found] ` <1483958437-6572-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2017-01-10 2:20 ` Chanwoo Choi
0 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2017-01-10 2:20 UTC (permalink / raw)
To: Andrzej Hajda, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae,
Rob Herring, Mark Rutland, Javier Martinez Canillas,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti
Hi,
Looks good to me. I tested this patch on TM2 board
with Hoegeun Kwon (hoeguen.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org). It is well working.
Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On 2017년 01월 09일 19:40, Andrzej Hajda wrote:
> TV path consist of following interconnected components:
> - DECON_TV - display controller,
> - HDMI - video signal converter RGB / HDMI,
> - MHL - video signal converter HDMI / MHL,
> - DDC - i2c slave device for EDID reading (on hsi2c_11 bus).
>
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> ---
> v2:
> - replaced magic numbers with macros,
> - removed assigned-clock properties from sii8620 -
> PMU clock is already confgured in PMU node
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 669bb1f..ca90e6a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -281,6 +281,22 @@
> };
> };
>
> +&decon_tv {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + tv_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_tv>;
> + };
> + };
> + };
> +};
> +
> &dsi {
> status = "okay";
> vddcore-supply = <&ldo6_reg>;
> @@ -304,6 +320,33 @@
> };
> };
>
> +&hdmi {
> + hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> + vdd-supply = <&ldo6_reg>;
> + vdd_osc-supply = <&ldo7_reg>;
> + vdd_pll-supply = <&ldo6_reg>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + hdmi_to_tv: endpoint {
> + remote-endpoint = <&tv_to_hdmi>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + hdmi_to_mhl: endpoint {
> + remote-endpoint = <&mhl_to_hdmi>;
> + };
> + };
> + };
> +};
> +
> &hsi2c_0 {
> status = "okay";
> clock-frequency = <2500000>;
> @@ -692,6 +735,28 @@
> };
> };
>
> +&hsi2c_7 {
> + status = "okay";
> +
> + sii8620@39 {
> + reg = <0x39>;
> + compatible = "sil,sii8620";
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + interrupt-parent = <&gpf0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>;
> + clocks = <&pmu_system_controller 0>;
> + clock-names = "xtal";
> +
> + port {
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
> + };
> +};
> +
> &hsi2c_8 {
> status = "okay";
>
> @@ -735,6 +800,10 @@
> };
> };
>
> +&hsi2c_11 {
> + status = "okay";
> +};
> +
> &i2s0 {
> status = "okay";
> };
>
--
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path
2017-01-09 10:40 ` [PATCH v2 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda
[not found] ` <1483958437-6572-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2017-01-10 2:32 ` hoegeun kwon
1 sibling, 0 replies; 10+ messages in thread
From: hoegeun kwon @ 2017-01-10 2:32 UTC (permalink / raw)
To: Andrzej Hajda, linux-samsung-soc, Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae,
Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree,
Andi Shyti, Chanwoo Choi, Hoegeun Kwon
Hi Andrzej,
Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Hoegeun
On 01/09/2017 07:40 PM, Andrzej Hajda wrote:
> TV path consist of following interconnected components:
> - DECON_TV - display controller,
> - HDMI - video signal converter RGB / HDMI,
> - MHL - video signal converter HDMI / MHL,
> - DDC - i2c slave device for EDID reading (on hsi2c_11 bus).
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> v2:
> - replaced magic numbers with macros,
> - removed assigned-clock properties from sii8620 -
> PMU clock is already confgured in PMU node
> ---
> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 669bb1f..ca90e6a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -281,6 +281,22 @@
> };
> };
>
> +&decon_tv {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + tv_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_tv>;
> + };
> + };
> + };
> +};
> +
> &dsi {
> status = "okay";
> vddcore-supply = <&ldo6_reg>;
> @@ -304,6 +320,33 @@
> };
> };
>
> +&hdmi {
> + hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> + vdd-supply = <&ldo6_reg>;
> + vdd_osc-supply = <&ldo7_reg>;
> + vdd_pll-supply = <&ldo6_reg>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + hdmi_to_tv: endpoint {
> + remote-endpoint = <&tv_to_hdmi>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + hdmi_to_mhl: endpoint {
> + remote-endpoint = <&mhl_to_hdmi>;
> + };
> + };
> + };
> +};
> +
> &hsi2c_0 {
> status = "okay";
> clock-frequency = <2500000>;
> @@ -692,6 +735,28 @@
> };
> };
>
> +&hsi2c_7 {
> + status = "okay";
> +
> + sii8620@39 {
> + reg = <0x39>;
> + compatible = "sil,sii8620";
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + interrupt-parent = <&gpf0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>;
> + clocks = <&pmu_system_controller 0>;
> + clock-names = "xtal";
> +
> + port {
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
> + };
> +};
> +
> &hsi2c_8 {
> status = "okay";
>
> @@ -735,6 +800,10 @@
> };
> };
>
> +&hsi2c_11 {
> + status = "okay";
> +};
> +
> &i2s0 {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1483958437-6572-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node
[not found] ` <1483958437-6572-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2017-01-10 2:18 ` Chanwoo Choi
2017-01-10 12:37 ` Andi Shyti
1 sibling, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2017-01-10 2:18 UTC (permalink / raw)
To: Andrzej Hajda, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae,
Rob Herring, Mark Rutland, Javier Martinez Canillas,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti
Hi,
On 2017년 01월 09일 19:40, Andrzej Hajda wrote:
> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path
> or 2nd DSI path.
>
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> ---
>
> Hi Krzysztof,
>
> These patches are based on latest patches separating tm2 and tm2e and
> touchscreen patches. I hope this is good base.
> Thanks all for quick response/review.
>
> Regards
> Andrzej
>
> v2:
> - replaced magic numbers with macros,
> - removed power domains,
> - removed 0x prefixes from node names
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 68f764e..5552f77 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -814,6 +814,29 @@
> };
> };
>
> + decon_tv: decon@13880000 {
The 'decon_tv' node better to be located under the 'decon' node
because of base address ordering. (decon@13800000, decon_tv@13880000)
> + compatible = "samsung,exynos5433-decon-tv";
> + reg = <0x13880000 0x20b8>;
> + clocks = <&cmu_disp CLK_PCLK_DECON_TV>,
> + <&cmu_disp CLK_ACLK_DECON_TV>,
> + <&cmu_disp CLK_ACLK_SMMU_TV0X>,
> + <&cmu_disp CLK_ACLK_XIU_TV0X>,
> + <&cmu_disp CLK_PCLK_SMMU_TV0X>,
> + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>,
> + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>;
> + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x",
> + "aclk_xiu_decon0x", "pclk_smmu_decon0x",
> + "sclk_decon_vclk", "sclk_decon_eclk";
> + samsung,disp-sysreg = <&syscon_disp>;
> + interrupt-names = "fifo", "vsync", "lcd_sys";
> + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>;
> + iommu-names = "m0", "m1";
> + };
> +
[snip]
Except for ordering of 'decon_tv' node, looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Also, I tested these patches on TM2 board
with Hoegeun Kwon (hoeguen.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org). It is well working.
--
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node
[not found] ` <1483958437-6572-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-10 2:18 ` [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node Chanwoo Choi
@ 2017-01-10 12:37 ` Andi Shyti
1 sibling, 0 replies; 10+ messages in thread
From: Andi Shyti @ 2017-01-10 12:37 UTC (permalink / raw)
To: Andrzej Hajda
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae,
Rob Herring, Mark Rutland, Javier Martinez Canillas,
devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi
Hi Andrzej,
On Mon, Jan 09, 2017 at 11:40:35AM +0100, Andrzej Hajda wrote:
> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path
> or 2nd DSI path.
>
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> ---
>
> Hi Krzysztof,
>
> These patches are based on latest patches separating tm2 and tm2e and
> touchscreen patches. I hope this is good base.
> Thanks all for quick response/review.
All the three patches look good to me and they all apply on
Krzysztof's branch and next branch.
If you want you can add my review tag on all of them.
Andi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node
2017-01-09 10:40 ` [PATCH v2 1/3] arm64: dts: exynos5433: add DECON_TV node Andrzej Hajda
` (2 preceding siblings ...)
[not found] ` <1483958437-6572-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2017-01-10 2:31 ` hoegeun kwon
3 siblings, 0 replies; 10+ messages in thread
From: hoegeun kwon @ 2017-01-10 2:31 UTC (permalink / raw)
To: Andrzej Hajda, linux-samsung-soc, Krzysztof Kozlowski
Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae,
Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree,
Andi Shyti, Chanwoo Choi, Hoegeun Kwon
Hi Andrzej,
Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Hoegeun
On 01/09/2017 07:40 PM, Andrzej Hajda wrote:
> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path
> or 2nd DSI path.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> Hi Krzysztof,
>
> These patches are based on latest patches separating tm2 and tm2e and
> touchscreen patches. I hope this is good base.
> Thanks all for quick response/review.
>
> Regards
> Andrzej
>
> v2:
> - replaced magic numbers with macros,
> - removed power domains,
> - removed 0x prefixes from node names
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 68f764e..5552f77 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -814,6 +814,29 @@
> };
> };
>
> + decon_tv: decon@13880000 {
> + compatible = "samsung,exynos5433-decon-tv";
> + reg = <0x13880000 0x20b8>;
> + clocks = <&cmu_disp CLK_PCLK_DECON_TV>,
> + <&cmu_disp CLK_ACLK_DECON_TV>,
> + <&cmu_disp CLK_ACLK_SMMU_TV0X>,
> + <&cmu_disp CLK_ACLK_XIU_TV0X>,
> + <&cmu_disp CLK_PCLK_SMMU_TV0X>,
> + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>,
> + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>;
> + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x",
> + "aclk_xiu_decon0x", "pclk_smmu_decon0x",
> + "sclk_decon_vclk", "sclk_decon_eclk";
> + samsung,disp-sysreg = <&syscon_disp>;
> + interrupt-names = "fifo", "vsync", "lcd_sys";
> + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>;
> + iommu-names = "m0", "m1";
> + };
> +
> syscon_disp: syscon@13b80000 {
> compatible = "syscon";
> reg = <0x13b80000 0x1010>;
> @@ -912,6 +935,26 @@
> #iommu-cells = <0>;
> };
>
> + sysmmu_tv0x: sysmmu@13a20000 {
> + compatible = "samsung,exynos-sysmmu";
> + reg = <0x13a20000 0x1000>;
> + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "pclk", "aclk";
> + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>,
> + <&cmu_disp CLK_ACLK_SMMU_TV0X>;
> + #iommu-cells = <0>;
> + };
> +
> + sysmmu_tv1x: sysmmu@13a30000 {
> + compatible = "samsung,exynos-sysmmu";
> + reg = <0x13a30000 0x1000>;
> + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "pclk", "aclk";
> + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>,
> + <&cmu_disp CLK_ACLK_SMMU_TV1X>;
> + #iommu-cells = <0>;
> + };
> +
> sysmmu_gscl0: sysmmu@0x13C80000 {
> compatible = "samsung,exynos-sysmmu";
> reg = <0x13C80000 0x1000>;
^ permalink raw reply [flat|nested] 10+ messages in thread