From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>, hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations
Date: Wed, 11 Jan 2017 18:46:33 +0800 [thread overview]
Message-ID: <58760D09.9010508@huawei.com> (raw)
In-Reply-To: <20161229221115.31995-1-tj@kernel.org>
On 2016/12/30 6:11, Tejun Heo wrote:
> Hello,
>
> On the v2 hierarchy, when controllers are enabled and disabled, other
> ->*attach() callbacks of other controllers are called spuriously with
> the same source and destination. While this isn't critical, it's a
> bit nasty and can lead to temporary double charging on certain
> controllers. This patchset fixes the issue.
>
> This patchset contains the following three patches.
>
> 0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch
> 0002-cgroup-track-migration-context-in-cgroup_mgctx.patch
> 0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch
>
> 0001-0002 restructures migration context tracking so that extra state
> can be tracked easily. 0003 fixes the spurious ->*attach()
> invocations.
>
> This patchset is also available in the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach
>
> diffstat follows.
>
> kernel/cgroup/cgroup-internal.h | 69 +++++++++++++++--
> kernel/cgroup/cgroup-v1.c | 10 +-
> kernel/cgroup/cgroup.c | 161 ++++++++++++++++------------------------
> 3 files changed, 135 insertions(+), 105 deletions(-)
>
Acked-by: Zefan Li <lizefan@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>, <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations
Date: Wed, 11 Jan 2017 18:46:33 +0800 [thread overview]
Message-ID: <58760D09.9010508@huawei.com> (raw)
In-Reply-To: <20161229221115.31995-1-tj@kernel.org>
On 2016/12/30 6:11, Tejun Heo wrote:
> Hello,
>
> On the v2 hierarchy, when controllers are enabled and disabled, other
> ->*attach() callbacks of other controllers are called spuriously with
> the same source and destination. While this isn't critical, it's a
> bit nasty and can lead to temporary double charging on certain
> controllers. This patchset fixes the issue.
>
> This patchset contains the following three patches.
>
> 0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch
> 0002-cgroup-track-migration-context-in-cgroup_mgctx.patch
> 0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch
>
> 0001-0002 restructures migration context tracking so that extra state
> can be tracked easily. 0003 fixes the spurious ->*attach()
> invocations.
>
> This patchset is also available in the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach
>
> diffstat follows.
>
> kernel/cgroup/cgroup-internal.h | 69 +++++++++++++++--
> kernel/cgroup/cgroup-v1.c | 10 +-
> kernel/cgroup/cgroup.c | 161 ++++++++++++++++------------------------
> 3 files changed, 135 insertions(+), 105 deletions(-)
>
Acked-by: Zefan Li <lizefan@huawei.com>
next prev parent reply other threads:[~2017-01-11 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 22:11 [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations Tejun Heo
2016-12-29 22:11 ` [PATCH 1/3] cgroup: cosmetic update to cgroup_taskset_add() Tejun Heo
2016-12-29 22:11 ` [PATCH 2/3] cgroup: track migration context in cgroup_mgctx Tejun Heo
2016-12-29 22:11 ` [PATCH 3/3] cgroup: call subsys->*attach() only for subsystems which are actually affected by migration Tejun Heo
2017-01-11 10:46 ` Zefan Li [this message]
2017-01-11 10:46 ` [PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations Zefan Li
[not found] ` <58760D09.9010508-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-01-16 0:04 ` Tejun Heo
2017-01-16 0:04 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58760D09.9010508@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.