All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Jiri Pirko <jiri@resnulli.us>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	Dmitry Fleytman <dmitry@daynix.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error
Date: Fri, 13 Jan 2017 16:34:40 +0800	[thread overview]
Message-ID: <58789120.8030809@cn.fujitsu.com> (raw)
In-Reply-To: <87a8av4bdr.fsf@dusky.pond.sub.org>



On 01/13/2017 04:22 PM, Markus Armbruster wrote:
> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
> 
>> Only a tiny modification in patch "megasas: remove unnecessary
>> megasas_use_msix()" to fix a megasas issue.
> 
> Please have a look at Michael's review in
> Message-ID: <20170112163519-mutt-send-email-mst@kernel.org>
> 

Oh...thanks for reminding, I missed that mail...

>> v8 changelog:
>> 1. reorder: place the "megasas: remove unnecessary megasas_use_msix()"
>>    as the last one. and fix the bug in it, detailed description in it,
>>    also removed the R-b of it.
>> 2. Add the Acked-by from Marcel for first 9 patches; add the R-b from Markus
>>    to "hcd-xhci: check & correct param before using it".
>>
>> Test:
>> 1. make check ok
>> 2. command line test for all affected device, make sure their realization
>>    is ok.
>> 3. detailed test for megasas, hcd-xhci, vmxnet3.
>>    megasas: install a linux distro is ok
>>    ./qemu-system-x86_64 --enable-kvm -m 1024
>>    -device megasas,id=scsi0,bus=pci.0
>>    -drive file=/xx/scsi-disk.img,if=none,id=drive-scsi0
>>    -device scsi-disk,bus=scsi0.0,channel=0,scsi-id=4,lun=0,drive=drive-scsi0,id=scsi0-4
>>    -cdrom /xx/Fedora-Server-DVD-x86_64-23.iso --monitor stdio
>>
>>    hcd-xhci: partition the usbstick.img, mkfs, write to file, is ok
>>    ./qemu-system-x86_64 -M q35 -m 1024 --enable-kvm
>>    -drive if=none,id=usbstick,file=/xx/usbstick.img
>>    -device nec-usb-xhci,id=usb,p2=8,p3=8,bus=pcie.0
>>    -device usb-storage,bus=usb.0,drive=usbstick --monitor stdio
>>    /xx/FedoraWorkStatsion23-x86_64.img
>>
>>    vmxnet3: ping another destination belongs to host's network is ok.
>>    But no migration test, because I don't have a spare machine for now.
>>    ./qemu-system-x86_64 -M q35 -m 1024 --enable-kvm
>>    -netdev tap,id=mynet0 -device vmxnet3,netdev=mynet0
>>    --monitor stdio /home/pino/vm/FedoraWorkStatsion23-x86_64.img
> 
> You could migrate to a new QEMU on the same machine.
> 
> Or, if you don't want to deal with two instances of QEMU running at the
> same time, migrate to file:
> 
>     (qemu) migrate "exec:cat >zzz"
> 
> Start the target with -incoming "exec:cat zzz".  Better than nothing.
> 

Thanks for the info, I will try

-- 
Sincerely,
Cao jin

      reply	other threads:[~2017-01-13  8:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  7:11 [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error Cao jin
2017-01-13  7:11 ` [Qemu-devel] [PATCH v8 01/10] msix: Follow CODING_STYLE Cao jin
2017-01-13  7:11 ` [Qemu-devel] [PATCH v8 02/10] hcd-xhci: check & correct param before using it Cao jin
2017-01-13  7:11 ` [Qemu-devel] [PATCH v8 03/10] pci: Convert msix_init() to Error and fix callers to check it Cao jin
2017-01-13  7:11 ` [Qemu-devel] [PATCH v8 04/10] megasas: change behaviour of msix switch Cao jin
2017-01-13  7:11 ` [Qemu-devel] [PATCH v8 05/10] hcd-xhci: " Cao jin
2017-01-13  7:12 ` [Qemu-devel] [PATCH v8 06/10] megasas: undo the overwrites of msi user configuration Cao jin
2017-01-13  7:12 ` [Qemu-devel] [PATCH v8 07/10] vmxnet3: fix reference leak issue Cao jin
2017-01-13  7:12 ` [Qemu-devel] [PATCH v8 08/10] vmxnet3: remove unnecessary internal msix flag Cao jin
2017-01-13  7:12 ` [Qemu-devel] [PATCH v8 09/10] msi_init: convert assert to return -errno Cao jin
2017-01-13  7:12 ` [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix() Cao jin
2017-01-13  8:20   ` Hannes Reinecke
2017-01-13  8:26   ` Markus Armbruster
2017-01-13  8:22 ` [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error Markus Armbruster
2017-01-13  8:34   ` Cao jin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58789120.8030809@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dmitry@daynix.com \
    --cc=hare@suse.de \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kraxel@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.