From: Markus Armbruster <armbru@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix()
Date: Fri, 13 Jan 2017 09:26:33 +0100 [thread overview]
Message-ID: <8760lj2wna.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1484291524-1261-11-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao jin's message of "Fri, 13 Jan 2017 15:12:04 +0800")
Cao jin <caoj.fnst@cn.fujitsu.com> writes:
> Also move certain hunk above, to place msix init related code together.
>
> CC: Hannes Reinecke <hare@suse.de>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Marcel Apfelbaum <marcel@redhat.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/scsi/megasas.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> msix_init() doesn't set the MSI-X enable bit, so use msix_enabled()
> is not right here, restore the old check without the
> megasas_use_msix() wrapper.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2017-01-13 8:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 7:11 [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error Cao jin
2017-01-13 7:11 ` [Qemu-devel] [PATCH v8 01/10] msix: Follow CODING_STYLE Cao jin
2017-01-13 7:11 ` [Qemu-devel] [PATCH v8 02/10] hcd-xhci: check & correct param before using it Cao jin
2017-01-13 7:11 ` [Qemu-devel] [PATCH v8 03/10] pci: Convert msix_init() to Error and fix callers to check it Cao jin
2017-01-13 7:11 ` [Qemu-devel] [PATCH v8 04/10] megasas: change behaviour of msix switch Cao jin
2017-01-13 7:11 ` [Qemu-devel] [PATCH v8 05/10] hcd-xhci: " Cao jin
2017-01-13 7:12 ` [Qemu-devel] [PATCH v8 06/10] megasas: undo the overwrites of msi user configuration Cao jin
2017-01-13 7:12 ` [Qemu-devel] [PATCH v8 07/10] vmxnet3: fix reference leak issue Cao jin
2017-01-13 7:12 ` [Qemu-devel] [PATCH v8 08/10] vmxnet3: remove unnecessary internal msix flag Cao jin
2017-01-13 7:12 ` [Qemu-devel] [PATCH v8 09/10] msi_init: convert assert to return -errno Cao jin
2017-01-13 7:12 ` [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix() Cao jin
2017-01-13 8:20 ` Hannes Reinecke
2017-01-13 8:26 ` Markus Armbruster [this message]
2017-01-13 8:22 ` [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error Markus Armbruster
2017-01-13 8:34 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760lj2wna.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hare@suse.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.