Re: [PATCH v4 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, Shawn Guo <shawnguo@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"S.J. Wang" <shengjiu.wang@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, Daniel Baluta <daniel.baluta@nxp.com>,
	Mpuaudiosw <Mpuaudiosw@nxp.com>,
	Iuliana Prodan <iuliana.prodan@nxp.com>,
	linux-imx <linux-imx@nxp.com>,
	linux-remoteproc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	LnxRevLi <LnxRevLi@nxp.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Date: Tue, 24 Oct 2023 07:37:47 +0200	[thread overview]
Message-ID: <5883038.MhkbZ0Pkbq@steina-w> (raw)
In-Reply-To: <ZTasTEvw4//SEMlW@p14s>

Hi Mathieu,

Am Montag, 23. Oktober 2023, 19:24:28 CEST schrieb Mathieu Poirier:
> Hey guys,
> 
> On Fri, Oct 13, 2023 at 06:27:31PM +0300, Iuliana Prodan (OSS) wrote:
> > From: Iuliana Prodan <iuliana.prodan@nxp.com>
> > 
> > Add the reserve-memory nodes used by DSP when the rpmsg
> > feature is enabled.
> > 
> > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> > ---
> > 
> >  arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 22 ++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index
> > fa37ce89f8d3..b677ad8ef042 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > @@ -125,6 +125,28 @@
> > 
> >  		};
> >  	
> >  	};
> > 
> > +
> > +	reserved-memory {
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +
> > +		dsp_vdev0vring0: vdev0vring0@942f0000 {
> > +			reg = <0 0x942f0000 0 0x8000>;
> > +			no-map;
> > +		};
> > +
> > +		dsp_vdev0vring1: vdev0vring1@942f8000 {
> > +			reg = <0 0x942f8000 0 0x8000>;
> > +			no-map;
> > +		};
> > +
> > +		dsp_vdev0buffer: vdev0buffer@94300000 {
> > +			compatible = "shared-dma-pool";
> > +			reg = <0 0x94300000 0 0x100000>;
> > +			no-map;
> > +		};
> > +	};
> 
> Alexander: Are you good with the refactoring?

Yes, adding this to EVK is good for me.
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> Rob and Krzysztof: I'm not sure if you want to ack this patch but giving you
> the benefit of the doubt.
> 
> Shawn and Sascha: Did you plan on picking up this patch or shoud I?
> 
> Thanks,
> Mathieu
> 
> >  };
> >  
> >  &flexspi {

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/