From: Chanwoo Choi <cw00.choi@samsung.com>
To: Martin Kaiser <martin@kaiser.cx>,
Stephen Boyd <sboyd@codeaurora.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init
Date: Wed, 25 Jan 2017 09:35:50 +0900 [thread overview]
Message-ID: <5887F2E6.7060205@samsung.com> (raw)
In-Reply-To: <1485293599-23581-1-git-send-email-martin@kaiser.cx>
Hi Martin,
On 2017년 01월 25일 06:33, Martin Kaiser wrote:
> These functions are called only by other __init functions.
> Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y,
> I get warnings like
>
> WARNING: vmlinux.o(.text+0x198350):
> Section mismatch in reference from the function s3c2410_clk_sleep_init()
> to the (unknown reference) .init.data:(unknown)
>
> Marking the s3c...._clk_sleep() functions as __init fixes this.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/clk/samsung/clk-s3c2410.c | 4 ++--
> drivers/clk/samsung/clk-s3c2412.c | 4 ++--
> drivers/clk/samsung/clk-s3c2443.c | 4 ++--
> drivers/clk/samsung/clk-s3c64xx.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init
Date: Wed, 25 Jan 2017 09:35:50 +0900 [thread overview]
Message-ID: <5887F2E6.7060205@samsung.com> (raw)
In-Reply-To: <1485293599-23581-1-git-send-email-martin@kaiser.cx>
Hi Martin,
On 2017? 01? 25? 06:33, Martin Kaiser wrote:
> These functions are called only by other __init functions.
> Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y,
> I get warnings like
>
> WARNING: vmlinux.o(.text+0x198350):
> Section mismatch in reference from the function s3c2410_clk_sleep_init()
> to the (unknown reference) .init.data:(unknown)
>
> Marking the s3c...._clk_sleep() functions as __init fixes this.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/clk/samsung/clk-s3c2410.c | 4 ++--
> drivers/clk/samsung/clk-s3c2412.c | 4 ++--
> drivers/clk/samsung/clk-s3c2443.c | 4 ++--
> drivers/clk/samsung/clk-s3c64xx.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-01-25 0:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170124213354epcas2p48cd7596378462562c66017fe39774bb0@epcas2p4.samsung.com>
2017-01-24 21:33 ` [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init Martin Kaiser
2017-01-24 21:33 ` Martin Kaiser
2017-01-25 0:35 ` Chanwoo Choi [this message]
2017-01-25 0:35 ` Chanwoo Choi
2017-01-25 8:30 ` Krzysztof Kozlowski
2017-01-25 8:30 ` Krzysztof Kozlowski
2017-01-25 21:42 ` [PATCH v2] " martin
2017-01-25 21:42 ` martin at kaiser.cx
2017-01-25 23:47 ` Chanwoo Choi
2017-01-25 23:47 ` Chanwoo Choi
2017-01-26 5:58 ` Krzysztof Kozlowski
2017-01-26 5:58 ` Krzysztof Kozlowski
2017-01-27 0:27 ` Stephen Boyd
2017-01-27 0:27 ` Stephen Boyd
2017-01-27 0:27 ` Stephen Boyd
2017-01-27 0:27 ` Stephen Boyd
2017-01-27 10:08 ` Sylwester Nawrocki
2017-01-27 10:08 ` Sylwester Nawrocki
2017-01-27 10:08 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5887F2E6.7060205@samsung.com \
--to=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.