All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jike Song <jike.song@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	igvt-g-dev@ml01.01.org, linux-kernel@vger.kernel.org,
	daniel.vetter@intel.com, zhi.a.wang@intel.com
Subject: Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
Date: Wed, 25 Jan 2017 09:53:24 +0800	[thread overview]
Message-ID: <58880514.6060105@intel.com> (raw)
In-Reply-To: <20170124195239.10061.54664.stgit@gimli.home>

On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
> 
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> This should really be fixed before initial release in v4.10

Acked-by: Jike Song <jike.song@intel.com>

Thanks for finding this!


--
Thanks,
Jike

> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
>  	return NULL;
>  }
>  
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> -		char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> +					struct device *dev, char *buf)
>  {
>  	struct intel_vgpu_type *type;
>  	unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
>  				type->fence);
>  }
>  
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
>  static MDEV_TYPE_ATTR_RO(device_api);
>  static MDEV_TYPE_ATTR_RO(description);
>  
>  static struct attribute *type_attrs[] = {
> -	&mdev_type_attr_available_instance.attr,
> +	&mdev_type_attr_available_instances.attr,
>  	&mdev_type_attr_device_api.attr,
>  	&mdev_type_attr_description.attr,
>  	NULL,
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jike Song <jike.song@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: zhi.a.wang@intel.com, zhenyuw@linux.intel.com,
	jani.nikula@linux.intel.com, airlied@linux.ie,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, igvt-g-dev@ml01.01.org,
	daniel.vetter@intel.com
Subject: Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
Date: Wed, 25 Jan 2017 09:53:24 +0800	[thread overview]
Message-ID: <58880514.6060105@intel.com> (raw)
In-Reply-To: <20170124195239.10061.54664.stgit@gimli.home>

On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
> 
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> This should really be fixed before initial release in v4.10

Acked-by: Jike Song <jike.song@intel.com>

Thanks for finding this!


--
Thanks,
Jike

> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
>  	return NULL;
>  }
>  
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> -		char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> +					struct device *dev, char *buf)
>  {
>  	struct intel_vgpu_type *type;
>  	unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
>  				type->fence);
>  }
>  
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
>  static MDEV_TYPE_ATTR_RO(device_api);
>  static MDEV_TYPE_ATTR_RO(description);
>  
>  static struct attribute *type_attrs[] = {
> -	&mdev_type_attr_available_instance.attr,
> +	&mdev_type_attr_available_instances.attr,
>  	&mdev_type_attr_device_api.attr,
>  	&mdev_type_attr_description.attr,
>  	NULL,
> 

  reply	other threads:[~2017-01-25  1:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 19:53 [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance Alex Williamson
2017-01-24 19:53 ` Alex Williamson
2017-01-25  1:53 ` Jike Song [this message]
2017-01-25  1:53   ` Jike Song
2017-01-25  2:24 ` [igvt-g-dev] " Zhenyu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58880514.6060105@intel.com \
    --to=jike.song@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=igvt-g-dev@ml01.01.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.