From: Josh Hunt <johunt@akamai.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org, bgregg@netflix.com
Subject: Re: [PATCH] perf probe: Ignore vmlinux build-id when offline vmlinux and dry-run used
Date: Wed, 25 Jan 2017 20:46:10 -0600 [thread overview]
Message-ID: <588962F2.3090208@akamai.com> (raw)
In-Reply-To: <20170126113743.2abec2b978377e31a450334b@kernel.org>
On 01/25/2017 08:37 PM, Masami Hiramatsu wrote:
> On Tue, 24 Jan 2017 16:41:28 -0500
> Josh Hunt <johunt@akamai.com> wrote:
>
>> Commit e50243bb ("perf probe: Ignore vmlinux Build-id when offline vmlinux given")
>> added the ability to ignore vmlinux when an offline vmlinux is passed and no
>> l, d, or a flag is also passed. This extends that to ignore build-id when
>> -n/--dry-run is used. This way we can gather probe information for offline kernels
>> using the method Brendan Gregg mentions in this post:
>> http://www.brendangregg.com/blog/2014-09-11/perf-kernel-line-tracing.html .
>
> Sorry, NAK.
> Could you use -D (--definition) for that usage? It directly gives you
> the definition on stdout, and also ignore the buildid.
Ahhh! I guess I totally missed the point of that flag. You're right. It
works exactly the way I want :)
Thanks. Please ignore my patch.
Josh
prev parent reply other threads:[~2017-01-26 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 21:41 [PATCH] perf probe: Ignore vmlinux build-id when offline vmlinux and dry-run used Josh Hunt
2017-01-26 2:37 ` Masami Hiramatsu
2017-01-26 2:46 ` Josh Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588962F2.3090208@akamai.com \
--to=johunt@akamai.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bgregg@netflix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.