From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [Bridge] [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info
Date: Tue, 07 Feb 2017 05:24:16 -0800 [thread overview]
Message-ID: <5899CA80.8030108@cumulusnetworks.com> (raw)
In-Reply-To: <1486468006-8080-1-git-send-email-nikolay@cumulusnetworks.com>
On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote:
> These checks should go after the attributes have been parsed otherwise
> we're using tb uninitialized.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
>
ouch, am surprised i did not catch this. Thanks Colin and Nikolay.
WARNING: multiple messages have this Message-ID (diff)
From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Colin Ian King <colin.king@canonical.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info
Date: Tue, 07 Feb 2017 05:24:16 -0800 [thread overview]
Message-ID: <5899CA80.8030108@cumulusnetworks.com> (raw)
In-Reply-To: <1486468006-8080-1-git-send-email-nikolay@cumulusnetworks.com>
On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote:
> These checks should go after the attributes have been parsed otherwise
> we're using tb uninitialized.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
>
ouch, am surprised i did not catch this. Thanks Colin and Nikolay.
next prev parent reply other threads:[~2017-02-07 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 11:25 [Bridge] bridge: per vlan dst_metadata netlink support Colin Ian King
2017-02-07 11:25 ` Colin Ian King
2017-02-07 11:29 ` [Bridge] " Nikolay Aleksandrov
2017-02-07 11:29 ` Nikolay Aleksandrov via Bridge
2017-02-07 11:46 ` [Bridge] [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info Nikolay Aleksandrov
2017-02-07 11:46 ` Nikolay Aleksandrov
2017-02-07 13:24 ` Roopa Prabhu [this message]
2017-02-07 13:24 ` Roopa Prabhu
2017-02-07 19:05 ` [Bridge] " David Miller
2017-02-07 19:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5899CA80.8030108@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=bridge@lists.linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.