All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
	Adrian Chadd <adrian@freebsd.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Amadeusz Sławiński" <amadeusz.slawinski@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
Date: Tue, 07 Feb 2017 06:46:47 -0800	[thread overview]
Message-ID: <5899DDD7.7000605@candelatech.com> (raw)
In-Reply-To: <87y3xi4b28.fsf@qca.qualcomm.com>



On 02/07/2017 01:14 AM, Valo, Kalle wrote:
> Adrian Chadd <adrian@freebsd.org> writes:
>
>> Removing this method makes the diff to FreeBSD larger, as "vif" in
>> FreeBSD is a different pointer.
>>
>> (Yes, I have ath10k on freebsd working and I'd like to find a way to
>> reduce the diff moving forward.)
>
> I don't like this "(void *) vif->drv_priv" style that much either but
> apparently it's commonly used in Linux wireless code and already parts
> of ath10k. So this patch just unifies the coding style.

Surely the code compiles to the same thing, so why add a patch that
makes it more difficult for Adrian and makes the code no easier to read
for the rest of us?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
	Adrian Chadd <adrian@freebsd.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Amadeusz Sławiński" <amadeusz.slawinski@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
Date: Tue, 07 Feb 2017 06:46:47 -0800	[thread overview]
Message-ID: <5899DDD7.7000605@candelatech.com> (raw)
In-Reply-To: <87y3xi4b28.fsf@qca.qualcomm.com>



On 02/07/2017 01:14 AM, Valo, Kalle wrote:
> Adrian Chadd <adrian@freebsd.org> writes:
>
>> Removing this method makes the diff to FreeBSD larger, as "vif" in
>> FreeBSD is a different pointer.
>>
>> (Yes, I have ath10k on freebsd working and I'd like to find a way to
>> reduce the diff moving forward.)
>
> I don't like this "(void *) vif->drv_priv" style that much either but
> apparently it's commonly used in Linux wireless code and already parts
> of ath10k. So this patch just unifies the coding style.

Surely the code compiles to the same thing, so why add a patch that
makes it more difficult for Adrian and makes the code no easier to read
for the rest of us?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2017-02-07 14:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 10:19 [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Amadeusz Sławiński
2017-02-02 10:19 ` Amadeusz Sławiński
2017-02-02 10:19 ` [PATCH 2/3] ath10k: use size_t for len variables Amadeusz Sławiński
2017-02-02 10:19   ` Amadeusz Sławiński
2017-02-02 19:20   ` Sebastian Gottschall
2017-02-02 19:20     ` Sebastian Gottschall
2017-02-02 10:19 ` [PATCH 3/3] ath10k: fix comment Amadeusz Sławiński
2017-02-02 10:19   ` Amadeusz Sławiński
2017-02-02 16:17 ` [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Adrian Chadd
2017-02-02 16:17   ` Adrian Chadd
2017-02-07  9:14   ` Valo, Kalle
2017-02-07  9:14     ` Valo, Kalle
2017-02-07  9:14     ` Valo, Kalle
2017-02-07 14:46     ` Ben Greear [this message]
2017-02-07 14:46       ` Ben Greear
2017-02-10  7:03       ` Valo, Kalle
2017-02-10  7:03         ` Valo, Kalle
2017-02-10  7:03         ` Valo, Kalle
2017-02-10  7:14         ` Adrian Chadd
2017-02-10  7:14           ` Adrian Chadd
2017-02-10  7:37           ` Joe Perches
2017-02-10  7:37             ` Joe Perches
2017-02-10 15:31             ` Adrian Chadd
2017-02-10 15:31               ` Adrian Chadd
2017-02-10 15:31               ` Adrian Chadd
2017-02-10 16:43         ` Ben Greear
2017-02-10 16:43           ` Ben Greear
2017-02-14 17:40 ` [1/3] " Kalle Valo
2017-02-14 17:40   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5899DDD7.7000605@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=adrian@freebsd.org \
    --cc=amadeusz.slawinski@tieto.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.