From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Daniel Vetter
<daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Jingoo Han <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Inki Dae <inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Joonyoung Shim
<jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Seung-Woo Kim
<sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Krzysztof Kozlowski
<krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Javier Martinez Canillas
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>,
Alison Wang <alison.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Xinliang Liu
<z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Rongrong Zou
<zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Xinwei Kong
<kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Chen Feng
<puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>Philipp Zabel
<p>
Subject: Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge
Date: Fri, 10 Feb 2017 11:42:55 -0800 [thread overview]
Message-ID: <589E17BF.1060106@gmail.com> (raw)
In-Reply-To: <20170204033635.10250-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 02/03/17 19:36, Rob Herring wrote:
> Many drivers have a common pattern of searching the OF graph for either an
> attached panel or bridge and then finding the DRM struct for the panel
> or bridge. Also, most drivers need to handle deferred probing when the
> DRM device is not yet instantiated. Create a common function,
> drm_of_find_panel_or_bridge, to find the connected node and the
> associated DRM panel or bridge device.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/gpu/drm/drm_of.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/drm/drm_of.h | 13 +++++++++++++
> 2 files changed, 63 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 47848ed8ca48..b29ce2f52113 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -3,7 +3,9 @@
> #include <linux/list.h>
> #include <linux/of_graph.h>
> #include <drm/drmP.h>
> +#include <drm/drm_bridge.h>
> #include <drm/drm_crtc.h>
> +#include <drm/drm_panel.h>
> #include <drm/drm_of.h>
>
> static void drm_release_of(struct device *dev, void *data)
> @@ -207,3 +209,51 @@ int drm_of_encoder_active_endpoint(struct device_node *node,
> return -EINVAL;
> }
> EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> +
> +/*
> + * drm_of_find_panel_or_bridge - return connected panel or bridge device
> + * @np: device tree node containing encoder input ports
@port: ....
@endpoint: ....
> + * @panel: pointer to hold returned drm_panel
> + * @bridge: pointer to hold returned drm_bridge
> + *
> + * Given a DT node's port and endpoint number, find the connected node and
> + * return either the associated struct drm_panel or drm_bridge device.
> + *
> + * Returns zero if successful, or one of the standard error codes if it fails.
> + */
> +int drm_of_find_panel_or_bridge(const struct device_node *np,
> + int port, int endpoint,
> + struct drm_panel **panel,
> + struct drm_bridge **bridge)
> +{
< snip >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Archit Taneja <architt@codeaurora.org>,
Jingoo Han <jingoohan1@gmail.com>,
Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Stefan Agner <stefan@agner.ch>,
Alison Wang <alison.wang@freescale.com>,
Xinliang Liu <z.liuxinliang@hisilicon.com>,
Rongrong Zou <zourongrong@gmail.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Chen Feng <puck.chen@hisilicon.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
CK Hu <ck.hu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Marek Vasut <marex@denx.de>, Mark Yao <mark.yao@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Liviu Dudau <liviu.dudau@arm.com>,
Mali DP Maintainers <malidp@foss.arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Rob Clark <robdclark@gmail.com>, Jyri Sarha <jsarha@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Eric Anholt <eric@anholt.net>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge
Date: Fri, 10 Feb 2017 11:42:55 -0800 [thread overview]
Message-ID: <589E17BF.1060106@gmail.com> (raw)
In-Reply-To: <20170204033635.10250-3-robh@kernel.org>
On 02/03/17 19:36, Rob Herring wrote:
> Many drivers have a common pattern of searching the OF graph for either an
> attached panel or bridge and then finding the DRM struct for the panel
> or bridge. Also, most drivers need to handle deferred probing when the
> DRM device is not yet instantiated. Create a common function,
> drm_of_find_panel_or_bridge, to find the connected node and the
> associated DRM panel or bridge device.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/gpu/drm/drm_of.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/drm/drm_of.h | 13 +++++++++++++
> 2 files changed, 63 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 47848ed8ca48..b29ce2f52113 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -3,7 +3,9 @@
> #include <linux/list.h>
> #include <linux/of_graph.h>
> #include <drm/drmP.h>
> +#include <drm/drm_bridge.h>
> #include <drm/drm_crtc.h>
> +#include <drm/drm_panel.h>
> #include <drm/drm_of.h>
>
> static void drm_release_of(struct device *dev, void *data)
> @@ -207,3 +209,51 @@ int drm_of_encoder_active_endpoint(struct device_node *node,
> return -EINVAL;
> }
> EXPORT_SYMBOL_GPL(drm_of_encoder_active_endpoint);
> +
> +/*
> + * drm_of_find_panel_or_bridge - return connected panel or bridge device
> + * @np: device tree node containing encoder input ports
@port: ....
@endpoint: ....
> + * @panel: pointer to hold returned drm_panel
> + * @bridge: pointer to hold returned drm_bridge
> + *
> + * Given a DT node's port and endpoint number, find the connected node and
> + * return either the associated struct drm_panel or drm_bridge device.
> + *
> + * Returns zero if successful, or one of the standard error codes if it fails.
> + */
> +int drm_of_find_panel_or_bridge(const struct device_node *np,
> + int port, int endpoint,
> + struct drm_panel **panel,
> + struct drm_bridge **bridge)
> +{
< snip >
next prev parent reply other threads:[~2017-02-10 19:42 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 3:36 [PATCH 0/5] DRM OF graph clean-up Rob Herring
2017-02-04 3:36 ` Rob Herring
2017-02-04 3:36 ` [PATCH 1/5] of: introduce of_graph_get_remote_node Rob Herring
2017-02-04 3:36 ` Rob Herring
2017-02-06 8:50 ` Daniel Vetter
2017-02-06 8:50 ` Daniel Vetter
2017-02-06 13:41 ` Rob Herring
2017-02-06 13:41 ` Rob Herring
[not found] ` <20170204033635.10250-2-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-04 16:10 ` Vladimir Zapolskiy
2017-02-04 16:10 ` Vladimir Zapolskiy
2017-02-06 10:32 ` Philipp Zabel
2017-02-06 10:32 ` Philipp Zabel
2017-02-06 13:54 ` Rob Herring
2017-02-06 13:54 ` Rob Herring
[not found] ` <CAL_JsqJ2HO6WkSGccqGaxHPExnJGyRwrrL2wDOORO+auA=Jbrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-06 14:03 ` Philipp Zabel
2017-02-06 14:03 ` Philipp Zabel
2017-02-04 3:36 ` [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge Rob Herring
2017-02-04 3:36 ` Rob Herring
[not found] ` <20170204033635.10250-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-06 10:18 ` Liviu Dudau
2017-02-06 10:18 ` Liviu Dudau
[not found] ` <20170206101851.GU3140-A/Nd4k6kWRHZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2017-02-06 16:20 ` Rob Herring
2017-02-06 16:20 ` Rob Herring
2017-02-06 10:42 ` Philipp Zabel
2017-02-06 10:42 ` Philipp Zabel
[not found] ` <1486377768.3005.34.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-06 16:53 ` Rob Herring
2017-02-06 16:53 ` Rob Herring
2017-02-06 17:45 ` Philipp Zabel
2017-02-06 17:45 ` Philipp Zabel
2017-02-10 19:42 ` Frank Rowand [this message]
2017-02-10 19:42 ` Frank Rowand
2017-02-04 3:36 ` [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node Rob Herring
2017-02-04 3:36 ` Rob Herring
[not found] ` <20170204033635.10250-4-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-06 8:31 ` Jyri Sarha
2017-02-06 8:31 ` Jyri Sarha
2017-02-06 10:17 ` Neil Armstrong
2017-02-06 10:17 ` Neil Armstrong
2017-02-06 10:29 ` Liviu Dudau
2017-02-06 10:29 ` Liviu Dudau
[not found] ` <20170206102933.GV3140-A/Nd4k6kWRHZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2017-02-06 17:09 ` Rob Herring
2017-02-06 17:09 ` Rob Herring
2017-02-06 17:23 ` Liviu Dudau
2017-02-06 17:23 ` Liviu Dudau
[not found] ` <20170206172306.GY3140-A/Nd4k6kWRHZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2017-02-06 17:34 ` Russell King - ARM Linux
2017-02-06 17:34 ` Russell King - ARM Linux
[not found] ` <20170206173407.GK27312-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-02-06 17:55 ` Liviu Dudau
2017-02-06 17:55 ` Liviu Dudau
[not found] ` <20170206175533.GZ3140-A/Nd4k6kWRHZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2017-02-06 18:09 ` Russell King - ARM Linux
2017-02-06 18:09 ` Russell King - ARM Linux
2017-02-06 17:42 ` Rob Herring
2017-02-06 17:42 ` Rob Herring
2017-02-06 10:52 ` Philipp Zabel
2017-02-06 10:52 ` Philipp Zabel
2017-02-06 13:40 ` Rob Herring
2017-02-06 13:40 ` Rob Herring
2017-02-08 11:57 ` Liviu Dudau
2017-02-08 11:57 ` Liviu Dudau
2017-02-08 20:44 ` Eric Anholt
2017-02-08 20:44 ` Eric Anholt
2017-02-04 3:36 ` [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge Rob Herring
2017-02-04 3:36 ` Rob Herring
[not found] ` <20170204033635.10250-5-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-04 20:26 ` Fabio Estevam
2017-02-04 20:26 ` Fabio Estevam
2017-02-05 22:25 ` Rob Herring
2017-02-05 22:25 ` Rob Herring
[not found] ` <CAL_JsqKnPryTDhXKQtRZ05KZ1KDgNi40JP5W8HFgcEZJUTSBFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-06 0:01 ` Fabio Estevam
2017-02-06 0:01 ` Fabio Estevam
[not found] ` <CAOMZO5AmrpfDaC3rmH+DTON+xgYuFeXKpVhYHMxYqF9eh3Af-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-06 1:22 ` Fabio Estevam
2017-02-06 1:22 ` Fabio Estevam
2017-02-06 10:03 ` Maxime Ripard
2017-02-06 10:03 ` Maxime Ripard
2017-02-06 17:32 ` Rob Herring
2017-02-06 17:32 ` Rob Herring
2017-02-08 7:46 ` Maxime Ripard
2017-02-08 7:46 ` Maxime Ripard
2017-02-06 11:07 ` Philipp Zabel
2017-02-06 11:07 ` Philipp Zabel
2017-02-04 3:36 ` [PATCH 5/5] drm: omap: use common OF graph helpers Rob Herring
2017-02-04 3:36 ` Rob Herring
2017-02-04 10:47 ` [PATCH 0/5] DRM OF graph clean-up Russell King - ARM Linux
2017-02-04 10:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589E17BF.1060106@gmail.com \
--to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=alison.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.