From: walter harms <wharms@bfs.de>
To: Timur Tabi <timur@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Date: Mon, 13 Feb 2017 13:28:50 +0000 [thread overview]
Message-ID: <58A1B492.9000103@bfs.de> (raw)
In-Reply-To: <23c98d90-913d-f590-2677-096bf5dc15ff@codeaurora.org>
Am 13.02.2017 14:03, schrieb Timur Tabi:
> walter harms wrote:
>> We have a function where the argument is ignored and the rest is const ?
>>
>> emac_ethtool_get_regs_len seems the only user. So it would be fairly
>> easy to
>> move that into that function.
>>
>> @maintainer:
>> Is there a deeper logic behind this ?
>
> I don't understand the question.
The question is: why is a simple calculation const*const
separated into a function ?
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Timur Tabi <timur@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Date: Mon, 13 Feb 2017 14:28:50 +0100 [thread overview]
Message-ID: <58A1B492.9000103@bfs.de> (raw)
In-Reply-To: <23c98d90-913d-f590-2677-096bf5dc15ff@codeaurora.org>
Am 13.02.2017 14:03, schrieb Timur Tabi:
> walter harms wrote:
>> We have a function where the argument is ignored and the rest is const ?
>>
>> emac_ethtool_get_regs_len seems the only user. So it would be fairly
>> easy to
>> move that into that function.
>>
>> @maintainer:
>> Is there a deeper logic behind this ?
>
> I don't understand the question.
The question is: why is a simple calculation const*const
separated into a function ?
re,
wh
next prev parent reply other threads:[~2017-02-13 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 11:00 [patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter
2017-02-13 11:00 ` Dan Carpenter
2017-02-13 11:55 ` walter harms
2017-02-13 11:55 ` walter harms
2017-02-13 13:03 ` Timur Tabi
2017-02-13 13:03 ` Timur Tabi
2017-02-13 13:28 ` walter harms [this message]
2017-02-13 13:28 ` walter harms
2017-02-13 15:43 ` Timur Tabi
2017-02-13 15:43 ` Timur Tabi
2017-02-13 14:00 ` Dan Carpenter
2017-02-13 14:00 ` Dan Carpenter
2017-02-13 15:43 ` Timur Tabi
2017-02-13 15:43 ` Timur Tabi
2017-02-13 15:57 ` walter harms
2017-02-13 16:23 ` Timur Tabi
2017-02-14 3:21 ` David Miller
2017-02-14 3:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58A1B492.9000103@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.