From: Yunlong Song <yunlong.song@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>,
cm224.lee@samsung.com, chao@kernel.org, sylinux@163.com,
miaoxie@huawei.com, bintian.wang@huawei.com,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro
Date: Sat, 25 Feb 2017 16:10:45 +0800 [thread overview]
Message-ID: <58B13C05.50900@huawei.com> (raw)
In-Reply-To: <20170224181235.GC39009@jaegeuk.local>
On 2017/2/25 2:12, Jaegeuk Kim wrote:
>
> This is to handle only one case in which:
>
> 1. uses old kernel without this flag,
> 2. calls fsync and gets sudden power-cut,
> 3. updates new kernel having this flag before mount.
>
> Then, if we do not check this flag at mount time, we will lose the last fsync'ed
> node blocks.
>
So I just send a v2 patch to only change to macro in fill_node_footer_blkaddr and
allocate_segment_by_default, these two functions are called frequently, so it is
better to use macro code. And I remain the original checking code in is_recoverable_dnode,
this function is called only once after mount, it's OK.
--
Thanks,
Yunlong Song
WARNING: multiple messages have this Message-ID (diff)
From: Yunlong Song <yunlong.song@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>, <cm224.lee@samsung.com>,
<chao@kernel.org>, <sylinux@163.com>, <miaoxie@huawei.com>,
<bintian.wang@huawei.com>, <linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro
Date: Sat, 25 Feb 2017 16:10:45 +0800 [thread overview]
Message-ID: <58B13C05.50900@huawei.com> (raw)
In-Reply-To: <20170224181235.GC39009@jaegeuk.local>
On 2017/2/25 2:12, Jaegeuk Kim wrote:
>
> This is to handle only one case in which:
>
> 1. uses old kernel without this flag,
> 2. calls fsync and gets sudden power-cut,
> 3. updates new kernel having this flag before mount.
>
> Then, if we do not check this flag at mount time, we will lose the last fsync'ed
> node blocks.
>
So I just send a v2 patch to only change to macro in fill_node_footer_blkaddr and
allocate_segment_by_default, these two functions are called frequently, so it is
better to use macro code. And I remain the original checking code in is_recoverable_dnode,
this function is called only once after mount, it's OK.
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2017-02-25 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:06 [PATCH] f2fs: change the codes of checking CP_CRC_RECOVERY_FLAG to macro Yunlong Song
2017-02-24 10:06 ` Yunlong Song
2017-02-24 10:29 ` Chao Yu
2017-02-24 10:29 ` Chao Yu
2017-02-24 11:11 ` Yunlong Song
2017-02-24 11:11 ` Yunlong Song
2017-02-24 11:37 ` Chao Yu
2017-02-24 11:37 ` Chao Yu
2017-02-24 11:57 ` Yunlong Song
2017-02-24 11:57 ` Yunlong Song
2017-02-24 18:12 ` Jaegeuk Kim
2017-02-25 0:54 ` Chao Yu
2017-02-25 0:54 ` Chao Yu
2017-02-25 8:10 ` Yunlong Song [this message]
2017-02-25 8:10 ` Yunlong Song
2017-02-25 8:01 ` [PATCH v2] " Yunlong Song
2017-02-25 8:01 ` Yunlong Song
2017-02-25 18:46 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58B13C05.50900@huawei.com \
--to=yunlong.song@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=cm224.lee@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=sylinux@163.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.