* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
@ 2017-02-27 1:01 Tom Rini
2017-02-27 1:37 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2017-02-27 1:01 UTC (permalink / raw)
To: u-boot
For a long while dtc has warned about various constructs. This is now
leading to log file size being exceeded in travis, and as the majority
of these errors need to be fixed in the kernel, switch to using the
stock device-tree-compiler package.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
.travis.yml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 48b7b101f1c6..8333fae9b333 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -28,11 +28,12 @@ addons:
- grub-efi-ia32-bin
- rpm2cpio
- wget
+ - device-tree-compiler
install:
# install latest device tree compiler
- - git clone --depth=1 git://git.kernel.org/pub/scm/utils/dtc/dtc.git /tmp/dtc
- - make -j4 -C /tmp/dtc
+ #- git clone --depth=1 git://git.kernel.org/pub/scm/utils/dtc/dtc.git /tmp/dtc
+ #- make -j4 -C /tmp/dtc
# Clone uboot-test-hooks
- git clone --depth=1 git://github.com/swarren/uboot-test-hooks.git /tmp/uboot-test-hooks
- ln -s travis-ci /tmp/uboot-test-hooks/bin/`hostname`
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
2017-02-27 1:01 [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler Tom Rini
@ 2017-02-27 1:37 ` Tom Rini
2017-02-27 4:34 ` Robert Nelson
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2017-02-27 1:37 UTC (permalink / raw)
To: u-boot
On Sun, Feb 26, 2017 at 08:01:19PM -0500, Tom Rini wrote:
> For a long while dtc has warned about various constructs. This is now
> leading to log file size being exceeded in travis, and as the majority
> of these errors need to be fixed in the kernel, switch to using the
> stock device-tree-compiler package.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
But I'm not happy to have to apply it, either. I do not wish to break
travis-ci, but sun7i is now exceeding the allowed stdout size. And
these are problems that need to be fixed in the kernel first, rather
than here first. The patches to fix u-boot local issues (such as x86
never got picked up either, but likely need to be respun. I expect that
once the new DTC version is tagged and populated upstream in the kernel
as well, we will be able to re-enable the changes we had here.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170226/9fa1844f/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
2017-02-27 1:37 ` Tom Rini
@ 2017-02-27 4:34 ` Robert Nelson
2017-02-27 5:29 ` Heiko Schocher
0 siblings, 1 reply; 6+ messages in thread
From: Robert Nelson @ 2017-02-27 4:34 UTC (permalink / raw)
To: u-boot
On Sun, Feb 26, 2017 at 7:37 PM, Tom Rini <trini@konsulko.com> wrote:
> On Sun, Feb 26, 2017 at 08:01:19PM -0500, Tom Rini wrote:
>
>> For a long while dtc has warned about various constructs. This is now
>> leading to log file size being exceeded in travis, and as the majority
>> of these errors need to be fixed in the kernel, switch to using the
>> stock device-tree-compiler package.
>>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>
> Applied to u-boot/master, thanks!
>
> But I'm not happy to have to apply it, either. I do not wish to break
> travis-ci, but sun7i is now exceeding the allowed stdout size. And
> these are problems that need to be fixed in the kernel first, rather
> than here first. The patches to fix u-boot local issues (such as x86
> never got picked up either, but likely need to be respun. I expect that
> once the new DTC version is tagged and populated upstream in the kernel
> as well, we will be able to re-enable the changes we had here.
This was fixed (aka a hidden bandaid) in the linux kernel via:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d
Regards,
--
Robert Nelson
https://rcn-ee.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
2017-02-27 4:34 ` Robert Nelson
@ 2017-02-27 5:29 ` Heiko Schocher
2017-02-27 5:52 ` Robert Nelson
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Schocher @ 2017-02-27 5:29 UTC (permalink / raw)
To: u-boot
Hello Robert,
Am 27.02.2017 um 05:34 schrieb Robert Nelson:
> On Sun, Feb 26, 2017 at 7:37 PM, Tom Rini <trini@konsulko.com> wrote:
>> On Sun, Feb 26, 2017 at 08:01:19PM -0500, Tom Rini wrote:
>>
>>> For a long while dtc has warned about various constructs. This is now
>>> leading to log file size being exceeded in travis, and as the majority
>>> of these errors need to be fixed in the kernel, switch to using the
>>> stock device-tree-compiler package.
>>>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>
>> Applied to u-boot/master, thanks!
>>
>> But I'm not happy to have to apply it, either. I do not wish to break
>> travis-ci, but sun7i is now exceeding the allowed stdout size. And
>> these are problems that need to be fixed in the kernel first, rather
>> than here first. The patches to fix u-boot local issues (such as x86
>> never got picked up either, but likely need to be respun. I expect that
>> once the new DTC version is tagged and populated upstream in the kernel
>> as well, we will be able to re-enable the changes we had here.
>
> This was fixed (aka a hidden bandaid) in the linux kernel via:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d
Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around
a year ago, and we decided to not apply them in u-boot, instead they
should go away via kernel resyncs, when the warnings are fixed in the
kernel!
Also I think, I tried a similiar approach as the commit you mentioned...
Ah, yes, here:
http://lists.denx.de/pipermail/u-boot/2016-April/252408.html
We decided (for u-boot) it would be better to fix the problems and
not supress the warning, but it seems, the problems get not really fixed
in the kernel ...
I wasn;t aware of the above patch in the kernel... thanks for pointing!
@Tom:
So, I feel, the problems get not fixed fast in the kernel (if ever),
may we want to cherry-pick this patch from the kernel (or make a
similiar patch for U-Boot)?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
2017-02-27 5:29 ` Heiko Schocher
@ 2017-02-27 5:52 ` Robert Nelson
2017-02-27 15:46 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Robert Nelson @ 2017-02-27 5:52 UTC (permalink / raw)
To: u-boot
On Sun, Feb 26, 2017 at 11:29 PM, Heiko Schocher <hs@denx.de> wrote:
> Hello Robert,
>
> Am 27.02.2017 um 05:34 schrieb Robert Nelson:
>>
>> On Sun, Feb 26, 2017 at 7:37 PM, Tom Rini <trini@konsulko.com> wrote:
>>>
>>> On Sun, Feb 26, 2017 at 08:01:19PM -0500, Tom Rini wrote:
>>>
>>>> For a long while dtc has warned about various constructs. This is now
>>>> leading to log file size being exceeded in travis, and as the majority
>>>> of these errors need to be fixed in the kernel, switch to using the
>>>> stock device-tree-compiler package.
>>>>
>>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>>
>>>
>>> Applied to u-boot/master, thanks!
>>>
>>> But I'm not happy to have to apply it, either. I do not wish to break
>>> travis-ci, but sun7i is now exceeding the allowed stdout size. And
>>> these are problems that need to be fixed in the kernel first, rather
>>> than here first. The patches to fix u-boot local issues (such as x86
>>> never got picked up either, but likely need to be respun. I expect that
>>> once the new DTC version is tagged and populated upstream in the kernel
>>> as well, we will be able to re-enable the changes we had here.
>>
>>
>> This was fixed (aka a hidden bandaid) in the linux kernel via:
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d
>
>
> Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around
> a year ago, and we decided to not apply them in u-boot, instead they
> should go away via kernel resyncs, when the warnings are fixed in the
> kernel!
>
> Also I think, I tried a similiar approach as the commit you mentioned...
> Ah, yes, here:
> http://lists.denx.de/pipermail/u-boot/2016-April/252408.html
>
> We decided (for u-boot) it would be better to fix the problems and
> not supress the warning, but it seems, the problems get not really fixed
> in the kernel ...
>
> I wasn;t aware of the above patch in the kernel... thanks for pointing!
and i think by moving the kernel to disable that patch, it's slowed
down the number of register fix patches..
ps, this just came in on kbuild list just a few minutes ago:
https://marc.info/?l=linux-kbuild&m=148817429929267&w=2
one of the issues with bc553986a2f7c56d0de811485d5312ea29692d5d is
that it breaks the build with older version of dtc that don't know
what to do with the -Wno-unit_address_vs_reg flag..
Regards,
--
Robert Nelson
https://rcn-ee.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler
2017-02-27 5:52 ` Robert Nelson
@ 2017-02-27 15:46 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-02-27 15:46 UTC (permalink / raw)
To: u-boot
On Sun, Feb 26, 2017 at 11:52:21PM -0600, Robert Nelson wrote:
> On Sun, Feb 26, 2017 at 11:29 PM, Heiko Schocher <hs@denx.de> wrote:
> > Hello Robert,
> >
> > Am 27.02.2017 um 05:34 schrieb Robert Nelson:
> >>
> >> On Sun, Feb 26, 2017 at 7:37 PM, Tom Rini <trini@konsulko.com> wrote:
> >>>
> >>> On Sun, Feb 26, 2017 at 08:01:19PM -0500, Tom Rini wrote:
> >>>
> >>>> For a long while dtc has warned about various constructs. This is now
> >>>> leading to log file size being exceeded in travis, and as the majority
> >>>> of these errors need to be fixed in the kernel, switch to using the
> >>>> stock device-tree-compiler package.
> >>>>
> >>>> Signed-off-by: Tom Rini <trini@konsulko.com>
> >>>
> >>>
> >>> Applied to u-boot/master, thanks!
> >>>
> >>> But I'm not happy to have to apply it, either. I do not wish to break
> >>> travis-ci, but sun7i is now exceeding the allowed stdout size. And
> >>> these are problems that need to be fixed in the kernel first, rather
> >>> than here first. The patches to fix u-boot local issues (such as x86
> >>> never got picked up either, but likely need to be respun. I expect that
> >>> once the new DTC version is tagged and populated upstream in the kernel
> >>> as well, we will be able to re-enable the changes we had here.
> >>
> >>
> >> This was fixed (aka a hidden bandaid) in the linux kernel via:
> >>
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d
> >
> >
> > Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around
> > a year ago, and we decided to not apply them in u-boot, instead they
> > should go away via kernel resyncs, when the warnings are fixed in the
> > kernel!
> >
> > Also I think, I tried a similiar approach as the commit you mentioned...
> > Ah, yes, here:
> > http://lists.denx.de/pipermail/u-boot/2016-April/252408.html
> >
> > We decided (for u-boot) it would be better to fix the problems and
> > not supress the warning, but it seems, the problems get not really fixed
> > in the kernel ...
> >
> > I wasn;t aware of the above patch in the kernel... thanks for pointing!
>
> and i think by moving the kernel to disable that patch, it's slowed
> down the number of register fix patches..
>
> ps, this just came in on kbuild list just a few minutes ago:
>
> https://marc.info/?l=linux-kbuild&m=148817429929267&w=2
>
> one of the issues with bc553986a2f7c56d0de811485d5312ea29692d5d is
> that it breaks the build with older version of dtc that don't know
> what to do with the -Wno-unit_address_vs_reg flag..
Coalescing things back in to one thread, yes, for the next release, we
should switch over to key'ing the warning based on
KBUILD_ENABLE_EXTRA_GCC_CHECKS and only once the patch to conditionally
pass the flag in question is possible as well. Thanks all!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170227/3f56de1b/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-27 15:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-27 1:01 [U-Boot] [PATCH] travis-ci: Temporarily disable using a newer device tree compiler Tom Rini
2017-02-27 1:37 ` Tom Rini
2017-02-27 4:34 ` Robert Nelson
2017-02-27 5:29 ` Heiko Schocher
2017-02-27 5:52 ` Robert Nelson
2017-02-27 15:46 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.