From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
Date: Wed, 8 Mar 2017 13:08:22 +0200 [thread overview]
Message-ID: <58BFE626.6030107@linux.intel.com> (raw)
In-Reply-To: <1488934285.14325.8.camel@mhfsdcap03>
On 08.03.2017 02:51, Chunfeng Yun wrote:
> On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
>> On 07.03.2017 05:32, Chunfeng Yun wrote:
>>> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
>>> so checks the Maximum Primary Stream Array Size in the hcc_params
>>> register after adding primary hcd.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thanks.
>> Looks like streams check has never worked for Mediatek xHC hosts,
>>
>> Do you know if this has caused any issues?
>> looks like it should go usb-linus and maybe stable kernels as well.
> No issues on mt8173, because it doesn't support bulk stream. But it
> causes a issue on the newest SoC which is not upstreamed, so I think it
> needn't go stable kernels.
>
Ok, thanks, skipping stable
-Mathias
WARNING: multiple messages have this Message-ID (diff)
From: mathias.nyman@linux.intel.com (Mathias Nyman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
Date: Wed, 8 Mar 2017 13:08:22 +0200 [thread overview]
Message-ID: <58BFE626.6030107@linux.intel.com> (raw)
In-Reply-To: <1488934285.14325.8.camel@mhfsdcap03>
On 08.03.2017 02:51, Chunfeng Yun wrote:
> On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
>> On 07.03.2017 05:32, Chunfeng Yun wrote:
>>> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
>>> so checks the Maximum Primary Stream Array Size in the hcc_params
>>> register after adding primary hcd.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thanks.
>> Looks like streams check has never worked for Mediatek xHC hosts,
>>
>> Do you know if this has caused any issues?
>> looks like it should go usb-linus and maybe stable kernels as well.
> No issues on mt8173, because it doesn't support bulk stream. But it
> causes a issue on the newest SoC which is not upstreamed, so I think it
> needn't go stable kernels.
>
Ok, thanks, skipping stable
-Mathias
next prev parent reply other threads:[~2017-03-08 11:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 3:32 [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd Chunfeng Yun
2017-03-07 3:32 ` Chunfeng Yun
2017-03-07 3:32 ` Chunfeng Yun
2017-03-07 3:32 ` [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct Chunfeng Yun
2017-03-07 3:32 ` Chunfeng Yun
2017-03-07 3:32 ` Chunfeng Yun
2017-03-07 11:02 ` Thierry Reding
2017-03-07 11:02 ` Thierry Reding
2017-03-07 11:02 ` Thierry Reding
2017-03-07 15:12 ` Mathias Nyman
2017-03-07 15:12 ` Mathias Nyman
2017-03-07 15:12 ` Mathias Nyman
2017-03-07 15:10 ` [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd Mathias Nyman
2017-03-07 15:10 ` Mathias Nyman
2017-03-07 15:10 ` Mathias Nyman
[not found] ` <58BECD83.9000205-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-03-08 0:51 ` Chunfeng Yun
2017-03-08 0:51 ` Chunfeng Yun
2017-03-08 0:51 ` Chunfeng Yun
2017-03-08 11:08 ` Mathias Nyman [this message]
2017-03-08 11:08 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BFE626.6030107@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=chunfeng.yun@mediatek.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.