From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Jiri Kosina <trivial@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: cs35l35: trivial fix to indentation
Date: Sun, 12 Mar 2017 15:55:28 +0100 [thread overview]
Message-ID: <58C56160.9070208@bfs.de> (raw)
In-Reply-To: <20170311191922.6209-1-colin.king@canonical.com>
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove extraneous tab to correct the nesting level indentation
>
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>
> for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
> cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>
I have the feeling is better before the loop:
cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
for (i = 0; i < cs35l35->num_supplies; i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
re,
wh
> ret = devm_regulator_bulk_get(&i2c_client->dev,
> cs35l35->num_supplies,
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Jiri Kosina <trivial@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: cs35l35: trivial fix to indentation
Date: Sun, 12 Mar 2017 14:55:28 +0000 [thread overview]
Message-ID: <58C56160.9070208@bfs.de> (raw)
In-Reply-To: <20170311191922.6209-1-colin.king@canonical.com>
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove extraneous tab to correct the nesting level indentation
>
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>
> for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
> cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>
I have the feeling is better before the loop:
cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
for (i = 0; i < cs35l35->num_supplies; i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
re,
wh
> ret = devm_regulator_bulk_get(&i2c_client->dev,
> cs35l35->num_supplies,
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jiri Kosina <trivial@kernel.org>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs35l35: trivial fix to indentation
Date: Sun, 12 Mar 2017 15:55:28 +0100 [thread overview]
Message-ID: <58C56160.9070208@bfs.de> (raw)
In-Reply-To: <20170311191922.6209-1-colin.king@canonical.com>
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove extraneous tab to correct the nesting level indentation
>
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>
> for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
> cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>
I have the feeling is better before the loop:
cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
for (i = 0; i < cs35l35->num_supplies; i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
re,
wh
> ret = devm_regulator_bulk_get(&i2c_client->dev,
> cs35l35->num_supplies,
next prev parent reply other threads:[~2017-03-12 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 19:19 [PATCH] ASoC: cs35l35: trivial fix to indentation Colin King
2017-03-12 14:55 ` walter harms [this message]
2017-03-12 14:55 ` walter harms
2017-03-12 14:55 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58C56160.9070208@bfs.de \
--to=wharms@bfs.de \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.