All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Christian.Koenig-5C7GfCeVMHo@public.gmane.org,
	Alexander.Deucher-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH 12/15] drm/amdgpu: limit block size to one page
Date: Tue, 28 Mar 2017 11:07:12 +0800	[thread overview]
Message-ID: <58D9D360.4080902@amd.com> (raw)
In-Reply-To: <1490594005-14553-13-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>

On 03/27/2017 01:53 PM, Chunming Zhou wrote:
> Change-Id: I00ff5d2c7ff29563394cb8af4c57780b91876743
> Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 7bad6b6..4041d72 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1079,6 +1079,14 @@ static bool amdgpu_check_pot_argument(int arg)
>
>   static void amdgpu_get_block_size(struct amdgpu_device *adev)
>   {
> +	/* from AI, asic starts to support multiple level VMPT */
> +	if (adev->family >= AMDGPU_FAMILY_AI) {
> +		if (amdgpu_vm_block_size != 9)
> +			dev_warn(adev->dev, "Multi-VMPT limits block size to"
> +				 "one page!\n");
> +		amdgpu_vm_block_size = 9;

Do you mean for multi-VMPT, the block size must be 9?
Is that related to page level?

Jerry

> +		return;
> +	}
>   	/* defines number of bits in page table versus page directory,
>   	 * a page is 4KB so we have 12 bits offset, minimum 9 bits in the
>   	 * page table and the remaining bits are in the page directory */
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-03-28  3:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  5:53 [PATCH 00/15] *** Multiple level VMPT enablement *** Chunming Zhou
     [not found] ` <1490594005-14553-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-27  5:53   ` [PATCH 01/15] drm/amdgpu: rename page_directory_fence to last_dir_update Chunming Zhou
2017-03-27  5:53   ` [PATCH 02/15] drm/amdgpu: add the VM pointer to the amdgpu_pte_update_params as well Chunming Zhou
2017-03-27  5:53   ` [PATCH 03/15] drm/amdgpu: add num_level to the VM manager Chunming Zhou
     [not found]     ` <1490594005-14553-4-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-27 17:05       ` William Lewis
2017-03-27  5:53   ` [PATCH 04/15] drm/amdgpu: generalize page table level Chunming Zhou
2017-03-27  5:53   ` [PATCH 05/15] drm/amdgpu: handle multi level PD size calculation Chunming Zhou
     [not found]     ` <1490594005-14553-6-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-28  2:41       ` Zhang, Jerry (Junwei)
2017-03-27  5:53   ` [PATCH 06/15] drm/amdgpu: handle multi level PD during validation Chunming Zhou
2017-03-27  5:53   ` [PATCH 07/15] drm/amdgpu: handle multi level PD in the LRU Chunming Zhou
2017-03-27  5:53   ` [PATCH 08/15] drm/amdgpu: handle multi level PD updates V2 Chunming Zhou
2017-03-27  5:53   ` [PATCH 09/15] drm/amdgpu: handle multi level PD during PT updates Chunming Zhou
2017-03-27  5:53   ` [PATCH 10/15] drm/amdgpu: add alloc/free for multi level PDs V2 Chunming Zhou
2017-03-27  5:53   ` [PATCH 11/15] drm/amdgpu: abstract block size to one function Chunming Zhou
2017-03-27  5:53   ` [PATCH 12/15] drm/amdgpu: limit block size to one page Chunming Zhou
     [not found]     ` <1490594005-14553-13-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-28  3:07       ` Zhang, Jerry (Junwei) [this message]
2017-03-27  5:53   ` [PATCH 13/15] drm/amdgpu: adapt vm size for multi vmpt Chunming Zhou
     [not found]     ` <1490594005-14553-14-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-03-28  3:19       ` Zhang, Jerry (Junwei)
     [not found]         ` <58D9D656.7090107-5C7GfCeVMHo@public.gmane.org>
2017-03-28  3:43           ` zhoucm1
2017-03-28  8:38           ` Christian König
2017-03-27  5:53   ` [PATCH 14/15] drm/amdgpu: set page table depth by num_level Chunming Zhou
2017-03-27  5:53   ` [PATCH 15/15] drm/amdgpu: enable four level VMPT for gmc9 Chunming Zhou
2017-03-27  9:37   ` [PATCH 00/15] *** Multiple level VMPT enablement *** Christian König
     [not found]     ` <eef2fbb5-8318-4ec3-c91f-b2cb7f9fee86-5C7GfCeVMHo@public.gmane.org>
2017-03-27 16:05       ` Deucher, Alexander
     [not found]         ` <BN6PR12MB1652FBDB212BC00E7461DB84F7330-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-03-28  3:21           ` Zhang, Jerry (Junwei)
2017-03-28 20:14   ` Multilevel page tables broken for high addresses Felix Kuehling
     [not found]     ` <31bd63c4-5ab6-d6f8-8b7c-3411e45c1c57-5C7GfCeVMHo@public.gmane.org>
2017-03-28 20:25       ` Deucher, Alexander
     [not found]         ` <BN6PR12MB16523E15828BC0C8ED26EF04F7320-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-03-28 20:31           ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D9D360.4080902@amd.com \
    --to=jerry.zhang-5c7gfcevmho@public.gmane.org \
    --cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=David1.Zhou-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.