From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, cl@linux.com
Subject: Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
Date: Wed, 29 Mar 2017 10:38:17 +0800 [thread overview]
Message-ID: <58DB1E19.4020501@cn.fujitsu.com> (raw)
In-Reply-To: <20170328160040.GC28157@htj.duckdns.org>
On 03/29/2017 12:00 AM, Tejun Heo wrote:
> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> I'm not sure. I think I used it during development and it's not like
> it costs anything to keep.
>
It easily confusing newbies without any comments for its purpose.
Temporary using during development seems not good to persist. Could I
know its purpose?
--
Sincerely,
Cao jin
WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <cl@linux.com>
Subject: Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
Date: Wed, 29 Mar 2017 10:38:17 +0800 [thread overview]
Message-ID: <58DB1E19.4020501@cn.fujitsu.com> (raw)
In-Reply-To: <20170328160040.GC28157@htj.duckdns.org>
On 03/29/2017 12:00 AM, Tejun Heo wrote:
> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> I'm not sure. I think I used it during development and it's not like
> it costs anything to keep.
>
It easily confusing newbies without any comments for its purpose.
Temporary using during development seems not good to persist. Could I
know its purpose?
--
Sincerely,
Cao jin
next prev parent reply other threads:[~2017-03-29 2:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:35 [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin
2017-03-28 8:35 ` Cao jin
2017-03-28 16:00 ` Tejun Heo
2017-03-29 2:38 ` Cao jin [this message]
2017-03-29 2:38 ` Cao jin
2017-03-29 15:28 ` Tejun Heo
2017-03-30 3:34 ` Cao jin
2017-03-30 3:34 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DB1E19.4020501@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.