From: xuwei5@hisilicon.com (Wei Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()
Date: Mon, 10 Apr 2017 16:23:37 +0100 [thread overview]
Message-ID: <58EBA379.90401@hisilicon.com> (raw)
In-Reply-To: <20170205163255.28589-1-weiyj.lk@gmail.com>
Hi Yongjun,
On 2017/2/5 16:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks!
Applied to the hisilicon soc tree.
Best Regards,
Wei
> ---
> v1 -> v2: fix file module
> ---
> arch/arm/mach-hisi/platmcpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
> &hip04_boot_method[0], 4);
> if (ret)
> goto err;
> +
> + ret = -ENODEV;
> np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
> if (!np_sctl)
> goto err;
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Xu <xuwei5@hisilicon.com>
To: Wei Yongjun <weiyj.lk@gmail.com>, Russell King <linux@armlinux.org.uk>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()
Date: Mon, 10 Apr 2017 16:23:37 +0100 [thread overview]
Message-ID: <58EBA379.90401@hisilicon.com> (raw)
In-Reply-To: <20170205163255.28589-1-weiyj.lk@gmail.com>
Hi Yongjun,
On 2017/2/5 16:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks!
Applied to the hisilicon soc tree.
Best Regards,
Wei
> ---
> v1 -> v2: fix file module
> ---
> arch/arm/mach-hisi/platmcpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
> &hip04_boot_method[0], 4);
> if (ret)
> goto err;
> +
> + ret = -ENODEV;
> np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
> if (!np_sctl)
> goto err;
>
>
>
next prev parent reply other threads:[~2017-04-10 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 16:41 [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Wei Yongjun
2017-01-22 16:41 ` Wei Yongjun
2017-01-22 18:12 ` Russell King - ARM Linux
2017-01-22 18:12 ` Russell King - ARM Linux
2017-02-05 16:32 ` [PATCH -next v2] ARM: hisi: " Wei Yongjun
2017-02-05 16:32 ` Wei Yongjun
2017-04-10 15:23 ` Wei Xu [this message]
2017-04-10 15:23 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58EBA379.90401@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.