All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/exynos/dsi: fix bridge_node DT parsing
       [not found] <CGME20170412072216eucas1p136149c39438639424d3b8ab4f8d548e8@eucas1p1.samsung.com>
@ 2017-04-12  7:22 ` Andrzej Hajda
  2017-04-12 13:58   ` Hoegeun Kwon
  2017-04-13  7:22   ` Inki Dae
  0 siblings, 2 replies; 5+ messages in thread
From: Andrzej Hajda @ 2017-04-12  7:22 UTC (permalink / raw)
  To: inki.dae, dri-devel, linux-samsung-soc
  Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski

DSIM uses MIC bridge which is between DECON and DSIM, so the driver
should expect bridge node on input side.

Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node")
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index dcb50d4d..3ae459f 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
 
 	of_node_put(ep);
 
-	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0);
+	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
 	if (!dsi->bridge_node)
 		return -EINVAL;
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/dsi: fix bridge_node DT parsing
  2017-04-12  7:22 ` [PATCH] drm/exynos/dsi: fix bridge_node DT parsing Andrzej Hajda
@ 2017-04-12 13:58   ` Hoegeun Kwon
  2017-04-12 14:13     ` Marek Szyprowski
  2017-04-13  7:22   ` Inki Dae
  1 sibling, 1 reply; 5+ messages in thread
From: Hoegeun Kwon @ 2017-04-12 13:58 UTC (permalink / raw)
  To: Andrzej Hajda, inki.dae, dri-devel, linux-samsung-soc
  Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, hoegeun.kwon

On 04/12/2017 04:22 PM, Andrzej Hajda wrote:
> DSIM uses MIC bridge which is between DECON and DSIM, so the driver
> should expect bridge node on input side.
>
> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index dcb50d4d..3ae459f 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   
>   	of_node_put(ep);
>   
> -	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0);
> +	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>   	if (!dsi->bridge_node)
>   		return -EINVAL;

Hi Andrzej,

The of_graph_get_remote_node() does not exist in the kernel.
Also this patch  does not apply('git am') on drm-next tree.
Is this what you mean?
         dsi->bridge_node = of_graph_get_endpoint_by_regs(node, 
DSI_PORT_IN, 0);
         if (!dsi->bridge_node)
                 return -EINVAL;

Best regards,
Hoegeun

>   

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/dsi: fix bridge_node DT parsing
  2017-04-12 13:58   ` Hoegeun Kwon
@ 2017-04-12 14:13     ` Marek Szyprowski
  2017-04-13  1:58       ` Hoegeun Kwon
  0 siblings, 1 reply; 5+ messages in thread
From: Marek Szyprowski @ 2017-04-12 14:13 UTC (permalink / raw)
  To: Hoegeun Kwon, Andrzej Hajda, inki.dae, dri-devel,
	linux-samsung-soc
  Cc: hoegeun.kwon, Bartlomiej Zolnierkiewicz

Hi Hoegeun,

On 2017-04-12 15:58, Hoegeun Kwon wrote:
> On 04/12/2017 04:22 PM, Andrzej Hajda wrote:
>> DSIM uses MIC bridge which is between DECON and DSIM, so the driver
>> should expect bridge node on input side.
>>
>> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node")
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c 
>> b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> index dcb50d4d..3ae459f 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct 
>> exynos_dsi *dsi)
>>         of_node_put(ep);
>>   -    dsi->bridge_node = of_graph_get_remote_node(node, 
>> DSI_PORT_OUT, 0);
>> +    dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>>       if (!dsi->bridge_node)
>>           return -EINVAL;
>
> Hi Andrzej,
>
> The of_graph_get_remote_node() does not exist in the kernel.
> Also this patch  does not apply('git am') on drm-next tree.
> Is this what you mean?
>         dsi->bridge_node = of_graph_get_endpoint_by_regs(node, 
> DSI_PORT_IN, 0);
>         if (!dsi->bridge_node)
>                 return -EINVAL;

Please check latest drm-next branch at 
git://people.freedesktop.org/~airlied/linux.git

Commit 86418f90a4c "drm: convert drivers to use 
of_graph_get_remote_node" got merged
via drm-misc tree and Andrzej's patch is a fix for it.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/dsi: fix bridge_node DT parsing
  2017-04-12 14:13     ` Marek Szyprowski
@ 2017-04-13  1:58       ` Hoegeun Kwon
  0 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-04-13  1:58 UTC (permalink / raw)
  To: Marek Szyprowski, Hoegeun Kwon, Andrzej Hajda, inki.dae,
	dri-devel, linux-samsung-soc
  Cc: Bartlomiej Zolnierkiewicz, Hoegeun Kwon

On 04/12/2017 11:13 PM, Marek Szyprowski wrote:
> Hi Hoegeun,
>
> On 2017-04-12 15:58, Hoegeun Kwon wrote:
>> On 04/12/2017 04:22 PM, Andrzej Hajda wrote:
>>> DSIM uses MIC bridge which is between DECON and DSIM, so the driver
>>> should expect bridge node on input side.
>>>
>>> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node")
>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>> ---
>>>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c 
>>> b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>>> index dcb50d4d..3ae459f 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>>> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct 
>>> exynos_dsi *dsi)
>>>         of_node_put(ep);
>>>   -    dsi->bridge_node = of_graph_get_remote_node(node, 
>>> DSI_PORT_OUT, 0);
>>> +    dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>>>       if (!dsi->bridge_node)
>>>           return -EINVAL;
>>
>> Hi Andrzej,
>>
>> The of_graph_get_remote_node() does not exist in the kernel.
>> Also this patch  does not apply('git am') on drm-next tree.
>> Is this what you mean?
>>         dsi->bridge_node = of_graph_get_endpoint_by_regs(node, 
>> DSI_PORT_IN, 0);
>>         if (!dsi->bridge_node)
>>                 return -EINVAL;
>
> Please check latest drm-next branch at 
> git://people.freedesktop.org/~airlied/linux.git
>
> Commit 86418f90a4c "drm: convert drivers to use 
> of_graph_get_remote_node" got merged
> via drm-misc tree and Andrzej's patch is a fix for it.

Hi Marek,

I have checked the exynos drm-next branch
at http://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git

Sorry, there was a mistake.

Best regards,
Hoegeun

>
> Best regards

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/dsi: fix bridge_node DT parsing
  2017-04-12  7:22 ` [PATCH] drm/exynos/dsi: fix bridge_node DT parsing Andrzej Hajda
  2017-04-12 13:58   ` Hoegeun Kwon
@ 2017-04-13  7:22   ` Inki Dae
  1 sibling, 0 replies; 5+ messages in thread
From: Inki Dae @ 2017-04-13  7:22 UTC (permalink / raw)
  To: Andrzej Hajda, dri-devel, linux-samsung-soc
  Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski


2017년 04월 12일 16:22에 Andrzej Hajda 이(가) 쓴 글:
> DSIM uses MIC bridge which is between DECON and DSIM, so the driver
> should expect bridge node on input side.

Confirmed and merged.

Thanks,
Inki Dae

> 
> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index dcb50d4d..3ae459f 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>  
>  	of_node_put(ep);
>  
> -	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0);
> +	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>  	if (!dsi->bridge_node)
>  		return -EINVAL;
>  
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-13  7:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20170412072216eucas1p136149c39438639424d3b8ab4f8d548e8@eucas1p1.samsung.com>
2017-04-12  7:22 ` [PATCH] drm/exynos/dsi: fix bridge_node DT parsing Andrzej Hajda
2017-04-12 13:58   ` Hoegeun Kwon
2017-04-12 14:13     ` Marek Szyprowski
2017-04-13  1:58       ` Hoegeun Kwon
2017-04-13  7:22   ` Inki Dae

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.