From: Cathy Avery <cavery@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sthemmin@microsoft.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
jejb@linux.vnet.ibm.com
Subject: Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun
Date: Mon, 17 Apr 2017 15:44:22 -0400 [thread overview]
Message-ID: <58F51B16.1070202@redhat.com> (raw)
In-Reply-To: <20170415140647.GA12851@infradead.org>
On 04/15/2017 10:06 AM, Christoph Hellwig wrote:
> Just add a singlethreaded workqueue for storvsc_handle_error and you'll
> get serialization for all error handling for free.
The problem I am seeing is that many work items can be queued up for the
same lun before it goes away. The single threaded queue would have to allow
for only a queue of one and no more. Either that or each work item for a
particular lun must have the same memory address so it gets
rejected if it you try to queue a remove to the same lun twice.
Maybe I am not understanding your suggestion correctly.
Thanks,
Cathy
WARNING: multiple messages have this Message-ID (diff)
From: Cathy Avery <cavery@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: kys@microsoft.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, sthemmin@microsoft.com,
haiyangz@microsoft.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun
Date: Mon, 17 Apr 2017 15:44:22 -0400 [thread overview]
Message-ID: <58F51B16.1070202@redhat.com> (raw)
In-Reply-To: <20170415140647.GA12851@infradead.org>
On 04/15/2017 10:06 AM, Christoph Hellwig wrote:
> Just add a singlethreaded workqueue for storvsc_handle_error and you'll
> get serialization for all error handling for free.
The problem I am seeing is that many work items can be queued up for the
same lun before it goes away. The single threaded queue would have to allow
for only a queue of one and no more. Either that or each work item for a
particular lun must have the same memory address so it gets
rejected if it you try to queue a remove to the same lun twice.
Maybe I am not understanding your suggestion correctly.
Thanks,
Cathy
next prev parent reply other threads:[~2017-04-17 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 13:43 [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun Cathy Avery
2017-04-15 14:06 ` Christoph Hellwig
2017-04-15 14:06 ` Christoph Hellwig
2017-04-17 19:44 ` Cathy Avery [this message]
2017-04-17 19:44 ` Cathy Avery
-- strict thread matches above, loose matches on Subject: below --
2017-10-17 17:32 Cathy Avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58F51B16.1070202@redhat.com \
--to=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.