[PATCH 0/4] staging: rtl8712: Fix multiple checkpatch issues.

[PATCH 0/4] staging: rtl8712: Fix multiple checkpatch issues.

[Varsha Rao]

Fixes multiple checkpatch issues in rtl8712 driver.

Varsha Rao (4):
  staging: rtl8712: Remove unnecessary parentheses.
  staging: rtl8712: Removes the FSF mailing address.
  staging: rtl8712: Remove space after a cast.
  staging: rtl8712: Match alignment with open parenthesis.

 drivers/staging/rtl8712/os_intfs.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

-- 
2.9.3

Re: [PATCH 0/4] staging: rtl8712: Fix multiple checkpatch issues.

[Greg Kroah-Hartman]

On Sat, Feb 18, 2017 at 01:25:04AM +0530, Varsha Rao wrote:
> Fixes multiple checkpatch issues in rtl8712 driver.
> 
> Varsha Rao (4):
>   staging: rtl8712: Remove unnecessary parentheses.
>   staging: rtl8712: Removes the FSF mailing address.
>   staging: rtl8712: Remove space after a cast.
>   staging: rtl8712: Match alignment with open parenthesis.
> 
>  drivers/staging/rtl8712/os_intfs.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)

Can you resend a whole version 2 (or is it 3) of this patch series?
I've dropped your previous patches as they seemed to need more work
based on the reviews.

thanks,

greg k-h

Re: [PATCH 0/4] staging: rtl8712: Fix multiple checkpatch issues.

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 1339 bytes --]



On Friday, February 24, 2017 at 10:58:31 PM UTC+5:30, gregkh wrote:
>
> On Sat, Feb 18, 2017 at 01:25:04AM +0530, Varsha Rao wrote: 
> > Fixes multiple checkpatch issues in rtl8712 driver. 
> > 
> > Varsha Rao (4): 
> >   staging: rtl8712: Remove unnecessary parentheses. 
> >   staging: rtl8712: Removes the FSF mailing address. 
> >   staging: rtl8712: Remove space after a cast. 
> >   staging: rtl8712: Match alignment with open parenthesis. 
> > 
> >  drivers/staging/rtl8712/os_intfs.c | 14 +++++--------- 
> >  1 file changed, 5 insertions(+), 9 deletions(-) 
>
> Can you resend a whole version 2 (or is it 3) of this patch series? 
> I've dropped your previous patches as they seemed to need more work 
> based on the reviews. 
>
>     I don't know but two patches from the patchset, are already applied. 
    Those are the following:
     1] https://groups.google.com/forum/#!topic/outreachy-kernel/73QR9IxiLnY
     2] https://groups.google.com/forum/#!topic/outreachy-kernel/GQMhL7pqSvk
    
   The following are the patches which have not been applied but they are 
acknowledged by Julia:
     1] https://groups.google.com/forum/#!topic/outreachy-kernel/pnbl9sz45ao
     2] 
https://groups.google.com/forum/#!topic/outreachy-kernel/aCvHU5BguH0       
   
      
    So do I have to resend them?
  

> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 1790 bytes --]

Re: [Outreachy kernel] Re: [PATCH 0/4] staging: rtl8712: Fix multiple checkpatch issues.

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]



On Fri, 24 Feb 2017, Varsha Rao wrote:

>
>
> On Friday, February 24, 2017 at 10:58:31 PM UTC+5:30, gregkh wrote:
>       On Sat, Feb 18, 2017 at 01:25:04AM +0530, Varsha Rao wrote:
>       > Fixes multiple checkpatch issues in rtl8712 driver.
>       >
>       > Varsha Rao (4):
>       >   staging: rtl8712: Remove unnecessary parentheses.
>       >   staging: rtl8712: Removes the FSF mailing address.
>       >   staging: rtl8712: Remove space after a cast.
>       >   staging: rtl8712: Match alignment with open parenthesis.
>       >
>       >  drivers/staging/rtl8712/os_intfs.c | 14 +++++---------
>       >  1 file changed, 5 insertions(+), 9 deletions(-)
>
>       Can you resend a whole version 2 (or is it 3) of this patch
>       series?
>       I've dropped your previous patches as they seemed to need more
>       work
>       based on the reviews.
>
>     I don't know but two patches from the patchset, are already applied.
>     Those are the following:
>      1] https://groups.google.com/forum/#!topic/outreachy-kernel/73QR9IxiLnY
>      2] https://groups.google.com/forum/#!topic/outreachy-kernel/GQMhL7pqSvk
>    
>    The following are the patches which have not been applied but they are
> acknowledged by Julia:
>      1] https://groups.google.com/forum/#!topic/outreachy-kernel/pnbl9sz45ao
>      2]
> https://groups.google.com/forum/#!topic/outreachy-kernel/aCvHU5BguH0      
>   
>      
>     So do I have to resend them?

Yes.  My ack just means that I looked at it an it looks OK.  It doesn't
mean that it is integrated into the Linux kernel code in any way.  Patches
get out of date after a while, due to changes on the same or nearby lines
of code.  So after some time, it is better to update your kernel, redo the
changes, and resend the patches.

You can keep my ack in the new version.

julia




>  
>       thanks,
>
>       greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/9b276508-b8aa-4484-970f-
> 82303cb3d8b4%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>