[PATCH 1/4] staging: rtl8712: Remove unnecessary parentheses.

[PATCH 1/4] staging: rtl8712: Remove unnecessary parentheses.

[Varsha Rao]

Removed unnecessary parentheses around pointers to fix the following checkpatch
issues:

CHECK: Unnecessary parentheses around padapter->xmitpriv
CHECK: Unnecessary parentheses around padapter->recvpriv

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/staging/rtl8712/os_intfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index cbe4de0..5638fb6 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -185,8 +185,8 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p)
 static struct net_device_stats *r871x_net_get_stats(struct net_device *pnetdev)
 {
 	struct _adapter *padapter = netdev_priv(pnetdev);
-	struct xmit_priv *pxmitpriv = &(padapter->xmitpriv);
-	struct recv_priv *precvpriv = &(padapter->recvpriv);
+	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+	struct recv_priv *precvpriv = &padapter->recvpriv;
 
 	padapter->stats.tx_packets = pxmitpriv->tx_pkts;
 	padapter->stats.rx_packets = precvpriv->rx_pkts;
-- 
2.9.3

[PATCH 2/4] staging: rtl8712: Removes the FSF mailing address.

[Varsha Rao]

This patch fixes the checkpatch issue by removing the Free Software
Foundation's mailing address from the sample GPL notice. Because the FSF has
changed address in the past, and may change again. Linux already includes a
copy of the GPL.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/staging/rtl8712/os_intfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 5638fb6..f5526a1 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -13,10 +13,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
-- 
2.9.3

[PATCH 3/4] staging: rtl8712: Remove space after a cast.

[Varsha Rao]

This patch fixes the following checkpatch issue:

CHECK: No space is necessary after a cast

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index f5526a1..1141ab3 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -164,7 +164,7 @@ static void loadparam(struct _adapter *padapter, struct  net_device *pnetdev)
 	registry_par->ampdu_enable = (u8)ampdu_enable;
 	registry_par->rf_config = (u8)rf_config;
 	registry_par->low_power = (u8)low_power;
-	registry_par->wifi_test = (u8) wifi_test;
+	registry_par->wifi_test = (u8)wifi_test;
 	r8712_initmac = initmac;
 }
 
-- 
2.9.3

[PATCH 4/4] staging: rtl8712: Match alignment with open parenthesis.

[Varsha Rao]

Matched function arguments alignment with it's open parenthesis. This patch
fixes the following checkpatch issue:

CHECK: Alignment should match open parenthesis

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/staging/rtl8712/os_intfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 1141ab3..8836b31 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -388,7 +388,7 @@ static int netdev_open(struct net_device *pnetdev)
 		if (!r8712_initmac)
 			/* Use the mac address stored in the Efuse */
 			memcpy(pnetdev->dev_addr,
-				padapter->eeprompriv.mac_addr, ETH_ALEN);
+			       padapter->eeprompriv.mac_addr, ETH_ALEN);
 		else {
 			/* We have to inform f/w to use user-supplied MAC
 			 * address.
@@ -405,7 +405,7 @@ static int netdev_open(struct net_device *pnetdev)
 			 * users specify.
 			 */
 			memcpy(padapter->eeprompriv.mac_addr,
-				pnetdev->dev_addr, ETH_ALEN);
+			       pnetdev->dev_addr, ETH_ALEN);
 		}
 		if (start_drv_threads(padapter) != _SUCCESS)
 			goto netdev_open_error;
-- 
2.9.3

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8712: Match alignment with open parenthesis.

[Julia Lawall]

On Sat, 18 Feb 2017, Varsha Rao wrote:

> Matched function arguments alignment with it's open parenthesis. This patch
> fixes the following checkpatch issue:

it's -> its.  it's means "it is".

julia

>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 1141ab3..8836b31 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -388,7 +388,7 @@ static int netdev_open(struct net_device *pnetdev)
>  		if (!r8712_initmac)
>  			/* Use the mac address stored in the Efuse */
>  			memcpy(pnetdev->dev_addr,
> -				padapter->eeprompriv.mac_addr, ETH_ALEN);
> +			       padapter->eeprompriv.mac_addr, ETH_ALEN);
>  		else {
>  			/* We have to inform f/w to use user-supplied MAC
>  			 * address.
> @@ -405,7 +405,7 @@ static int netdev_open(struct net_device *pnetdev)
>  			 * users specify.
>  			 */
>  			memcpy(padapter->eeprompriv.mac_addr,
> -				pnetdev->dev_addr, ETH_ALEN);
> +			       pnetdev->dev_addr, ETH_ALEN);
>  		}
>  		if (start_drv_threads(padapter) != _SUCCESS)
>  			goto netdev_open_error;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58a756e2.0a9d630a.ca478.ffbb%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 3/4] staging: rtl8712: Remove space after a cast.

[Julia Lawall]

On Sat, 18 Feb 2017, Varsha Rao wrote:

> This patch fixes the following checkpatch issue:
>
> CHECK: No space is necessary after a cast
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/rtl8712/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index f5526a1..1141ab3 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -164,7 +164,7 @@ static void loadparam(struct _adapter *padapter, struct  net_device *pnetdev)
>  	registry_par->ampdu_enable = (u8)ampdu_enable;
>  	registry_par->rf_config = (u8)rf_config;
>  	registry_par->low_power = (u8)low_power;
> -	registry_par->wifi_test = (u8) wifi_test;
> +	registry_par->wifi_test = (u8)wifi_test;
>  	r8712_initmac = initmac;
>  }
>
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58a75696.49ca620a.c5fe1.0764%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 2/4] staging: rtl8712: Removes the FSF mailing address.

[Julia Lawall]

On Sat, 18 Feb 2017, Varsha Rao wrote:

> This patch fixes the checkpatch issue by removing the Free Software
> Foundation's mailing address from the sample GPL notice. Because the FSF has
> changed address in the past, and may change again. Linux already includes a
> copy of the GPL.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/rtl8712/os_intfs.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 5638fb6..f5526a1 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -13,10 +13,6 @@
>   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>   * more details.
>   *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
> - *
>   * Modifications for inclusion into the Linux staging tree are
>   * Copyright(c) 2010 Larry Finger. All rights reserved.
>   *
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58a7562a.418f630a.5902a.3267%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8712: Remove unnecessary parentheses.

[Julia Lawall]

On Sat, 18 Feb 2017, Varsha Rao wrote:

> Removed unnecessary parentheses around pointers to fix the following checkpatch

The word "checkpatch" is perhaps within 80 characters but just barely.
Try to be shorter per line in commit messages, because they will be
slightly indented in the git history.

julia

> issues:
>
> CHECK: Unnecessary parentheses around padapter->xmitpriv
> CHECK: Unnecessary parentheses around padapter->recvpriv
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index cbe4de0..5638fb6 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -185,8 +185,8 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p)
>  static struct net_device_stats *r871x_net_get_stats(struct net_device *pnetdev)
>  {
>  	struct _adapter *padapter = netdev_priv(pnetdev);
> -	struct xmit_priv *pxmitpriv = &(padapter->xmitpriv);
> -	struct recv_priv *precvpriv = &(padapter->recvpriv);
> +	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
> +	struct recv_priv *precvpriv = &padapter->recvpriv;
>
>  	padapter->stats.tx_packets = pxmitpriv->tx_pkts;
>  	padapter->stats.rx_packets = precvpriv->rx_pkts;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58a75580.c627620a.da3ab.f2da%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>