All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex
@ 2026-09-14 21:39 Thomas Petazzoni via buildroot
  2026-09-15 17:22 ` Julien Olivain via buildroot
  2026-09-25 14:44 ` Raphaël Mélotte via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-09-14 21:39 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Adrian Perez de Castro

BR2_PACKAGE_SYSPROF selects BR2_PACKAGE_LIBDEX but did not propagate:

	depends on BR2_TOOLCHAIN_HAS_UCONTEXT || \
		BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS

from libdex. This commit fixes this missing dependency. In terms of
Config.in comment, we do the same as what libdex is doing: handle it
as a toolchain dependency (rather than an architecture dependency).

This was missed in commit a73ef093f7b40297d69c6813c44fd4626883632e,
which added the ucontext related dependency to libdex, without
propagating it to sysprof.

Fixes: a73ef093f7b40297d69c6813c44fd4626883632e ("package/libdex: needs ucontext")
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/sysprof/Config.in | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/package/sysprof/Config.in b/package/sysprof/Config.in
index e89a0e539e..258f549152 100644
--- a/package/sysprof/Config.in
+++ b/package/sysprof/Config.in
@@ -9,6 +9,8 @@ config BR2_PACKAGE_SYSPROF
 	depends on !BR2_OPTIMIZE_FAST # polkit
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12
+	depends on BR2_TOOLCHAIN_HAS_UCONTEXT || \
+		BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS # libdex
 	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_JSON_GLIB
 	select BR2_PACKAGE_LIBDEX
@@ -21,13 +23,15 @@ config BR2_PACKAGE_SYSPROF
 
 	  http://sysprof.com
 
-comment "sysprof needs a toolchain w/ dynamic library, wchar, threads, C++, gcc >= 7, headers >= 5.12"
+comment "sysprof needs a toolchain w/ dynamic library, wchar, threads, C++, gcc >= 7, headers >= 5.12, ucontext"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
 		BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12
+		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12 || \
+		!(BR2_TOOLCHAIN_HAS_UCONTEXT || \
+			BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS)
 
 comment "sysprof can't be built with Optimize for fast"
 	depends on BR2_OPTIMIZE_FAST
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex
  2026-09-14 21:39 [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex Thomas Petazzoni via buildroot
@ 2026-09-15 17:22 ` Julien Olivain via buildroot
  2026-09-25 14:44 ` Raphaël Mélotte via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-09-15 17:22 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot, Adrian Perez de Castro

On 14/09/2026 23:39, Thomas Petazzoni via buildroot wrote:
> BR2_PACKAGE_SYSPROF selects BR2_PACKAGE_LIBDEX but did not propagate:
> 
> 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT || \
> 		BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS
> 
> from libdex. This commit fixes this missing dependency. In terms of
> Config.in comment, we do the same as what libdex is doing: handle it
> as a toolchain dependency (rather than an architecture dependency).
> 
> This was missed in commit a73ef093f7b40297d69c6813c44fd4626883632e,
> which added the ucontext related dependency to libdex, without
> propagating it to sysprof.
> 
> Fixes: a73ef093f7b40297d69c6813c44fd4626883632e ("package/libdex: needs 
> ucontext")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex
  2026-09-14 21:39 [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex Thomas Petazzoni via buildroot
  2026-09-15 17:22 ` Julien Olivain via buildroot
@ 2026-09-25 14:44 ` Raphaël Mélotte via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Raphaël Mélotte via buildroot @ 2026-09-25 14:44 UTC (permalink / raw)
  To: buildroot, Thomas Petazzoni; +Cc: Raphaël Mélotte

In reply of:
> BR2_PACKAGE_SYSPROF selects BR2_PACKAGE_LIBDEX but did not propagate:
> 
> 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT || \
> 		BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS
> 
> from libdex. This commit fixes this missing dependency. In terms of
> Config.in comment, we do the same as what libdex is doing: handle it
> as a toolchain dependency (rather than an architecture dependency).
> 
> This was missed in commit a73ef093f7b40297d69c6813c44fd4626883632e,
> which added the ucontext related dependency to libdex, without
> propagating it to sysprof.
> 
> Fixes: a73ef093f7b40297d69c6813c44fd4626883632e ("package/libdex: needs ucontext")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x, 2026.08.x. Thanks

> ---
>  package/sysprof/Config.in | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/sysprof/Config.in b/package/sysprof/Config.in
> index e89a0e539e..258f549152 100644
> --- a/package/sysprof/Config.in
> +++ b/package/sysprof/Config.in
> @@ -9,6 +9,8 @@ config BR2_PACKAGE_SYSPROF
>  	depends on !BR2_OPTIMIZE_FAST # polkit
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12
> +	depends on BR2_TOOLCHAIN_HAS_UCONTEXT || \
> +		BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS # libdex
>  	select BR2_PACKAGE_ELFUTILS
>  	select BR2_PACKAGE_JSON_GLIB
>  	select BR2_PACKAGE_LIBDEX
> @@ -21,13 +23,15 @@ config BR2_PACKAGE_SYSPROF
>  
>  	  http://sysprof.com
>  
> -comment "sysprof needs a toolchain w/ dynamic library, wchar, threads, C++, gcc >= 7, headers >= 5.12"
> +comment "sysprof needs a toolchain w/ dynamic library, wchar, threads, C++, gcc >= 7, headers >= 5.12, ucontext"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
>  		BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
> -		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12
> +		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_12 || \
> +		!(BR2_TOOLCHAIN_HAS_UCONTEXT || \
> +			BR2_PACKAGE_LIBUCONTEXT_ARCH_SUPPORTS)
>  
>  comment "sysprof can't be built with Optimize for fast"
>  	depends on BR2_OPTIMIZE_FAST
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-25 14:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-14 21:39 [Buildroot] [PATCH] package/sysprof: propagate ucontext-related dependency from libdex Thomas Petazzoni via buildroot
2026-09-15 17:22 ` Julien Olivain via buildroot
2026-09-25 14:44 ` Raphaël Mélotte via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.