Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/09/2026 12:32, Alexander Shiyan wrote:
> Hello.
> 
>>>> On Thu, Aug 20, 2026 at 10:55:23AM +0300, Alexander Shiyan wrote:
>>>>> Add devicetree binding for the onsemi AR0234 CMOS image sensor.
>>>>> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ...
>>>>> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
>>> ...
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    enum:
>>>>> +      - onnn,ar0234cssc
>>>>> +      - onnn,ar0234cssm
>>>>> +      - onnn,ar0234cs
>>>>> +    description:
>>>>> +      The AR0234 sensor exists in two different models, a colour variant
>>>>> +      (AR0234CSSC) and a monochrome variant (AR0234CSSM). The device exposes
>>>>> +      the model through registers, allowing for auto-detection with a common
>>>>> +      "onnn,ar0234cs" compatible string.
>>>>
>>>> So all devices are compatible? Then why compatibility is not expressed?
>>>> What are the actual programming differences between sc, sm and "none"
>>>> variants?
>>>
>>> Perhaps I need to revert to the compatibility strings that were used
>>> in version 2
>>> (https://patchwork.kernel.org/project/linux-media/patch/20260807102847.1813059-2-eagle.alexander923@gmail.com/).
>>>
>>> From a programming standpoint, it makes almost no difference which
>>> sensor is used
>>> - the only differences are in the output format and the format count.
>>> Either way, the driver always uses the sensor model determined via
>>> register reads.
>>> If the specified type does not match the detected one, only a warning
>>> will be printed.
>>
>> Devices should be made compatible with the fallback or even the color
>> and mono variants could be dropped. That depends on the difference
>> between color/mono.
> 
> Removing the separation would result in a regression.

What regression? You just proposed these compatibles, they are not
accepted, so how and what possible could ever regress?


Best regards,
Krzysztof