All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Daniel Wagner <wagi@kernel.org>,
	John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH blktests 2/3] common/rc: add _echo() function to trace sysfs attribute writes
Date: Thu, 14 May 2026 08:58:23 -0700	[thread overview]
Message-ID: <58c5d530-416a-4dce-8aa7-099eb571bddc@acm.org> (raw)
In-Reply-To: <agWZZkwOhiSoAvh6@shinmob>

On 5/14/26 2:45 AM, Shin'ichiro Kawasaki wrote:
> On May 13, 2026 / 10:17, Bart Van Assche wrote:
>> Should "echo" or "echo -n" be used in the above shell function?
> 
> I couldn't catch the comment above. The current patch uses "echo", and it's
> working.

We will have to switch to "echo -n" if any code is ever added to
blktests that writes into binary sysfs/debugfs/configfs attributes.

Thanks,

Bart.

  reply	other threads:[~2026-05-14 15:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 11:23 [PATCH blktests 0/3] introduce command trace feature Shin'ichiro Kawasaki
2026-05-13 11:23 ` [PATCH blktests 1/3] check: add --cmd-trace option Shin'ichiro Kawasaki
2026-05-13 17:08   ` Bart Van Assche
2026-05-14  9:36     ` Shin'ichiro Kawasaki
2026-05-14 16:12       ` Bart Van Assche
2026-05-13 11:23 ` [PATCH blktests 2/3] common/rc: add _echo() function to trace sysfs attribute writes Shin'ichiro Kawasaki
2026-05-13 14:05   ` Daniel Wagner
2026-05-13 17:07     ` Bart Van Assche
2026-05-14  9:41       ` Shin'ichiro Kawasaki
2026-05-14 10:36         ` Daniel Wagner
2026-05-13 17:17   ` Bart Van Assche
2026-05-14  9:45     ` Shin'ichiro Kawasaki
2026-05-14 15:58       ` Bart Van Assche [this message]
2026-05-13 11:23 ` [PATCH blktests 3/3] common/nvme, nvme/rc: use _echo() " Shin'ichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58c5d530-416a-4dce-8aa7-099eb571bddc@acm.org \
    --to=bvanassche@acm.org \
    --cc=jmeneghi@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=wagi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.