All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Daniel Wagner <wagi@kernel.org>,
	 John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH blktests 1/3] check: add --cmd-trace option
Date: Thu, 14 May 2026 18:36:31 +0900	[thread overview]
Message-ID: <agWWgSBS2v0sSlUl@shinmob> (raw)
In-Reply-To: <10bc69b1-762f-40a1-94b0-9ce6580b17e1@acm.org>

On May 13, 2026 / 10:08, Bart Van Assche wrote:
> On 5/13/26 4:23 AM, Shin'ichiro Kawasaki wrote:
> > diff --git a/check b/check
> > index c166fae..a68049b 100755
> > --- a/check
> > +++ b/check
> > @@ -458,7 +458,17 @@ _call_test() {
> >   		TIMEFORMAT="%Rs"
> >   		pushd . >/dev/null || return
> > +		if ((CMD_TRACE)); then
> > +			exec 8>"${seqres}.cmdtrace"
> > +			export BASH_XTRACEFD=8
> > +			set -x
> > +		fi
> 
> Hmm ... my experience is that set -x breaks most tests.

I ran whole blktests in my test environment with this series and the --cmd-trace
option, and observed no new failure. If the bash xtrace feature does not work in
any environment, I would like to understand the condition.


  reply	other threads:[~2026-05-14  9:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 11:23 [PATCH blktests 0/3] introduce command trace feature Shin'ichiro Kawasaki
2026-05-13 11:23 ` [PATCH blktests 1/3] check: add --cmd-trace option Shin'ichiro Kawasaki
2026-05-13 17:08   ` Bart Van Assche
2026-05-14  9:36     ` Shin'ichiro Kawasaki [this message]
2026-05-14 16:12       ` Bart Van Assche
2026-05-13 11:23 ` [PATCH blktests 2/3] common/rc: add _echo() function to trace sysfs attribute writes Shin'ichiro Kawasaki
2026-05-13 14:05   ` Daniel Wagner
2026-05-13 17:07     ` Bart Van Assche
2026-05-14  9:41       ` Shin'ichiro Kawasaki
2026-05-14 10:36         ` Daniel Wagner
2026-05-13 17:17   ` Bart Van Assche
2026-05-14  9:45     ` Shin'ichiro Kawasaki
2026-05-14 15:58       ` Bart Van Assche
2026-05-13 11:23 ` [PATCH blktests 3/3] common/nvme, nvme/rc: use _echo() " Shin'ichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agWWgSBS2v0sSlUl@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=jmeneghi@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=wagi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.