* [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job
@ 2017-05-09 8:19 Chunming Zhou
[not found] ` <1494317990-25036-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Chunming Zhou @ 2017-05-09 8:19 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Chunming Zhou
Change-Id: I26d3a2794272ba94b25753d4bf367326d12f6939
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 7 ++++++-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++-
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 787acd7..ef018bf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1162,6 +1162,7 @@ struct amdgpu_job {
struct amdgpu_vm *vm;
struct amdgpu_ring *ring;
struct amdgpu_sync sync;
+ struct amdgpu_sync sched_sync;
struct amdgpu_ib *ibs;
struct fence *fence; /* the hw fence */
uint32_t preamble_status;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
index 2c6624d..86ad507 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -121,6 +121,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
{
struct amdgpu_device *adev = ring->adev;
struct amdgpu_ib *ib = &ibs[0];
+ struct fence *tmp;
bool skip_preamble, need_ctx_switch;
unsigned patch_offset = ~0;
struct amdgpu_vm *vm;
@@ -167,8 +168,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
return r;
}
- if (ring->funcs->emit_pipeline_sync && job && job->need_pipeline_sync)
+ if (ring->funcs->emit_pipeline_sync && job &&
+ (tmp = amdgpu_sync_get_fence(&job->sched_sync))) {
+ job->need_pipeline_sync = true;
amdgpu_ring_emit_pipeline_sync(ring);
+ fence_put(tmp);
+ }
if (vm) {
amdgpu_ring_insert_nop(ring, extra_nop); /* prevent CE go too fast than DE */
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index cfa97ab..fa0c8b1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -60,6 +60,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, unsigned num_ibs,
(*job)->need_pipeline_sync = false;
amdgpu_sync_create(&(*job)->sync);
+ amdgpu_sync_create(&(*job)->sched_sync);
return 0;
}
@@ -98,6 +99,7 @@ static void amdgpu_job_free_cb(struct amd_sched_job *s_job)
fence_put(job->fence);
amdgpu_sync_free(&job->sync);
+ amdgpu_sync_free(&job->sched_sync);
kfree(job);
}
@@ -107,6 +109,7 @@ void amdgpu_job_free(struct amdgpu_job *job)
fence_put(job->fence);
amdgpu_sync_free(&job->sync);
+ amdgpu_sync_free(&job->sched_sync);
kfree(job);
}
@@ -154,7 +157,7 @@ static struct fence *amdgpu_job_dependency(struct amd_sched_job *sched_job)
}
if (amd_sched_dependency_optimized(fence, sched_job->s_entity))
- job->need_pipeline_sync = true;
+ amdgpu_sync_fence(job->adev, &job->sched_sync, fence);
return fence;
}
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1494317990-25036-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job [not found] ` <1494317990-25036-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org> @ 2017-05-09 8:40 ` Zhang, Jerry (Junwei) 0 siblings, 0 replies; 5+ messages in thread From: Zhang, Jerry (Junwei) @ 2017-05-09 8:40 UTC (permalink / raw) To: Chunming Zhou, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 05/09/2017 04:19 PM, Chunming Zhou wrote: > Change-Id: I26d3a2794272ba94b25753d4bf367326d12f6939 > Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 7 ++++++- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++- > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index 787acd7..ef018bf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -1162,6 +1162,7 @@ struct amdgpu_job { > struct amdgpu_vm *vm; > struct amdgpu_ring *ring; > struct amdgpu_sync sync; > + struct amdgpu_sync sched_sync; > struct amdgpu_ib *ibs; > struct fence *fence; /* the hw fence */ > uint32_t preamble_status; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > index 2c6624d..86ad507 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > @@ -121,6 +121,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, > { > struct amdgpu_device *adev = ring->adev; > struct amdgpu_ib *ib = &ibs[0]; > + struct fence *tmp; > bool skip_preamble, need_ctx_switch; > unsigned patch_offset = ~0; > struct amdgpu_vm *vm; > @@ -167,8 +168,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, > return r; > } > > - if (ring->funcs->emit_pipeline_sync && job && job->need_pipeline_sync) > + if (ring->funcs->emit_pipeline_sync && job && > + (tmp = amdgpu_sync_get_fence(&job->sched_sync))) { > + job->need_pipeline_sync = true; We might remove need_pipeline_sync now. Jerry > amdgpu_ring_emit_pipeline_sync(ring); > + fence_put(tmp); > + } > if (vm) { > amdgpu_ring_insert_nop(ring, extra_nop); /* prevent CE go too fast than DE */ > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > index cfa97ab..fa0c8b1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > @@ -60,6 +60,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, unsigned num_ibs, > (*job)->need_pipeline_sync = false; > > amdgpu_sync_create(&(*job)->sync); > + amdgpu_sync_create(&(*job)->sched_sync); > > return 0; > } > @@ -98,6 +99,7 @@ static void amdgpu_job_free_cb(struct amd_sched_job *s_job) > > fence_put(job->fence); > amdgpu_sync_free(&job->sync); > + amdgpu_sync_free(&job->sched_sync); > kfree(job); > } > > @@ -107,6 +109,7 @@ void amdgpu_job_free(struct amdgpu_job *job) > > fence_put(job->fence); > amdgpu_sync_free(&job->sync); > + amdgpu_sync_free(&job->sched_sync); > kfree(job); > } > > @@ -154,7 +157,7 @@ static struct fence *amdgpu_job_dependency(struct amd_sched_job *sched_job) > } > > if (amd_sched_dependency_optimized(fence, sched_job->s_entity)) > - job->need_pipeline_sync = true; > + amdgpu_sync_fence(job->adev, &job->sched_sync, fence); > > return fence; > } > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] drm/amd: fix init order of sched job
@ 2017-05-09 8:14 Chunming Zhou
[not found] ` <1494317649-16751-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Chunming Zhou @ 2017-05-09 8:14 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Chunming Zhou
Change-Id: Iced391f5c24a79ad7aecae33e22ff089f68f1337
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
index 80bc4f7..3c258c3 100644
--- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
+++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
@@ -460,9 +460,9 @@ int amd_sched_job_init(struct amd_sched_job *job,
job->sched = sched;
job->s_entity = entity;
job->s_fence = amd_sched_fence_create(entity, owner);
- job->id = atomic64_inc_return(&sched->job_id_count);
if (!job->s_fence)
return -ENOMEM;
+ job->id = atomic64_inc_return(&sched->job_id_count);
INIT_WORK(&job->finish_work, amd_sched_job_finish);
INIT_LIST_HEAD(&job->node);
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1494317649-16751-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>]
* [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job [not found] ` <1494317649-16751-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org> @ 2017-05-09 8:14 ` Chunming Zhou [not found] ` <1494317649-16751-3-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Chunming Zhou @ 2017-05-09 8:14 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Chunming Zhou Change-Id: I26d3a2794272ba94b25753d4bf367326d12f6939 Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +++++- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 787acd7..ef018bf 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -1162,6 +1162,7 @@ struct amdgpu_job { struct amdgpu_vm *vm; struct amdgpu_ring *ring; struct amdgpu_sync sync; + struct amdgpu_sync sched_sync; struct amdgpu_ib *ibs; struct fence *fence; /* the hw fence */ uint32_t preamble_status; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c index 2c6624d..d7f75bc 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c @@ -167,8 +167,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, return r; } - if (ring->funcs->emit_pipeline_sync && job && job->need_pipeline_sync) + if (ring->funcs->emit_pipeline_sync && job && + (tmp = amdgpu_sync_get_fence(&job->sched_sync))) { + job->need_pipeline_sync = true; amdgpu_ring_emit_pipeline_sync(ring); + fence_put(tmp); + } if (vm) { amdgpu_ring_insert_nop(ring, extra_nop); /* prevent CE go too fast than DE */ diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c index cfa97ab..fa0c8b1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c @@ -60,6 +60,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, unsigned num_ibs, (*job)->need_pipeline_sync = false; amdgpu_sync_create(&(*job)->sync); + amdgpu_sync_create(&(*job)->sched_sync); return 0; } @@ -98,6 +99,7 @@ static void amdgpu_job_free_cb(struct amd_sched_job *s_job) fence_put(job->fence); amdgpu_sync_free(&job->sync); + amdgpu_sync_free(&job->sched_sync); kfree(job); } @@ -107,6 +109,7 @@ void amdgpu_job_free(struct amdgpu_job *job) fence_put(job->fence); amdgpu_sync_free(&job->sync); + amdgpu_sync_free(&job->sched_sync); kfree(job); } @@ -154,7 +157,7 @@ static struct fence *amdgpu_job_dependency(struct amd_sched_job *sched_job) } if (amd_sched_dependency_optimized(fence, sched_job->s_entity)) - job->need_pipeline_sync = true; + amdgpu_sync_fence(job->adev, &job->sched_sync, fence); return fence; } -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <1494317649-16751-3-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job [not found] ` <1494317649-16751-3-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org> @ 2017-05-09 11:16 ` Christian König [not found] ` <1ccd8f37-0297-315e-0355-f38b1b511924-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Christian König @ 2017-05-09 11:16 UTC (permalink / raw) To: Chunming Zhou, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW What's the background of this change? E.g. why it is needed? Christian. Am 09.05.2017 um 10:14 schrieb Chunming Zhou: > Change-Id: I26d3a2794272ba94b25753d4bf367326d12f6939 > Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +++++- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++- > 3 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index 787acd7..ef018bf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -1162,6 +1162,7 @@ struct amdgpu_job { > struct amdgpu_vm *vm; > struct amdgpu_ring *ring; > struct amdgpu_sync sync; > + struct amdgpu_sync sched_sync; > struct amdgpu_ib *ibs; > struct fence *fence; /* the hw fence */ > uint32_t preamble_status; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > index 2c6624d..d7f75bc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > @@ -167,8 +167,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, > return r; > } > > - if (ring->funcs->emit_pipeline_sync && job && job->need_pipeline_sync) > + if (ring->funcs->emit_pipeline_sync && job && > + (tmp = amdgpu_sync_get_fence(&job->sched_sync))) { > + job->need_pipeline_sync = true; > amdgpu_ring_emit_pipeline_sync(ring); > + fence_put(tmp); > + } > if (vm) { > amdgpu_ring_insert_nop(ring, extra_nop); /* prevent CE go too fast than DE */ > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > index cfa97ab..fa0c8b1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > @@ -60,6 +60,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, unsigned num_ibs, > (*job)->need_pipeline_sync = false; > > amdgpu_sync_create(&(*job)->sync); > + amdgpu_sync_create(&(*job)->sched_sync); > > return 0; > } > @@ -98,6 +99,7 @@ static void amdgpu_job_free_cb(struct amd_sched_job *s_job) > > fence_put(job->fence); > amdgpu_sync_free(&job->sync); > + amdgpu_sync_free(&job->sched_sync); > kfree(job); > } > > @@ -107,6 +109,7 @@ void amdgpu_job_free(struct amdgpu_job *job) > > fence_put(job->fence); > amdgpu_sync_free(&job->sync); > + amdgpu_sync_free(&job->sched_sync); > kfree(job); > } > > @@ -154,7 +157,7 @@ static struct fence *amdgpu_job_dependency(struct amd_sched_job *sched_job) > } > > if (amd_sched_dependency_optimized(fence, sched_job->s_entity)) > - job->need_pipeline_sync = true; > + amdgpu_sync_fence(job->adev, &job->sched_sync, fence); > > return fence; > } _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1ccd8f37-0297-315e-0355-f38b1b511924-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>]
* Re: [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job [not found] ` <1ccd8f37-0297-315e-0355-f38b1b511924-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> @ 2017-05-10 1:58 ` zhoucm1 0 siblings, 0 replies; 5+ messages in thread From: zhoucm1 @ 2017-05-10 1:58 UTC (permalink / raw) To: Christian König, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 2017年05月09日 19:16, Christian König wrote: > What's the background of this change? E.g. why it is needed? price question, maybe I should describe more in patch comment, I think this is an improvement for previous patch, the sched_sync is to store fence that could be skipped as scheduled, when job is executed, we didn't need pipeline_sync if all fences in sched_sync are signalled, otherwise insert pipeline_sync still. Regards, David Zhou > > Christian. > > Am 09.05.2017 um 10:14 schrieb Chunming Zhou: >> Change-Id: I26d3a2794272ba94b25753d4bf367326d12f6939 >> Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + >> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +++++- >> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++- >> 3 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> index 787acd7..ef018bf 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> @@ -1162,6 +1162,7 @@ struct amdgpu_job { >> struct amdgpu_vm *vm; >> struct amdgpu_ring *ring; >> struct amdgpu_sync sync; >> + struct amdgpu_sync sched_sync; >> struct amdgpu_ib *ibs; >> struct fence *fence; /* the hw fence */ >> uint32_t preamble_status; >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c >> index 2c6624d..d7f75bc 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c >> @@ -167,8 +167,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, >> unsigned num_ibs, >> return r; >> } >> - if (ring->funcs->emit_pipeline_sync && job && >> job->need_pipeline_sync) >> + if (ring->funcs->emit_pipeline_sync && job && >> + (tmp = amdgpu_sync_get_fence(&job->sched_sync))) { >> + job->need_pipeline_sync = true; >> amdgpu_ring_emit_pipeline_sync(ring); >> + fence_put(tmp); >> + } >> if (vm) { >> amdgpu_ring_insert_nop(ring, extra_nop); /* prevent CE go >> too fast than DE */ >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c >> index cfa97ab..fa0c8b1 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c >> @@ -60,6 +60,7 @@ int amdgpu_job_alloc(struct amdgpu_device *adev, >> unsigned num_ibs, >> (*job)->need_pipeline_sync = false; >> amdgpu_sync_create(&(*job)->sync); >> + amdgpu_sync_create(&(*job)->sched_sync); >> return 0; >> } >> @@ -98,6 +99,7 @@ static void amdgpu_job_free_cb(struct amd_sched_job >> *s_job) >> fence_put(job->fence); >> amdgpu_sync_free(&job->sync); >> + amdgpu_sync_free(&job->sched_sync); >> kfree(job); >> } >> @@ -107,6 +109,7 @@ void amdgpu_job_free(struct amdgpu_job *job) >> fence_put(job->fence); >> amdgpu_sync_free(&job->sync); >> + amdgpu_sync_free(&job->sched_sync); >> kfree(job); >> } >> @@ -154,7 +157,7 @@ static struct fence >> *amdgpu_job_dependency(struct amd_sched_job *sched_job) >> } >> if (amd_sched_dependency_optimized(fence, sched_job->s_entity)) >> - job->need_pipeline_sync = true; >> + amdgpu_sync_fence(job->adev, &job->sched_sync, fence); >> return fence; >> } > > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-10 1:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-09 8:19 [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job Chunming Zhou
[not found] ` <1494317990-25036-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-05-09 8:40 ` Zhang, Jerry (Junwei)
-- strict thread matches above, loose matches on Subject: below --
2017-05-09 8:14 [PATCH 1/3] drm/amd: fix init order of sched job Chunming Zhou
[not found] ` <1494317649-16751-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-05-09 8:14 ` [PATCH 3/3] drm/amdgpu: add sched sync for amdgpu job Chunming Zhou
[not found] ` <1494317649-16751-3-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2017-05-09 11:16 ` Christian König
[not found] ` <1ccd8f37-0297-315e-0355-f38b1b511924-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-10 1:58 ` zhoucm1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.